{"html_url": "https://github.com/simonw/datasette/issues/351#issuecomment-635533807", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/351", "id": 635533807, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTUzMzgwNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T18:56:15Z", "updated_at": "2020-05-28T18:56:15Z", "author_association": "OWNER", "body": "I'm not going to do this. I have a good enough solution now pasting the rendered HTML from the release notes into https://euangoddard.github.io/clipboard2markdown/ to get the Markdown.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 345469355, "label": "Automatically create a GitHub release linking to release notes for every tagged release"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/508#issuecomment-635532216", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/508", "id": 635532216, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTUzMjIxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T18:53:02Z", "updated_at": "2020-05-28T18:53:02Z", "author_association": "OWNER", "body": "I fixed this a while ago in #702: https://datasette.readthedocs.io/en/stable/metadata.html#setting-a-default-sort-order", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 455965174, "label": "Ability to set default sort order for a table or view in metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/774#issuecomment-635530876", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/774", "id": 635530876, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTUzMDg3Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T18:50:18Z", "updated_at": "2020-05-28T18:50:18Z", "author_association": "OWNER", "body": "How about moving this functionality to the request object itself?\r\n```python\r\nq = request[\"q\"]  # Raises KeyError if missing, otherwise returns first\r\nq = request.get(\"q\", \"default\") # Returns first, or optional default or None\r\nfacets = request.getlist(\"_facet\")\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626078521, "label": "Consolidate request.raw_args and request.args"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/777#issuecomment-635513983", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/777", "id": 635513983, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTUxMzk4Mw==", "user": {"value": 63653929, "label": "thisismyfuckingusername"}, "created_at": "2020-05-28T18:16:49Z", "updated_at": "2020-05-28T18:16:49Z", "author_association": "NONE", "body": " think, because the given URL of the CSS file doesn't have any complete parameters after query \r\nTry to complete the parameter \r\n`<link rel=\"stylesheet\" href=\"-/static/app.css?(whatever you want that shows a css file)\">`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626171242, "label": "Error pages not correctly loading CSS"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635494730", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635494730, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ5NDczMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T17:39:54Z", "updated_at": "2020-05-28T17:39:54Z", "author_association": "OWNER", "body": "https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.niche-museums.com%2Fbrowse%2Ffeed.atom validates now!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/780#issuecomment-635480948", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/780", "id": 635480948, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ4MDk0OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T17:12:45Z", "updated_at": "2020-05-28T17:12:45Z", "author_association": "OWNER", "body": "This is a good opportunity to reconsider the design of this function and see if I'm happy with it as-is or if there are some improvements I want to make before adding it to the documented API.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626593402, "label": "Internals documentation for datasette.metadata() method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635471007", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635471007, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ3MTAwNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T16:58:47Z", "updated_at": "2020-05-28T16:58:47Z", "author_association": "OWNER", "body": "I'm inclined to do this at the earliest possible moment. I think that's probably in the `DatasetteRouter` class, which should see every `scope` first and be able to apply that setting to it. It already has some special case logic to deal with the `base_url` setting here:\r\n\r\nhttps://github.com/simonw/datasette/blob/40885ef24e32d91502b6b8bbad1c7376f50f2830/datasette/app.py#L779-L789", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/781#issuecomment-635468994", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/781", "id": 635468994, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQ2ODk5NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T16:55:35Z", "updated_at": "2020-05-28T16:55:35Z", "author_association": "OWNER", "body": "I think the right way to fix this is to modify the `scope[\"scheme\"]` ASGI key before the Request object is constructed - otherwise that Request class will have to gain knowledge of Datasette's configuration mechanism.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626663119, "label": "request.url and request.scheme should obey force_https_urls config setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/780#issuecomment-635413437", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/780", "id": 635413437, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTQxMzQzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T15:15:03Z", "updated_at": "2020-05-28T15:15:03Z", "author_association": "OWNER", "body": "Also: I think I should add a `query=` parameter to help lookup metadata about a specific named canned query.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626593402, "label": "Internals documentation for datasette.metadata() method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/744#issuecomment-635386935", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/744", "id": 635386935, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTM4NjkzNQ==", "user": {"value": 30607, "label": "aborruso"}, "created_at": "2020-05-28T14:32:53Z", "updated_at": "2020-05-28T14:32:53Z", "author_association": "NONE", "body": "Wow, I'm in some way very proud!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 608058890, "label": "link_or_copy_directory() error - Invalid cross-device link"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/744#issuecomment-635384739", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/744", "id": 635384739, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTM4NDczOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T14:28:58Z", "updated_at": "2020-05-28T14:28:58Z", "author_association": "OWNER", "body": "This is now released. `pip install datasette==0.43` should get the fix.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 608058890, "label": "link_or_copy_directory() error - Invalid cross-device link"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/758#issuecomment-635195322", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/758", "id": 635195322, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTE5NTMyMg==", "user": {"value": 2181410, "label": "clausjuhl"}, "created_at": "2020-05-28T08:23:27Z", "updated_at": "2020-05-28T08:23:27Z", "author_association": "NONE", "body": "@simonw I would prefer just the 7 character hash. No need to make the urls any longer than they need to be :)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 612382643, "label": "Question: Access to immutable database-path"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/706#issuecomment-635131217", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/706", "id": 635131217, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTEzMTIxNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T06:20:44Z", "updated_at": "2020-05-28T06:20:44Z", "author_association": "OWNER", "body": "Documentation: https://datasette.readthedocs.io/en/latest/sql_queries.html#canned-queries-default-fragment", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 585633142, "label": "Documentation for the \"request\" object"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/758#issuecomment-635102675", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/758", "id": 635102675, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTEwMjY3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T05:04:07Z", "updated_at": "2020-05-28T05:04:07Z", "author_association": "OWNER", "body": "@clausjuhl do you have any thoughts on what would be most useful for you in these JSON responses? The full `/databasename-hash` path, just the 7 character hash, or something else?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 612382643, "label": "Question: Access to immutable database-path"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/751#issuecomment-635101438", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/751", "id": 635101438, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTEwMTQzOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T05:00:21Z", "updated_at": "2020-05-28T05:00:21Z", "author_association": "OWNER", "body": "Documentation: https://datasette.readthedocs.io/en/latest/metadata.html#setting-a-custom-page-size", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 611540797, "label": "Ability to set custom default _size on a per-table basis"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/773#issuecomment-635069987", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/773", "id": 635069987, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA2OTk4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T03:13:27Z", "updated_at": "2020-05-28T03:13:27Z", "author_association": "OWNER", "body": "`register_output_renderer` test added in https://github.com/simonw/datasette/commit/52c4387c7d37c867104e3728cc1f4c4d1e100642#diff-56f7d7b4778bac73b6b655c02c8467aaR336", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626001501, "label": "All plugin hooks should have unit tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/770#issuecomment-635056520", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/770", "id": 635056520, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA1NjUyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T02:28:00Z", "updated_at": "2020-05-28T02:28:00Z", "author_association": "OWNER", "body": "This should be optionally awaitable, as in #776", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 625930207, "label": "register_output_renderer can_render mechanism"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/776#issuecomment-635056357", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/776", "id": 635056357, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA1NjM1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T02:27:26Z", "updated_at": "2020-05-28T02:27:26Z", "author_association": "OWNER", "body": "Example code from elsewhere:\r\nhttps://github.com/simonw/datasette/blob/52c4387c7d37c867104e3728cc1f4c4d1e100642/datasette/views/base.py#L416-L420", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626163974, "label": "register_output_renderer render callback should be optionally awaitable"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/581#issuecomment-635055346", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/581", "id": 635055346, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA1NTM0Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T02:24:14Z", "updated_at": "2020-05-28T02:24:14Z", "author_association": "OWNER", "body": "Updated documentation is here: https://datasette.readthedocs.io/en/latest/plugins.html#register-output-renderer-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 502993509, "label": "Redesign register_output_renderer callback"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/645#issuecomment-635054690", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/645", "id": 635054690, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTA1NDY5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T02:22:12Z", "updated_at": "2020-05-28T02:22:12Z", "author_association": "OWNER", "body": "This is a duplicate of a more recent, more developed issue: #770", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 530653633, "label": "Mechanism for register_output_renderer to suggest extension or not"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/775#issuecomment-635023389", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/775", "id": 635023389, "node_id": "MDEyOklzc3VlQ29tbWVudDYzNTAyMzM4OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-05-28T00:47:32Z", "updated_at": "2020-05-28T00:47:32Z", "author_association": "OWNER", "body": "These:\r\n\r\nhttps://github.com/simonw/datasette/blob/4b96857f170e329a73186e703cc0d9ca4e8719cc/tests/fixtures.py#L337-L506", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 626131309, "label": "Move test plugins into datasette/tests/plugins/ directory"}, "performed_via_github_app": null}