{"html_url": "https://github.com/simonw/datasette/pull/2181#issuecomment-1711054840", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2181", "id": 1711054840, "node_id": "IC_kwDOBm6k_c5l_J_4", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-09-08T04:23:47Z", "updated_at": "2023-09-08T04:23:47Z", "author_association": "OWNER", "body": "I've implemented this hook once now in:\r\n- https://github.com/datasette/datasette-remote-actors\r\n\r\nAnd built and tested a debug tool for it in:\r\n- https://github.com/datasette/datasette-debug-actors-from-ids\r\n\r\nI'm now confident in the design of this plugin hook, I'm going to land it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1886812002, "label": "actors_from_ids plugin hook and datasette.actors_from_ids() method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2181#issuecomment-1710972324", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2181", "id": 1710972324, "node_id": "IC_kwDOBm6k_c5l-12k", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-09-08T01:58:44Z", "updated_at": "2023-09-08T03:43:43Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch coverage: **`100.00%`** and no project coverage change.\n> Comparison is base [(`c263704`)](https://app.codecov.io/gh/simonw/datasette/commit/c26370485a4fd4bf130da051be9163d92c57f24f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.68% compared to head [(`e1c5a9d`)](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.69%.\n\n<details><summary>Additional details and impacted files</summary>\n\n\n```diff\n@@           Coverage Diff           @@\n##             main    #2181   +/-   ##\n=======================================\n  Coverage   92.68%   92.69%           \n=======================================\n  Files          40       40           \n  Lines        6017     6025    +8     \n=======================================\n+ Hits         5577     5585    +8     \n  Misses        440      440           \n```\n\n\n| [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/app.py](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.43% <100.00%> (+0.03%)` | :arrow_up: |\n| [datasette/hookspecs.py](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2hvb2tzcGVjcy5weQ==) | `100.00% <100.00%> (\u00f8)` | |\n\n\n</details>\n\n[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/simonw/datasette/pull/2181?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).   \n\n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1886812002, "label": "actors_from_ids plugin hook and datasette.actors_from_ids() method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2181#issuecomment-1710969448", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2181", "id": 1710969448, "node_id": "IC_kwDOBm6k_c5l-1Jo", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-09-08T01:53:27Z", "updated_at": "2023-09-08T01:53:27Z", "author_association": "OWNER", "body": "Documentation preview:\r\n- https://datasette--2181.org.readthedocs.build/en/2181/internals.html#await-actors-from-ids-actor-ids\r\n- https://datasette--2181.org.readthedocs.build/en/2181/plugin_hooks.html#plugin-hook-actors-from-ids", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1886812002, "label": "actors_from_ids plugin hook and datasette.actors_from_ids() method"}, "performed_via_github_app": null}