{"html_url": "https://github.com/simonw/sqlite-utils/pull/118#issuecomment-655653292", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/118", "id": 655653292, "node_id": "MDEyOklzc3VlQ29tbWVudDY1NTY1MzI5Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-08T17:26:02Z", "updated_at": "2020-07-08T17:26:02Z", "author_association": "OWNER", "body": "Awesome, thank you very much.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 651844316, "label": "Add insert --truncate option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/118#issuecomment-655286864", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/118", "id": 655286864, "node_id": "MDEyOklzc3VlQ29tbWVudDY1NTI4Njg2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-08T05:05:27Z", "updated_at": "2020-07-08T05:05:36Z", "author_association": "OWNER", "body": "The only thing missing from this PR is updates to the documentation. Those need to go in two places:\r\n\r\n- In the Python API docs. I suggest adding a note to this section about bulk inserts: https://github.com/simonw/sqlite-utils/blob/d0cdaaaf00249230e847be3a3b393ee2689fbfe4/docs/python-api.rst#bulk-inserts\r\n- In the CLI docs, in this section: https://github.com/simonw/sqlite-utils/blob/d0cdaaaf00249230e847be3a3b393ee2689fbfe4/docs/cli.rst#inserting-json-data\r\n\r\nHere's an example of a previous commit that includes updates to both CLI and API documentation: https://github.com/simonw/sqlite-utils/commit/f9473ace14878212c1fa968b7bd2f51e4f064dba#diff-e3e2a9bfd88566b05001b02a3f51d286", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 651844316, "label": "Add insert --truncate option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/118#issuecomment-655284168", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/118", "id": 655284168, "node_id": "MDEyOklzc3VlQ29tbWVudDY1NTI4NDE2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-08T04:58:00Z", "updated_at": "2020-07-08T04:58:00Z", "author_association": "OWNER", "body": "Oops didn't mean to click \"close\" there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 651844316, "label": "Add insert --truncate option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/118#issuecomment-655284054", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/118", "id": 655284054, "node_id": "MDEyOklzc3VlQ29tbWVudDY1NTI4NDA1NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-08T04:57:38Z", "updated_at": "2020-07-08T04:57:38Z", "author_association": "OWNER", "body": "Thoughts on transactions would be much appreciated in #121 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 651844316, "label": "Add insert --truncate option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/118#issuecomment-655283393", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/118", "id": 655283393, "node_id": "MDEyOklzc3VlQ29tbWVudDY1NTI4MzM5Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-08T04:55:18Z", "updated_at": "2020-07-08T04:55:18Z", "author_association": "OWNER", "body": "This is a really good idea - and thank you for the detailed discussion in the pull request.\r\n\r\nI'm keen to discuss how transactions can work better. I tend to use this pattern in my own code:\r\n\r\n    with db.conn:\r\n        db[\"table\"].insert(...)\r\n\r\nBut it's not documented and I've not though very hard about it!\r\n\r\nI like having inserts that handle 10,000+ rows commit on every chunk so I can watch their progress from another process, but the library should absolutely support people who want to commit all of the rows in a single transaction - or combine changes with DML.\r\n\r\nLots to discuss here. I'll start a new issue.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 651844316, "label": "Add insert --truncate option"}, "performed_via_github_app": null}