issue_comments
20 rows where "created_at" is on date 2019-11-11 sorted by user
This data as json, CSV (advanced)
Suggested facets: body
user 2
- simonw 19
- tomchristie 1
id | html_url | issue_url | node_id | user ▼ | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
552251645 | https://github.com/simonw/datasette/issues/621#issuecomment-552251645 | https://api.github.com/repos/simonw/datasette/issues/621 | MDEyOklzc3VlQ29tbWVudDU1MjI1MTY0NQ== | simonw 9599 | 2019-11-11T00:23:56Z | 2019-11-11T00:33:31Z | OWNER | Current syntax: https://datasette.readthedocs.io/en/stable/json_api.html#special-table-arguments
Demo: https://latest.datasette.io/fixtures/roadside_attractions?_through={%22table%22:%22roadside_attraction_characteristics%22,%22column%22:%22characteristic_id%22,%22value%22:%221%22} The alternative syntax for that could be: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Syntax for ?_through= that works as a form field 520681725 | |
552251666 | https://github.com/simonw/datasette/issues/621#issuecomment-552251666 | https://api.github.com/repos/simonw/datasette/issues/621 | MDEyOklzc3VlQ29tbWVudDU1MjI1MTY2Ng== | simonw 9599 | 2019-11-11T00:24:09Z | 2019-11-11T00:32:49Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Syntax for ?_through= that works as a form field 520681725 | ||
552251831 | https://github.com/simonw/datasette/issues/620#issuecomment-552251831 | https://api.github.com/repos/simonw/datasette/issues/620 | MDEyOklzc3VlQ29tbWVudDU1MjI1MTgzMQ== | simonw 9599 | 2019-11-11T00:25:58Z | 2019-11-11T00:25:58Z | OWNER | There are three pieces of information that need to be described here: the column, the other table and the other table column. We already have a piece of API design that is similar to this: the
I'm rethinking this syntax in #621 though to support a non-JSON variant that looks more like this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for indicating foreign key relationships in the table and query page URLs 520667773 | |
552252074 | https://github.com/simonw/datasette/issues/620#issuecomment-552252074 | https://api.github.com/repos/simonw/datasette/issues/620 | MDEyOklzc3VlQ29tbWVudDU1MjI1MjA3NA== | simonw 9599 | 2019-11-11T00:28:28Z | 2019-11-11T00:30:53Z | OWNER | So for foreign key definitions it could look like this:
Or for columns and table names that themselves contain dots it could be:
The value (before the =) is unambiguous -it's Added bonus: if you're referencing another table's single primary key you can omit the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for indicating foreign key relationships in the table and query page URLs 520667773 | |
552252199 | https://github.com/simonw/datasette/issues/620#issuecomment-552252199 | https://api.github.com/repos/simonw/datasette/issues/620 | MDEyOklzc3VlQ29tbWVudDU1MjI1MjE5OQ== | simonw 9599 | 2019-11-11T00:29:36Z | 2019-11-11T00:29:36Z | OWNER | This new |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for indicating foreign key relationships in the table and query page URLs 520667773 | |
552253208 | https://github.com/simonw/datasette/issues/621#issuecomment-552253208 | https://api.github.com/repos/simonw/datasette/issues/621 | MDEyOklzc3VlQ29tbWVudDU1MjI1MzIwOA== | simonw 9599 | 2019-11-11T00:39:57Z | 2019-11-11T00:39:57Z | OWNER | This is a nice opportunity to help with the refactoring of the table view in #617 - the above code snippet takes the request, looks at the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Syntax for ?_through= that works as a form field 520681725 | |
552253893 | https://github.com/simonw/datasette/issues/617#issuecomment-552253893 | https://api.github.com/repos/simonw/datasette/issues/617 | MDEyOklzc3VlQ29tbWVudDU1MjI1Mzg5Mw== | simonw 9599 | 2019-11-11T00:46:42Z | 2021-12-18T01:41:47Z | OWNER | As noted in https://github.com/simonw/datasette/issues/621#issuecomment-552253208 a common pattern in this method is blocks of code that append new items to the Code that fits this pattern:
The keyset pagination code modifies [UPDATE December 2021 - this comment became the basis for a new |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor TableView.data() method 519613116 | |
552254238 | https://github.com/simonw/datasette/issues/617#issuecomment-552254238 | https://api.github.com/repos/simonw/datasette/issues/617 | MDEyOklzc3VlQ29tbWVudDU1MjI1NDIzOA== | simonw 9599 | 2019-11-11T00:49:57Z | 2019-11-11T00:51:35Z | OWNER | I experimented with a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor TableView.data() method 519613116 | |
552254753 | https://github.com/simonw/datasette/issues/617#issuecomment-552254753 | https://api.github.com/repos/simonw/datasette/issues/617 | MDEyOklzc3VlQ29tbWVudDU1MjI1NDc1Mw== | simonw 9599 | 2019-11-11T00:54:51Z | 2019-11-11T00:54:51Z | OWNER | That |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor TableView.data() method 519613116 | |
552275451 | https://github.com/simonw/datasette/pull/181#issuecomment-552275451 | https://api.github.com/repos/simonw/datasette/issues/181 | MDEyOklzc3VlQ29tbWVudDU1MjI3NTQ1MQ== | simonw 9599 | 2019-11-11T03:08:25Z | 2019-11-11T03:08:25Z | OWNER | Closing this because this feature was shipped in #592 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
add "format sql" button to query page, uses sql-formatter 289425975 | |
552275668 | https://github.com/simonw/datasette/pull/595#issuecomment-552275668 | https://api.github.com/repos/simonw/datasette/issues/595 | MDEyOklzc3VlQ29tbWVudDU1MjI3NTY2OA== | simonw 9599 | 2019-11-11T03:09:43Z | 2019-11-11T03:09:43Z | OWNER | Glitch has been upgraded to Python 3.7. I think I'm happy to drop 3.5 support now - users who want Python 3.5 can get it by installing |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941 | |
552276237 | https://github.com/simonw/datasette/pull/595#issuecomment-552276237 | https://api.github.com/repos/simonw/datasette/issues/595 | MDEyOklzc3VlQ29tbWVudDU1MjI3NjIzNw== | simonw 9599 | 2019-11-11T03:12:56Z | 2019-11-11T03:12:56Z | OWNER | 622 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941 | |
552276247 | https://github.com/simonw/datasette/issues/594#issuecomment-552276247 | https://api.github.com/repos/simonw/datasette/issues/594 | MDEyOklzc3VlQ29tbWVudDU1MjI3NjI0Nw== | simonw 9599 | 2019-11-11T03:13:00Z | 2019-11-11T03:13:00Z | OWNER | 622 |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
upgrade to uvicorn-0.9 to be Python-3.8 friendly 506297048 | |
552276277 | https://github.com/simonw/datasette/pull/404#issuecomment-552276277 | https://api.github.com/repos/simonw/datasette/issues/404 | MDEyOklzc3VlQ29tbWVudDU1MjI3NjI3Nw== | simonw 9599 | 2019-11-11T03:13:09Z | 2019-11-11T03:13:09Z | OWNER | 622 will drop 3.5 support. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Experiment: run Jinja in async mode 403499298 | |
552276422 | https://github.com/simonw/datasette/pull/501#issuecomment-552276422 | https://api.github.com/repos/simonw/datasette/issues/501 | MDEyOklzc3VlQ29tbWVudDU1MjI3NjQyMg== | simonw 9599 | 2019-11-11T03:13:52Z | 2019-11-11T03:13:52Z | OWNER | Dropping 3.5 compatibility will help here #622 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.8-dev using Travis 452901999 | |
552278039 | https://github.com/simonw/datasette/pull/501#issuecomment-552278039 | https://api.github.com/repos/simonw/datasette/issues/501 | MDEyOklzc3VlQ29tbWVudDU1MjI3ODAzOQ== | simonw 9599 | 2019-11-11T03:22:36Z | 2019-11-11T03:22:36Z | OWNER | Wow! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.8-dev using Travis 452901999 | |
552278216 | https://github.com/simonw/datasette/pull/501#issuecomment-552278216 | https://api.github.com/repos/simonw/datasette/issues/501 | MDEyOklzc3VlQ29tbWVudDU1MjI3ODIxNg== | simonw 9599 | 2019-11-11T03:23:29Z | 2019-11-11T03:23:29Z | OWNER | Closing this so I can do a clean single commit instead. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.8-dev using Travis 452901999 | |
552279522 | https://github.com/simonw/datasette/pull/623#issuecomment-552279522 | https://api.github.com/repos/simonw/datasette/issues/623 | MDEyOklzc3VlQ29tbWVudDU1MjI3OTUyMg== | simonw 9599 | 2019-11-11T03:31:17Z | 2019-11-11T03:31:17Z | OWNER |
I think all of those warnings are the same:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.8 in Travis 520718056 | |
552281217 | https://github.com/simonw/datasette/pull/623#issuecomment-552281217 | https://api.github.com/repos/simonw/datasette/issues/623 | MDEyOklzc3VlQ29tbWVudDU1MjI4MTIxNw== | simonw 9599 | 2019-11-11T03:40:59Z | 2019-11-11T03:40:59Z | OWNER | That did the trick - still some warnings now but they are all in dependencies: ``` =============================== warnings summary =============================== /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pint/compat/chainmap.py:16 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pint/compat/chainmap.py:16: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pint/util.py:21 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pint/util.py:21: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:17 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:17: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:63 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:63: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:72 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:72: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:77 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:77: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:82 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:82: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:91 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/base.py:91: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/utils.py:33: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/init.py:27 /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/aiofiles/threadpool/init.py:27: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
-- Docs: https://docs.pytest.org/en/latest/warnings.html ================== 379 passed, 54 warnings in 201.62 seconds =================== ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Test against Python 3.8 in Travis 520718056 | |
552327079 | https://github.com/simonw/datasette/pull/595#issuecomment-552327079 | https://api.github.com/repos/simonw/datasette/issues/595 | MDEyOklzc3VlQ29tbWVudDU1MjMyNzA3OQ== | tomchristie 647359 | 2019-11-11T07:34:27Z | 2019-11-11T07:34:27Z | NONE |
Whoop! 🥳 ✨ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 9