issue_comments
10,495 rows sorted by updated_at descending
This data as json, CSV (advanced)
user 131
- simonw 3,810
- russss 39
- codecov[bot] 30
- psychemedia 24
- abdusco 18
- chrismp 18
- aborruso 17
- carlmjohnson 13
- rixx 11
- terrycojones 9
- RhetTbull 9
- jacobian 8
- tomchristie 8
- stonebig 8
- bsilverm 8
- tsibley 7
- zeluspudding 7
- amjith 6
- simonwiles 6
- wragge 6
- rgieseke 6
- clausjuhl 6
- dazzag24 5
- SteadBytes 5
- jayvdb 4
- jaywgraves 4
- r4vi 4
- eyeseast 3
- obra 3
- janimo 3
- atomotic 3
- pkoppstein 3
- yschimke 3
- philroche 3
- macropin 3
- wsxiaoys 3
- jsfenfen 3
- mhalle 3
- xrotwang 3
- kevindkeogh 3
- garethr 2
- ftrain 2
- chrishas35 2
- bollwyvl 2
- ingenieroariel 2
- coleifer 2
- gavinband 2
- aviflax 2
- tholo 2
- yozlet 2
- cldellow 2
- gfrmin 2
- eads 2
- nathancahill 2
- betatim 2
- bsmithgall 2
- willingc 2
- raynae 2
- wulfmann 2
- zzeleznick 2
- tballison 2
- jsancho-gpl 2
- lagolucas 2
- dependabot-preview[bot] 2
- chekos 2
- ad-si 2
- null92 2
- tunguyenatwork 2
- LVerneyPEReN 2
- jarib 1
- gijs 1
- nkirsch 1
- tomdyson 1
- furilo 1
- adamwolf 1
- dmd 1
- Uninen 1
- carsonyl 1
- nryberg 1
- stefanocudini 1
- jefftriplett 1
- hpk42 1
- annapowellsmith 1
- Krazybug 1
- dvhthomas 1
- michaelmcandrew 1
- saulpw 1
- thadk 1
- frankier 1
- ipmb 1
- mikepqr 1
- 0x1997 1
- davidszotten 1
- kevboh 1
- eaubin 1
- snth 1
- joshmgrant 1
- bcongdon 1
- nickdirienzo 1
- adamjonas 1
- heussd 1
- Gagravarr 1
- progpow 1
- ltrgoddard 1
- costrouc 1
- ccorcos 1
- secretGeek 1
- fkuhn 1
- kwladyka 1
- phoenixjun 1
- JesperTreetop 1
- chris48s 1
- ChristopherWilks 1
- JBPressac 1
- Maltazar 1
- wuhland 1
- foscoj 1
- dvot197007 1
- rprimet 1
- metab0t 1
- spdkils 1
- coisnepe 1
- chmaynard 1
- LucasElArruda 1
- duarteocarmo 1
- mattiaborsoi 1
- abeyerpath 1
- b0b5h4rp13 1
- smithdc1 1
- jcmkk3 1
- thisismyfuckingusername 1
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
718317997 | https://github.com/simonw/datasette/issues/1050#issuecomment-718317997 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxODMxNzk5Nw== | thadk 283343 | 2020-10-29T02:24:50Z | 2020-10-29T02:29:24Z | NONE | Unsolicited feedback for an unreleased feature of the current unreleased GitHub version (I casually wanted to access a blob row) – the existing #1036 route doesn't support special characters in database or table names (e.g. Also I got this error/crash with my blob and wasn't able to get the file: https://gist.github.com/thadk/28ac32af0e88747ce9056c90b0b19d34 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
718243062 | https://github.com/simonw/datasette/pull/1060#issuecomment-718243062 | https://api.github.com/repos/simonw/datasette/issues/1060 | MDEyOklzc3VlQ29tbWVudDcxODI0MzA2Mg== | codecov[bot] 22429695 | 2020-10-28T22:23:33Z | 2020-10-28T22:23:33Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1060 +/-==========================================
+ Coverage 84.71% 91.13% +6.42% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/cli.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
New explicit versioning mechanism 731827081 | |
718170295 | https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718170295 | https://api.github.com/repos/simonw/sqlite-utils/issues/191 | MDEyOklzc3VlQ29tbWVudDcxODE3MDI5NQ== | simonw 9599 | 2020-10-28T19:50:16Z | 2020-10-28T19:50:16Z | OWNER | I think I made a mistake when I designed the initial decorator. I should have had it work like this:
To avoid breaking backwards compatibility I'll use the hack that detects the argument this time, but in the future I'll try to remember to always design decorators to be called like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: @db.register_function(deterministic=True) 731740458 | |
718168730 | https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718168730 | https://api.github.com/repos/simonw/sqlite-utils/issues/191 | MDEyOklzc3VlQ29tbWVudDcxODE2ODczMA== | simonw 9599 | 2020-10-28T19:47:20Z | 2020-10-28T19:47:20Z | OWNER | https://stackoverflow.com/a/3931903 looks useful:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: @db.register_function(deterministic=True) 731740458 | |
718078447 | https://github.com/simonw/datasette/pull/1059#issuecomment-718078447 | https://api.github.com/repos/simonw/datasette/issues/1059 | MDEyOklzc3VlQ29tbWVudDcxODA3ODQ0Nw== | simonw 9599 | 2020-10-28T17:07:59Z | 2020-10-28T17:08:14Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7 731445447 | ||
717938992 | https://github.com/simonw/datasette/pull/1059#issuecomment-717938992 | https://api.github.com/repos/simonw/datasette/issues/1059 | MDEyOklzc3VlQ29tbWVudDcxNzkzODk5Mg== | codecov[bot] 22429695 | 2020-10-28T13:38:46Z | 2020-10-28T13:38:46Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1059 +/-=======================================
Coverage 84.71% 84.71% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7 731445447 | |
717531272 | https://github.com/simonw/datasette/issues/1057#issuecomment-717531272 | https://api.github.com/repos/simonw/datasette/issues/1057 | MDEyOklzc3VlQ29tbWVudDcxNzUzMTI3Mg== | simonw 9599 | 2020-10-27T20:51:09Z | 2020-10-27T20:51:09Z | OWNER | That works! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
--cors should enable /fixtures.db CORS access 730797787 | |
717527606 | https://github.com/simonw/datasette/issues/1058#issuecomment-717527606 | https://api.github.com/repos/simonw/datasette/issues/1058 | MDEyOklzc3VlQ29tbWVudDcxNzUyNzYwNg== | simonw 9599 | 2020-10-27T20:44:06Z | 2020-10-27T20:44:06Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Database download should implement cascading permissions 730802994 | ||
717489501 | https://github.com/simonw/datasette/pull/1056#issuecomment-717489501 | https://api.github.com/repos/simonw/datasette/issues/1056 | MDEyOklzc3VlQ29tbWVudDcxNzQ4OTUwMQ== | codecov[bot] 22429695 | 2020-10-27T19:39:41Z | 2020-10-27T19:39:41Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1056 +/-=======================================
Coverage 84.70% 84.70% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Radical new colour scheme and base styles, courtesy of @natbat 730752399 | |
717361487 | https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717361487 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | MDEyOklzc3VlQ29tbWVudDcxNzM2MTQ4Nw== | simonw 9599 | 2020-10-27T16:24:04Z | 2020-10-27T16:24:04Z | OWNER | This is great, thank you very much. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow iterables other than Lists in m2m records 729818242 | |
717359145 | https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717359145 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | MDEyOklzc3VlQ29tbWVudDcxNzM1OTE0NQ== | adamwolf 35681 | 2020-10-27T16:20:32Z | 2020-10-27T16:20:32Z | CONTRIBUTOR | No problem. I added a test. Let me know if it looks sufficient or if you want me to to tweak something! If you don't mind, would you tag this PR as "hacktoberfest-accepted"? If you do mind, no problem and I'm sorry for asking :) My kiddos like the shirts. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow iterables other than Lists in m2m records 729818242 | |
717051707 | https://github.com/simonw/datasette/issues/1054#issuecomment-717051707 | https://api.github.com/repos/simonw/datasette/issues/1054 | MDEyOklzc3VlQ29tbWVudDcxNzA1MTcwNw== | simonw 9599 | 2020-10-27T07:41:21Z | 2020-10-27T07:41:21Z | OWNER | Essentially it's this problem: https://github.com/python-versioneer/python-versioneer/issues/140 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch from versioneer to concrete version in setup.py 730199464 | |
717050585 | https://github.com/simonw/datasette/issues/1054#issuecomment-717050585 | https://api.github.com/repos/simonw/datasette/issues/1054 | MDEyOklzc3VlQ29tbWVudDcxNzA1MDU4NQ== | simonw 9599 | 2020-10-27T07:38:50Z | 2020-10-27T07:38:50Z | OWNER | Maybe imitate how Django does this, e.g. https://github.com/django/django/commit/6b9b2af7352908d40ca4d31bdb1b80c013cab29a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch from versioneer to concrete version in setup.py 730199464 | |
716756103 | https://github.com/simonw/sqlite-utils/pull/189#issuecomment-716756103 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | MDEyOklzc3VlQ29tbWVudDcxNjc1NjEwMw== | simonw 9599 | 2020-10-26T18:56:19Z | 2020-10-26T18:56:19Z | OWNER | This is a great fix, thanks! If you add a unit test somewhere in here I'll merge the PR: https://github.com/simonw/sqlite-utils/blob/main/tests/test_m2m.py |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Allow iterables other than Lists in m2m records 729818242 | |
716681602 | https://github.com/simonw/datasette/issues/1051#issuecomment-716681602 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjY4MTYwMg== | simonw 9599 | 2020-10-26T16:51:58Z | 2020-10-26T16:51:58Z | OWNER | I still need to improve the current binary display on the query page though, where it outputs a Python |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716681167 | https://github.com/simonw/datasette/issues/1051#issuecomment-716681167 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjY4MTE2Nw== | simonw 9599 | 2020-10-26T16:51:15Z | 2020-10-26T16:51:15Z | OWNER | Crazy idea: generate a signed URL containing a base64 of the gzip of the binary content (to try and reduce size). No: this will blow through URL limits in various hosting providers and possibly even browsers. It could be made to work a little bit more reliably with some extra JavaScript that turns it into a download on the browser-side, but that would be hideously complicated. Also the signed bit doesn't prevent people from generating SQL queries that generate nasty binary blobs for download. I'm beginning to think that restricting this feature to just table view, not query view, is a better idea. Query view can still get at the binary using JSON and base64. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716305890 | https://github.com/simonw/datasette/issues/976#issuecomment-716305890 | https://api.github.com/repos/simonw/datasette/issues/976 | MDEyOklzc3VlQ29tbWVudDcxNjMwNTg5MA== | simonw 9599 | 2020-10-26T05:07:10Z | 2020-10-26T05:07:10Z | OWNER | I used the new https://github.com/simonw/datasette/blob/f5dbe61a4568c0915ec6be820095c2960cf0857c/datasette/utils/init.py#L996-L1008 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: -o could open to a more convenient location 708289783 | |
716265360 | https://github.com/simonw/datasette/issues/1052#issuecomment-716265360 | https://api.github.com/repos/simonw/datasette/issues/1052 | MDEyOklzc3VlQ29tbWVudDcxNjI2NTM2MA== | simonw 9599 | 2020-10-26T02:17:58Z | 2020-10-26T02:17:58Z | OWNER | The default z-index values for Leaflet are defined here: https://github.com/Leaflet/Leaflet/blob/b346bb8bf7bb80899baa1f4fc1536bae58e7e3e6/dist/leaflet.css#L81-L91 ```css .leaflet-pane { z-index: 400; } .leaflet-tile-pane { z-index: 200; } .leaflet-overlay-pane { z-index: 400; } .leaflet-shadow-pane { z-index: 500; } .leaflet-marker-pane { z-index: 600; } .leaflet-tooltip-pane { z-index: 650; } .leaflet-popup-pane { z-index: 700; } .leaflet-map-pane canvas { z-index: 100; }
.leaflet-map-pane svg { z-index: 200; }
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Column action menu overlapped by Leaflet maps 729183332 | |
716237524 | https://github.com/simonw/datasette/pull/1043#issuecomment-716237524 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNjIzNzUyNA== | bollwyvl 45380 | 2020-10-26T00:14:57Z | 2020-10-26T00:14:57Z | CONTRIBUTOR | Sorry, I was out of the loop this weekend. The missing sdists were in some the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
716204271 | https://github.com/simonw/datasette/issues/1051#issuecomment-716204271 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjIwNDI3MQ== | simonw 9599 | 2020-10-25T20:08:04Z | 2020-10-25T20:08:04Z | OWNER | This is bad though, because if I want to provide binary data in CSV as requested in #1034 I need some way of providing that data. Which suggests to me that the base64 option is the only one that can make sense for arbitrary SQL queries represented as CSV. Download links won't work. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716204090 | https://github.com/simonw/datasette/issues/1051#issuecomment-716204090 | https://api.github.com/repos/simonw/datasette/issues/1051 | MDEyOklzc3VlQ29tbWVudDcxNjIwNDA5MA== | simonw 9599 | 2020-10-25T20:06:42Z | 2020-10-25T20:06:42Z | OWNER | Providing a binary download link here is actually extremely difficult. The problem is that the SQL query itself represents data that can change from one moment to the next. It's no good showing a "Binary: 55 bytes" message that links to that same SQL query but with a So providing a download link risks being misleading. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better display of binary data on arbitrary query results page 729096595 | |
716174203 | https://github.com/simonw/datasette/issues/1050#issuecomment-716174203 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxNjE3NDIwMw== | simonw 9599 | 2020-10-25T16:27:39Z | 2020-10-25T16:53:27Z | OWNER | Idea: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
716175236 | https://github.com/simonw/datasette/issues/1050#issuecomment-716175236 | https://api.github.com/repos/simonw/datasette/issues/1050 | MDEyOklzc3VlQ29tbWVudDcxNjE3NTIzNg== | simonw 9599 | 2020-10-25T16:35:20Z | 2020-10-25T16:35:20Z | OWNER | This is clearly a better solution than the one I implemented in #1040 - I don't have to add a new route, I don't have to implement permission checks, it reuses mechanism. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Switch to .blob render extension for BLOB downloads 729057388 | |
716146238 | https://github.com/simonw/datasette/pull/1049#issuecomment-716146238 | https://api.github.com/repos/simonw/datasette/issues/1049 | MDEyOklzc3VlQ29tbWVudDcxNjE0NjIzOA== | codecov[bot] 22429695 | 2020-10-25T13:13:32Z | 2020-10-25T13:13:32Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1049 +/-=======================================
Coverage 84.72% 84.72% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add template block prior to extra URL loaders 729017519 | |
716123598 | https://github.com/simonw/datasette/issues/838#issuecomment-716123598 | https://api.github.com/repos/simonw/datasette/issues/838 | MDEyOklzc3VlQ29tbWVudDcxNjEyMzU5OA== | psychemedia 82988 | 2020-10-25T10:20:12Z | 2020-10-25T10:53:24Z | CONTRIBUTOR | I'm trying to run something behind a MyBinder proxy, but seem to have something set up incorrectly and not sure what the fix is? I'm starting datasette with jupyter-server-proxy setup: ``` init.pydef setup_nbsearch():
``` where the ``` init.pyfrom datasette import hookimpl @hookimpl def extra_css_urls(database, table, columns, view_name, datasette): return [ "/-/static-plugins/nbsearch/prism.css", "/-/static-plugins/nbsearch/nbsearch.css", ] ``` but these seem to also need a base_url prefix set somehow? Currently, the generated HTML loads properly but internal links are incorrect; eg they take the form The main css is loaded correctly: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Incorrect URLs when served behind a proxy with base_url set 637395097 | |
716078777 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078777 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODc3Nw== | simonw 9599 | 2020-10-25T01:25:11Z | 2020-10-25T01:25:11Z | OWNER | SQLite actually has APIs that could help here: https://www.sqlite.org/c3ref/column_database_name.html - for any given SQL query they identify the origin/table/column that is the source of each resulting column. Those aren't exposed in the Python |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078605 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078605 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODYwNQ== | simonw 9599 | 2020-10-25T01:22:22Z | 2020-10-25T01:22:22Z | OWNER | For arbitrary CSV the only solution I can think of is to embed the base64 value. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078512 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078512 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODUxMg== | simonw 9599 | 2020-10-25T01:21:11Z | 2020-10-25T01:21:11Z | OWNER | What should happen for CSV export of arbitrary SQL queries, where there's no obvious BLOB to link to? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716078420 | https://github.com/simonw/datasette/issues/1034#issuecomment-716078420 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3ODQyMA== | simonw 9599 | 2020-10-25T01:20:00Z | 2020-10-25T01:20:00Z | OWNER | That documentation: https://docs.datasette.io/en/latest/internals.html#absolute-url-request-path |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077541 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077541 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzU0MQ== | simonw 9599 | 2020-10-25T01:09:38Z | 2020-10-25T01:10:04Z | OWNER | I should turn |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077508 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077508 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzUwOA== | simonw 9599 | 2020-10-25T01:09:17Z | 2020-10-25T01:09:17Z | OWNER | Here's how those absolute |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716077436 | https://github.com/simonw/datasette/issues/1034#issuecomment-716077436 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxNjA3NzQzNg== | simonw 9599 | 2020-10-25T01:08:35Z | 2020-10-25T01:08:42Z | OWNER | This is actually a bit tricky to implement, for a few reasons:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
713277810 | https://github.com/simonw/datasette/issues/1034#issuecomment-713277810 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxMzI3NzgxMA== | simonw 9599 | 2020-10-21T03:40:50Z | 2020-10-25T01:01:23Z | OWNER | Blocked awaiting #1036 (update: now unblocked) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
716071507 | https://github.com/simonw/datasette/issues/1046#issuecomment-716071507 | https://api.github.com/repos/simonw/datasette/issues/1046 | MDEyOklzc3VlQ29tbWVudDcxNjA3MTUwNw== | simonw 9599 | 2020-10-25T00:06:47Z | 2020-10-25T00:06:47Z | OWNER | I used https://primer.style/octicons/download-16 instead. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Link to blob downloads in the right places 728895193 | |
713920562 | https://github.com/simonw/datasette/pull/1040#issuecomment-713920562 | https://api.github.com/repos/simonw/datasette/issues/1040 | MDEyOklzc3VlQ29tbWVudDcxMzkyMDU2Mg== | codecov[bot] 22429695 | 2020-10-21T22:44:12Z | 2020-10-24T23:08:14Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1040 +/-==========================================
+ Coverage 84.65% 84.76% +0.10% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/views/index.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
/db/table/-/blob/pk/column.blob download URL 726910999 | |
716066342 | https://github.com/simonw/datasette/issues/1046#issuecomment-716066342 | https://api.github.com/repos/simonw/datasette/issues/1046 | MDEyOklzc3VlQ29tbWVudDcxNjA2NjM0Mg== | simonw 9599 | 2020-10-24T23:02:07Z | 2020-10-24T23:02:25Z | OWNER | A download icon would be nice for the links in the table display. I like this one https://primer.style/octicons/download-24
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Link to blob downloads in the right places 728895193 | |
716066000 | https://github.com/simonw/datasette/issues/1033#issuecomment-716066000 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNjA2NjAwMA== | psychemedia 82988 | 2020-10-24T22:58:33Z | 2020-10-24T22:58:33Z | CONTRIBUTOR | From the docs, I note:
What about the proxy case? Eg if I am using jupyter-server-proxy on a MyBinder or local Jupyter notebook server site,
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
716048564 | https://github.com/simonw/datasette/issues/1033#issuecomment-716048564 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNjA0ODU2NA== | simonw 9599 | 2020-10-24T20:08:31Z | 2020-10-24T20:08:31Z | OWNER | Documentation here: https://docs.datasette.io/en/latest/internals.html#datasette-urls |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
716048199 | https://github.com/simonw/datasette/issues/575#issuecomment-716048199 | https://api.github.com/repos/simonw/datasette/issues/575 | MDEyOklzc3VlQ29tbWVudDcxNjA0ODE5OQ== | simonw 9599 | 2020-10-24T20:05:44Z | 2020-10-24T20:05:44Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin documentation should cover how to bundle static/templates in setup.py 497162288 | ||
715643763 | https://github.com/simonw/datasette/issues/1042#issuecomment-715643763 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTY0Mzc2Mw== | simonw 9599 | 2020-10-24T00:34:31Z | 2020-10-24T00:34:52Z | OWNER | I'm going to rename that to template variable from |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715643646 | https://github.com/simonw/datasette/issues/1042#issuecomment-715643646 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTY0MzY0Ng== | simonw 9599 | 2020-10-24T00:33:46Z | 2020-10-24T00:33:46Z | OWNER | I'd like to do this all in the This code is the problem: https://github.com/simonw/datasette/blob/d3e9b0aecb6f8e9b2befd9c654ccb7ce852db3e7/datasette/views/base.py#L114-L133 I think I'll fix this by moving the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715641183 | https://github.com/simonw/datasette/issues/1045#issuecomment-715641183 | https://api.github.com/repos/simonw/datasette/issues/1045 | MDEyOklzc3VlQ29tbWVudDcxNTY0MTE4Mw== | simonw 9599 | 2020-10-24T00:19:29Z | 2020-10-24T00:19:29Z | OWNER | It turns out it already does that: But the documentation doesn't reflect that:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Document that datasette.render_template(template, ...) also accepts a list of templates 728600048 | |
715618333 | https://github.com/simonw/datasette/issues/1042#issuecomment-715618333 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxODMzMw== | simonw 9599 | 2020-10-23T22:33:24Z | 2020-10-23T22:33:24Z | OWNER | It wouldn't be a disaster if template-loading plugins were unable to hook into the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715618077 | https://github.com/simonw/datasette/issues/1042#issuecomment-715618077 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxODA3Nw== | simonw 9599 | 2020-10-23T22:32:24Z | 2020-10-23T22:32:24Z | OWNER | Another option: the first version of the plugin hook could accept only the template filename. Subsequent releases could add more arguments, since Pluggy allows new arguments to be added without breaking backwards compatibility. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715617830 | https://github.com/simonw/datasette/issues/1042#issuecomment-715617830 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNzgzMA== | simonw 9599 | 2020-10-23T22:31:26Z | 2020-10-23T22:31:26Z | OWNER | So maybe this should be a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715617405 | https://github.com/simonw/datasette/issues/1042#issuecomment-715617405 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNzQwNQ== | simonw 9599 | 2020-10-23T22:29:53Z | 2020-10-23T22:29:53Z | OWNER | Also consider that For that to work with the new plugin hook, custom template providing plugins will need a way to provide a list of templates that they know about. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715616757 | https://github.com/simonw/datasette/issues/1042#issuecomment-715616757 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNjc1Nw== | simonw 9599 | 2020-10-23T22:27:28Z | 2020-10-23T22:27:28Z | OWNER | Almost all of the core template loading happens in the The one exception is the 404 handling code here: https://github.com/simonw/datasette/blob/976e5f74aae1fa0d406df6691dc8b5feeebe8788/datasette/app.py#L1034-L1042 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715614971 | https://github.com/simonw/datasette/issues/1042#issuecomment-715614971 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTYxNDk3MQ== | simonw 9599 | 2020-10-23T22:20:14Z | 2020-10-23T22:23:51Z | OWNER | Alternative plugin hook idea:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715587715 | https://github.com/simonw/datasette/pull/1040#issuecomment-715587715 | https://api.github.com/repos/simonw/datasette/issues/1040 | MDEyOklzc3VlQ29tbWVudDcxNTU4NzcxNQ== | simonw 9599 | 2020-10-23T21:01:07Z | 2020-10-23T21:03:10Z | OWNER | A download icon would be nice for the links in the table display. I like this one https://primer.style/octicons/download-24 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
/db/table/-/blob/pk/column.blob download URL 726910999 | |
715586711 | https://github.com/simonw/datasette/pull/1043#issuecomment-715586711 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNTU4NjcxMQ== | simonw 9599 | 2020-10-23T20:58:26Z | 2020-10-23T20:58:26Z | OWNER | I misunderstood - |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
715585140 | https://github.com/simonw/datasette/pull/1043#issuecomment-715585140 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNTU4NTE0MA== | simonw 9599 | 2020-10-23T20:54:29Z | 2020-10-23T20:54:29Z | OWNER | Thanks. I'll push a source release of |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
715584579 | https://github.com/simonw/datasette/pull/1044#issuecomment-715584579 | https://api.github.com/repos/simonw/datasette/issues/1044 | MDEyOklzc3VlQ29tbWVudDcxNTU4NDU3OQ== | simonw 9599 | 2020-10-23T20:53:01Z | 2020-10-23T20:53:01Z | OWNER | Thanks for this! |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add minimum supported python 727916744 | |
715556545 | https://github.com/simonw/datasette/issues/745#issuecomment-715556545 | https://api.github.com/repos/simonw/datasette/issues/745 | MDEyOklzc3VlQ29tbWVudDcxNTU1NjU0NQ== | simonw 9599 | 2020-10-23T19:47:10Z | 2020-10-23T19:47:10Z | OWNER | Dupe of #647 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Extract the hash-URL mechanism out into a plugin 608613033 | |
715497419 | https://github.com/simonw/datasette/issues/1042#issuecomment-715497419 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5NzQxOQ== | simonw 9599 | 2020-10-23T18:12:40Z | 2020-10-23T18:12:40Z | OWNER | Maybe the template loader can optionally return some extra context to pass to the template. That could be used to solve the templates considered comment. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715496859 | https://github.com/simonw/datasette/issues/1042#issuecomment-715496859 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5Njg1OQ== | simonw 9599 | 2020-10-23T18:11:27Z | 2020-10-23T18:11:27Z | OWNER | When loading a template the filename is required, but you can optionally also send a set of extra arguments which the template loader can take into consideration. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
715490532 | https://github.com/simonw/datasette/issues/1042#issuecomment-715490532 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNTQ5MDUzMg== | simonw 9599 | 2020-10-23T17:57:34Z | 2020-10-23T17:57:34Z | OWNER | A better version of this hook would be passed the database, table and query name depending on what was being rendered. This would require some re-thinking of how core templates are loaded, especially since I would want the templates considered comment to continue working. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714916127 | https://github.com/simonw/datasette/pull/1044#issuecomment-714916127 | https://api.github.com/repos/simonw/datasette/issues/1044 | MDEyOklzc3VlQ29tbWVudDcxNDkxNjEyNw== | codecov[bot] 22429695 | 2020-10-23T05:12:52Z | 2020-10-23T05:12:52Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1044 +/-=======================================
Coverage 84.65% 84.65% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add minimum supported python 727916744 | |
714915025 | https://github.com/simonw/datasette/pull/1043#issuecomment-714915025 | https://api.github.com/repos/simonw/datasette/issues/1043 | MDEyOklzc3VlQ29tbWVudDcxNDkxNTAyNQ== | codecov[bot] 22429695 | 2020-10-23T05:09:09Z | 2020-10-23T05:09:09Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1043 +/-=======================================
Coverage 84.65% 84.65% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Include LICENSE in sdist 727915394 | |
714908859 | https://github.com/simonw/datasette/issues/1012#issuecomment-714908859 | https://api.github.com/repos/simonw/datasette/issues/1012 | MDEyOklzc3VlQ29tbWVudDcxNDkwODg1OQ== | bollwyvl 45380 | 2020-10-23T04:49:20Z | 2020-10-23T04:49:20Z | CONTRIBUTOR | Good luck on 1.0! It may also be worth lobbying for a I was surprised to see the PR for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
For 1.0 update trove classifier in setup.py 718540751 | |
714868867 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868867 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODg2Nw== | simonw 9599 | 2020-10-23T02:31:17Z | 2020-10-23T02:31:17Z | OWNER | I'll build this in conjunction with a plugin that supports editing templates stored in SQLite. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714868624 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868624 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODYyNA== | simonw 9599 | 2020-10-23T02:30:27Z | 2020-10-23T02:30:37Z | OWNER | Maybe |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | |
714868207 | https://github.com/simonw/datasette/issues/1042#issuecomment-714868207 | https://api.github.com/repos/simonw/datasette/issues/1042 | MDEyOklzc3VlQ29tbWVudDcxNDg2ODIwNw== | simonw 9599 | 2020-10-23T02:29:12Z | 2020-10-23T02:29:12Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Plugin hook for loading templates 727802081 | ||
714758139 | https://github.com/simonw/sqlite-utils/issues/173#issuecomment-714758139 | https://api.github.com/repos/simonw/sqlite-utils/issues/173 | MDEyOklzc3VlQ29tbWVudDcxNDc1ODEzOQ== | simonw 9599 | 2020-10-22T20:57:56Z | 2020-10-22T20:57:56Z | OWNER | I could use Here's how to iterate through a list of objects being read from a file:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Progress bar for sqlite-utils insert 707478649 | |
714683801 | https://github.com/simonw/datasette/issues/1041#issuecomment-714683801 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ== | simonw 9599 | 2020-10-22T18:37:47Z | 2020-10-22T18:37:47Z | OWNER | I think I'll do this by looking for URLs that start with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714682825 | https://github.com/simonw/datasette/issues/1041#issuecomment-714682825 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ== | simonw 9599 | 2020-10-22T18:36:10Z | 2020-10-22T18:36:10Z | OWNER | I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714682288 | https://github.com/simonw/datasette/issues/1041#issuecomment-714682288 | https://api.github.com/repos/simonw/datasette/issues/1041 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA== | simonw 9599 | 2020-10-22T18:35:15Z | 2020-10-22T18:35:15Z | OWNER | @psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_js_urls and extra_css_urls should respect base_url setting 727627923 | |
714681365 | https://github.com/simonw/datasette/issues/1033#issuecomment-714681365 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNDY4MTM2NQ== | simonw 9599 | 2020-10-22T18:33:48Z | 2020-10-22T18:33:48Z | OWNER | That's a good question - I hadn't considered that. I'm going to open a new issue to have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
714657366 | https://github.com/simonw/datasette/issues/1033#issuecomment-714657366 | https://api.github.com/repos/simonw/datasette/issues/1033 | MDEyOklzc3VlQ29tbWVudDcxNDY1NzM2Ng== | psychemedia 82988 | 2020-10-22T17:51:29Z | 2020-10-22T17:51:29Z | CONTRIBUTOR | How does |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.urls.static_plugins(...) method 725099777 | |
714289680 | https://github.com/simonw/datasette/pull/1031#issuecomment-714289680 | https://api.github.com/repos/simonw/datasette/issues/1031 | MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA== | frankier 299380 | 2020-10-22T07:23:52Z | 2020-10-22T07:23:52Z | NONE | The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation. The reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fallback to databases in inspect-data.json when no -i options are passed 724369025 | |
714219725 | https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714219725 | https://api.github.com/repos/simonw/sqlite-utils/issues/171 | MDEyOklzc3VlQ29tbWVudDcxNDIxOTcyNQ== | mhalle 649467 | 2020-10-22T04:38:35Z | 2020-10-22T04:38:35Z | NONE | Thanks. As I said, I think the result (being able to query tree structures like ancestors and descendants) is more important than the implementation, and I agree that this particular sqlite extension is too obscure. Just providing an sqlite utility to build or rebuild a transitive closure table might be more generically useful. I find that hierarchical data shows up pretty frequently in some data science problems. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: transitive closure tables for tree structures 707407567 | |
714208848 | https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714208848 | https://api.github.com/repos/simonw/sqlite-utils/issues/171 | MDEyOklzc3VlQ29tbWVudDcxNDIwODg0OA== | simonw 9599 | 2020-10-22T04:07:14Z | 2020-10-22T04:07:14Z | OWNER | I made the It's a bit too obscure for me to want to add direct Python library support relating to that extension though. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Idea: transitive closure tables for tree structures 707407567 | |
714206875 | https://github.com/simonw/datasette/pull/1031#issuecomment-714206875 | https://api.github.com/repos/simonw/datasette/issues/1031 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjg3NQ== | simonw 9599 | 2020-10-22T04:01:19Z | 2020-10-22T04:01:19Z | OWNER | I don't fully understand the bug you're fixing here. Could you provide a bit more explanation? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fallback to databases in inspect-data.json when no -i options are passed 724369025 | |
714206533 | https://github.com/simonw/datasette/pull/1040#issuecomment-714206533 | https://api.github.com/repos/simonw/datasette/issues/1040 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjUzMw== | simonw 9599 | 2020-10-22T04:00:25Z | 2020-10-22T04:00:25Z | OWNER | I've decided not to offer a configuration option to turn this off. I'll reconsider if someone asks for it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
/db/table/-/blob/pk/column.blob download URL 726910999 | |
714205783 | https://github.com/simonw/datasette/issues/998#issuecomment-714205783 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDIwNTc4Mw== | simonw 9599 | 2020-10-22T03:58:13Z | 2020-10-22T03:58:13Z | OWNER | This is now live here: https://global-power-plants.datasettes.com/global-power-plants/global-power-plants |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714117534 | https://github.com/simonw/datasette/issues/998#issuecomment-714117534 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDExNzUzNA== | simonw 9599 | 2020-10-22T01:12:06Z | 2020-10-22T01:12:06Z | OWNER | Demo: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714092002 | https://github.com/simonw/datasette/issues/998#issuecomment-714092002 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDA5MjAwMg== | simonw 9599 | 2020-10-22T00:55:10Z | 2020-10-22T00:55:10Z | OWNER | This isn't blocked on #987 - it just means that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
714090965 | https://github.com/simonw/datasette/issues/998#issuecomment-714090965 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxNDA5MDk2NQ== | simonw 9599 | 2020-10-22T00:54:30Z | 2020-10-22T00:54:30Z | OWNER | Easiest fix for the column action menu positioning - hide them when the user scrolls the containing div:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
713920461 | https://github.com/simonw/datasette/pull/1038#issuecomment-713920461 | https://api.github.com/repos/simonw/datasette/issues/1038 | MDEyOklzc3VlQ29tbWVudDcxMzkyMDQ2MQ== | simonw 9599 | 2020-10-21T22:43:51Z | 2020-10-21T22:43:51Z | OWNER | Thanks for spotting this! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
DOC: Fix syntax error 726154220 | |
713899530 | https://github.com/simonw/datasette/issues/1036#issuecomment-713899530 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzg5OTUzMA== | simonw 9599 | 2020-10-21T21:55:00Z | 2020-10-21T21:55:00Z | OWNER | This code needs these permission checks: https://github.com/simonw/datasette/blob/bf82b3d6a605c9ddadd5fb739249dfe6defaf635/datasette/views/table.py#L911-L913 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713821656 | https://github.com/simonw/datasette/issues/1036#issuecomment-713821656 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgyMTY1Ng== | simonw 9599 | 2020-10-21T19:22:45Z | 2020-10-21T19:41:48Z | OWNER | So for https://latest.datasette.io/fixtures/binary_data the BLOB download URLs would be:
With these headers:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713830842 | https://github.com/simonw/datasette/issues/1036#issuecomment-713830842 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgzMDg0Mg== | simonw 9599 | 2020-10-21T19:41:20Z | 2020-10-21T19:41:20Z | OWNER | Another useful demo database: https://datasette-render-images-demo.datasette.io/favicons/favicons - see https://datasette-render-images-demo.datasette.io/favicons/favicons.csv |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713829629 | https://github.com/simonw/datasette/issues/1036#issuecomment-713829629 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgyOTYyOQ== | simonw 9599 | 2020-10-21T19:38:43Z | 2020-10-21T19:38:43Z | OWNER | Should this work just for BLOB columns, or should it work for other columns too? For the moment I'm going to restrict it to BLOBs, since data from other columns is available through the UI whereas BLOB columns are not. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713818817 | https://github.com/simonw/datasette/issues/1036#issuecomment-713818817 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgxODgxNw== | simonw 9599 | 2020-10-21T19:17:01Z | 2020-10-21T19:17:01Z | OWNER | Actually I like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713818178 | https://github.com/simonw/datasette/issues/1036#issuecomment-713818178 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzgxODE3OA== | simonw 9599 | 2020-10-21T19:15:38Z | 2020-10-21T19:16:34Z | OWNER | What should the suggested filename be? I think something that includes the table name, primary key and the name of the column would work. How about a file extension? I guess |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713754844 | https://github.com/simonw/datasette/issues/1039#issuecomment-713754844 | https://api.github.com/repos/simonw/datasette/issues/1039 | MDEyOklzc3VlQ29tbWVudDcxMzc1NDg0NA== | simonw 9599 | 2020-10-21T17:58:27Z | 2020-10-21T17:58:27Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add an animation to the column actions menu 726687572 | ||
713320666 | https://github.com/simonw/datasette/pull/1038#issuecomment-713320666 | https://api.github.com/repos/simonw/datasette/issues/1038 | MDEyOklzc3VlQ29tbWVudDcxMzMyMDY2Ng== | codecov[bot] 22429695 | 2020-10-21T05:50:38Z | 2020-10-21T05:50:38Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ main #1038 +/-=======================================
Coverage 84.65% 84.65% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
DOC: Fix syntax error 726154220 | |
713278349 | https://github.com/simonw/datasette/issues/1036#issuecomment-713278349 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzI3ODM0OQ== | simonw 9599 | 2020-10-21T03:42:29Z | 2020-10-21T03:42:29Z | OWNER | Possible URL for this: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713269155 | https://github.com/simonw/datasette/issues/998#issuecomment-713269155 | https://api.github.com/repos/simonw/datasette/issues/998 | MDEyOklzc3VlQ29tbWVudDcxMzI2OTE1NQ== | simonw 9599 | 2020-10-21T03:17:07Z | 2020-10-21T03:17:07Z | OWNER | This may require updates to the column action menu JavaScript too, since it was not built with scrolling sideways in mind. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Wide tables should scroll horizontally within the page 717699884 | |
713268905 | https://github.com/simonw/datasette/issues/1037#issuecomment-713268905 | https://api.github.com/repos/simonw/datasette/issues/1037 | MDEyOklzc3VlQ29tbWVudDcxMzI2ODkwNQ== | simonw 9599 | 2020-10-21T03:16:36Z | 2020-10-21T03:16:36Z | OWNER | Dupe of #998. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add horizontal scrollbar to tables 726094754 | |
713268498 | https://github.com/simonw/datasette/issues/1037#issuecomment-713268498 | https://api.github.com/repos/simonw/datasette/issues/1037 | MDEyOklzc3VlQ29tbWVudDcxMzI2ODQ5OA== | simonw 9599 | 2020-10-21T03:15:44Z | 2020-10-21T03:15:44Z | OWNER | This may require updates to the column action menu JavaScript too, since it was not built with scrolling sideways in mind. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add horizontal scrollbar to tables 726094754 | |
713267989 | https://github.com/simonw/datasette/issues/1037#issuecomment-713267989 | https://api.github.com/repos/simonw/datasette/issues/1037 | MDEyOklzc3VlQ29tbWVudDcxMzI2Nzk4OQ== | simonw 9599 | 2020-10-21T03:14:34Z | 2020-10-21T03:14:34Z | OWNER | This is particularly relevant to the That plugin also makes this harder to build, because the plugin inserts the map as the direct predecessor of the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add horizontal scrollbar to tables 726094754 | |
713226726 | https://github.com/simonw/datasette/issues/1036#issuecomment-713226726 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzIyNjcyNg== | simonw 9599 | 2020-10-21T01:04:25Z | 2020-10-21T01:04:25Z | OWNER | Extra security idea: a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713208667 | https://github.com/simonw/datasette/issues/262#issuecomment-713208667 | https://api.github.com/repos/simonw/datasette/issues/262 | MDEyOklzc3VlQ29tbWVudDcxMzIwODY2Nw== | simonw 9599 | 2020-10-21T00:03:18Z | 2020-10-21T00:03:18Z | OWNER | I think I should prioritize the facets component of this, since that could have significant performance wins while also supporting |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add ?_extra= mechanism for requesting extra properties in JSON 323658641 | |
713200782 | https://github.com/simonw/datasette/issues/262#issuecomment-713200782 | https://api.github.com/repos/simonw/datasette/issues/262 | MDEyOklzc3VlQ29tbWVudDcxMzIwMDc4Mg== | simonw 9599 | 2020-10-20T23:41:30Z | 2020-10-20T23:41:30Z | OWNER | This is now blocking https://github.com/simonw/datasette-graphql/issues/61 because that issue needs a way to turn off suggested facets when retrieving the results of a table query. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add ?_extra= mechanism for requesting extra properties in JSON 323658641 | |
713191819 | https://github.com/simonw/datasette/issues/1034#issuecomment-713191819 | https://api.github.com/repos/simonw/datasette/issues/1034 | MDEyOklzc3VlQ29tbWVudDcxMzE5MTgxOQ== | simonw 9599 | 2020-10-20T23:12:58Z | 2020-10-20T23:12:58Z | OWNER | Enzo has a great solution here: https://twitter.com/enzo_mdd/status/1318685442976436226
In #1036 I'm planning on adding a way for users to access BLOB data. I can include that URL in the CSV output. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Better way of representing binary data in .csv output 725184645 | |
713186189 | https://github.com/simonw/datasette/issues/1036#issuecomment-713186189 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzE4NjE4OQ== | simonw 9599 | 2020-10-20T22:56:33Z | 2020-10-20T22:56:33Z | OWNER | I think this plus the binary-CSV stuff in #1034 will justify a dedicated section of the documentation to talk about how Datasette handles binary BLOB columns. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713185871 | https://github.com/simonw/datasette/issues/1036#issuecomment-713185871 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzE4NTg3MQ== | simonw 9599 | 2020-10-20T22:55:36Z | 2020-10-20T22:55:36Z | OWNER | I can also use a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713185173 | https://github.com/simonw/datasette/issues/1036#issuecomment-713185173 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzE4NTE3Mw== | simonw 9599 | 2020-10-20T22:53:41Z | 2020-10-20T22:53:41Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713184374 | https://github.com/simonw/datasette/issues/1036#issuecomment-713184374 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzE4NDM3NA== | simonw 9599 | 2020-10-20T22:51:22Z | 2020-10-20T22:51:22Z | OWNER | From https://hackerone.com/reports/126197:
So you do have to be careful not to open accidental XSS holes with From that thread it looks like the solution is to add a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 | |
713183306 | https://github.com/simonw/datasette/issues/1036#issuecomment-713183306 | https://api.github.com/repos/simonw/datasette/issues/1036 | MDEyOklzc3VlQ29tbWVudDcxMzE4MzMwNg== | simonw 9599 | 2020-10-20T22:48:10Z | 2020-10-20T22:48:10Z | OWNER | Twitter thread: https://twitter.com/dancow/status/1318681053347840005 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Make it possible to download BLOB data from the Datasette UI 725996507 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue >1000