id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,pull_request,body,repo,type,active_lock_reason,performed_via_github_app,reactions,draft,state_reason
1822813627,I_kwDOBm6k_c5spe27,2108,some (many?) SQL syntax errors are not throwing errors with a .csv endpoint,536941,open,0,,,0,2023-07-26T16:57:45Z,2023-07-26T16:58:07Z,,CONTRIBUTOR,,"here's a CTE query that should always fail with a syntax error:

```sql
with foo as (nonsense)
select
  *
from
  foo;
```

when we make this query against the default endpoint, we do indeed get a 400 status code the problem is returned to the user: https://global-power-plants.datasettes.com/global-power-plants?sql=with+foo+as+%28nonsense%29+select+*+from+foo%3B

but, if we use the csv endpoint, we get a 200 status code and no indication of a problem: https://global-power-plants.datasettes.com/global-power-plants.csv?sql=with+foo+as+%28nonsense%29+select+*+from+foo%3B

same with this bad sql

```sql
select
  a,
from
  foo;
```

https://global-power-plants.datasettes.com/global-power-plants?sql=select%0D%0A++a%2C%0D%0Afrom%0D%0A++foo%3B

vs 

https://global-power-plants.datasettes.com/global-power-plants.csv?sql=select%0D%0A++a%2C%0D%0Afrom%0D%0A++foo%3B

but, datasette catches this bad sql at both endpoints:

```sql
slect
  a
from
  foo;
```

https://global-power-plants.datasettes.com/global-power-plants?sql=slect%0D%0A++a%0D%0Afrom%0D%0A++foo%3B
https://global-power-plants.datasettes.com/global-power-plants.csv?sql=slect%0D%0A++a%0D%0Afrom%0D%0A++foo%3B


",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2108/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1820346348,PR_kwDOBm6k_c5WVYor,2107,Bump sphinx from 6.1.3 to 7.1.0,49699333,closed,0,,,2,2023-07-25T13:28:30Z,2023-07-28T13:23:19Z,2023-07-28T13:23:17Z,CONTRIBUTOR,simonw/datasette/pulls/2107,"Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 7.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>Sphinx 7.1.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.0rc1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 7.1.0 (released Jul 24, 2023)</h1>
<h2>Incompatible changes</h2>
<ul>
<li>
<p>Releases are no longer signed, given the <code>change in PyPI policy</code>_.</p>
<p>.. _change in PyPI policy: <a href=""https://blog.pypi.org/posts/2023-05-23-removing-pgp/"">https://blog.pypi.org/posts/2023-05-23-removing-pgp/</a></p>
</li>
</ul>
<h2>Deprecated</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11412"">#11412</a>: Emit warnings on using a deprecated Python-specific index entry type
(namely, <code>module</code>, <code>keyword</code>, <code>operator</code>, <code>object</code>, <code>exception</code>,
<code>statement</code>, and <code>builtin</code>) in the :rst:dir:<code>index</code> directive, and
set the removal version to Sphinx 9. Patch by Adam Turner.</li>
</ul>
<h2>Features added</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11415"">#11415</a>: Add a checksum to JavaScript and CSS asset URIs included within
generated HTML, using the CRC32 algorithm.</li>
<li>:meth:<code>~sphinx.application.Sphinx.require_sphinx</code> now allows the version
requirement to be specified as <code>(major, minor)</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11011"">#11011</a>: Allow configuring a line-length limit for object signatures, via
:confval:<code>maximum_signature_line_length</code> and the domain-specific variants.
If the length of the signature (in characters) is greater than the configured
limit, each parameter in the signature will be split to its own logical line.
This behaviour may also be controlled by options on object description
directives, for example :rst:dir:<code>py:function:single-line-parameter-list</code>.
Patch by Thomas Louf, Adam Turner, and Jean-François B.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/10983"">#10983</a>: Support for multiline copyright statements in the footer block.
Patch by Stefanie Molin</li>
<li><code>sphinx.util.display.status_iterator</code> now clears the current line
with ANSI control codes, rather than overprinting with space characters.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11431"">#11431</a>: linkcheck: Treat SSL failures as broken links.
Patch by Bénédikt Tran</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11157"">#11157</a>: Keep the <code>translated</code> attribute on translated nodes.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11451"">#11451</a>: Improve the traceback displayed when using :option:<code>sphinx-build -T</code>
in parallel builds. Patch by Bénédikt Tran</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11324"">#11324</a>: linkcheck: Use session-basd HTTP requests.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11438"">#11438</a>: Add support for the :rst:dir:<code>py:class</code> and :rst:dir:<code>py:function</code>
directives for PEP 695 (generic classes and functions declarations) and
PEP 696 (default type parameters).  Multi-line support (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11011"">#11011</a>) is enabled
for type parameters list and can be locally controlled on object description
directives, e.g., :rst:dir:<code>py:function:single-line-type-parameter-list</code>.
Patch by Bénédikt Tran.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11484"">#11484</a>: linkcheck: Allow HTML anchors to be ignored on a per-URL basis
via :confval:<code>linkcheck_anchors_ignore_for_url</code> while</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/e560f6334aa87af07304415e6aeaf42d03d1c525""><code>e560f63</code></a> Bump to 7.1.0 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/066e0fabc60c55072b3f75876637a44fdcb51332""><code>066e0fa</code></a> Add translation progress information (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11509"">#11509</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/0882914d5c5057ad3cec280c0142cfe5f6965844""><code>0882914</code></a> Target PyPI in create-release.yml</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/21fbee5e83a3e9d34e589d06c66d928f3a67923c""><code>21fbee5</code></a> Fix OIDC token payload</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/1a403e4f9ad4d8d7a3e4c7c34f55d9a45ed600bd""><code>1a403e4</code></a> Add informational log messaging</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/258b0ea9fcdd05221ebead5e5c162a7ad37c4412""><code>258b0ea</code></a> Revert &quot;Switch to using <code>github.request</code>&quot;</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/f9c89e5d8431155caa7be57d923f96004a2dd4bd""><code>f9c89e5</code></a> Switch to using <code>github.request</code></li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/52c7f66ce172f723e8227896fe02165d288cb28f""><code>52c7f66</code></a> Use the correct token minting URL for TestPyPI</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/6079f28faa2a60d00f62b02786f23cd489019cdb""><code>6079f28</code></a> Install twine in PyPI publish workflow</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/3d43b9efdb49706cad6947f0c4d877d603781fe6""><code>3d43b9e</code></a> Fix github-script syntax in create-release.yml</li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v7.1.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=6.1.3&new-version=7.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2107.org.readthedocs.build/en/2107/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2107/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1816857442,I_kwDOBm6k_c5sSwti,2106,`datasette install -e` option,9599,closed,0,,,3,2023-07-22T18:33:42Z,2023-07-26T18:28:33Z,2023-07-22T18:42:54Z,OWNER,,"As seen in LLM and now in `sqlite-utils` too:
- https://github.com/simonw/sqlite-utils/issues/570

Useful for developing plugins, see tutorial at https://llm.datasette.io/en/stable/plugins/tutorial-model-plugin.html",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2106/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1811824307,I_kwDOBm6k_c5r_j6z,2105,When reverse proxying datasette with nginx an URL element gets erronously added,2235371,open,0,,,3,2023-07-19T12:16:53Z,2023-07-21T21:17:09Z,,NONE,,"I use this nginx config:
```
    location /datasette-llm {
      return 302 /datasette-llm/;
    }

    location /datasette-llm/ {
      proxy_set_header Upgrade           $http_upgrade;
      proxy_set_header Connection        ""Upgrade"";
      proxy_http_version 1.1;
      proxy_set_header X-Real-IP         $remote_addr;
      proxy_set_header X-Forwarded-For   $proxy_add_x_forwarded_for;
      proxy_set_header X-Forwarded-Proto https;
      proxy_set_header X-Forwarded-Host  $http_host;
      proxy_set_header Host              $host;
      proxy_max_temp_file_size           0;
      proxy_pass                         http://127.0.0.1:8001/datasette-llm/;
      proxy_redirect                     http:// https://;
      proxy_buffering off;
      proxy_request_buffering off;
      proxy_set_header Origin            '';
      client_max_body_size 0;
      auth_basic                         ""datasette-llm"";
      auth_basic_user_file               /etc/nginx/custom-userdb;
    }
```
Then I start datasette with this command:
```
datasette serve --setting base_url /datasette-llm/ $(llm logs path)
```
Everything else works right, except the links in ""This data as json, CSV"".
They get an extra URL element ""datasette-llm"" like this:

https://192.168.1.3:5432/datasette-llm/datasette-llm/logs.json?sql=select+*+from+_llm_migrations

https://192.168.1.3:5432/datasette-llm/datasette-llm/logs.csv?sql=select+*+from+_llm_migrations&_size=max

When I remove that extra ""datasette-llm"" from the URL, those links work too.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2105/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1808215339,I_kwDOBm6k_c5rxy0r,2104,Tables starting with an underscore should be treated as hidden,9599,open,0,,,2,2023-07-17T17:13:53Z,2023-07-18T22:41:37Z,,OWNER,,"Plugins can then take advantage of this pattern, for example:
- https://github.com/simonw/datasette-auth-tokens/pull/8",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2104/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1808116827,I_kwDOBm6k_c5rxaxb,2103,data attribute on Datasette tables exposing the primary key of the row,9599,open,0,,,0,2023-07-17T16:18:25Z,2023-07-17T16:18:25Z,,OWNER,,Maybe put it on the `<tr>` but probably better to go on the `td.type-pk`.,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2103/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1805076818,I_kwDOBm6k_c5rl0lS,2102,API tokens with view-table but not view-database/view-instance cannot access the table,9599,closed,0,9599,,20,2023-07-14T15:34:27Z,2023-08-29T16:32:36Z,2023-08-29T16:32:35Z,OWNER,,"> Spotted a problem while working on this: if you grant a token access to view table for a specific table but don't also grant view database and view instance permissions, that token is useless.
>
> This was a deliberate design decision in Datasette - it's documented on https://docs.datasette.io/en/1.0a2/authentication.html#access-permissions-in-metadata
>
>> If a user cannot access a specific database, they will not be able to access tables, views or queries within that database. If a user cannot access the instance they will not be able to access any of the databases, tables, views or queries.
>
> I'm now second-guessing if this was a good decision.

_Originally posted by @simonw in https://github.com/simonw/datasette-auth-tokens/issues/7#issuecomment-1636031702_
            ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2102/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1803264272,I_kwDOBm6k_c5re6EQ,2101,alter: true support for JSON write API,9599,open,0,,,1,2023-07-13T15:24:11Z,2023-07-13T15:24:18Z,,OWNER,,"Requested here: https://discord.com/channels/823971286308356157/823971286941302908/1129034187073134642

> The former datasette-insert plugin had an option `?alter=1` to auto-add new columns. Does the JSON write API also have this?",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2101/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1802613340,PR_kwDOBm6k_c5VZhfw,2100,Make primary key view accessible to render_cell hook,1563881,open,0,,,0,2023-07-13T09:30:36Z,2023-08-10T13:15:41Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2100,"

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2100.org.readthedocs.build/en/2100/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2100/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1798901709,PR_kwDOBm6k_c5VM2MK,2099,Bump black from 23.3.0 to 23.7.0,49699333,closed,0,,,0,2023-07-11T13:05:53Z,2023-07-21T21:19:25Z,2023-07-21T21:19:24Z,CONTRIBUTOR,simonw/datasette/pulls/2099,"Bumps [black](https://github.com/psf/black) from 23.3.0 to 23.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/releases"">black's releases</a>.</em></p>
<blockquote>
<h2>23.7.0</h2>
<h3>Highlights</h3>
<ul>
<li>Runtime support for Python 3.7 has been removed. Formatting 3.7 code will still be
supported until further notice (<a href=""https://redirect.github.com/psf/black/issues/3765"">#3765</a>)</li>
</ul>
<h3>Stable style</h3>
<ul>
<li>Fix a bug where an illegal trailing comma was added to return type annotations using
PEP 604 unions (<a href=""https://redirect.github.com/psf/black/issues/3735"">#3735</a>)</li>
<li>Fix several bugs and crashes where comments in stub files were removed or mishandled
under some circumstances (<a href=""https://redirect.github.com/psf/black/issues/3745"">#3745</a>)</li>
<li>Fix a crash with multi-line magic comments like <code>type: ignore</code> within parentheses
(<a href=""https://redirect.github.com/psf/black/issues/3740"">#3740</a>)</li>
<li>Fix error in AST validation when <em>Black</em> removes trailing whitespace in a type comment
(<a href=""https://redirect.github.com/psf/black/issues/3773"">#3773</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Implicitly concatenated strings used as function args are no longer wrapped inside
parentheses (<a href=""https://redirect.github.com/psf/black/issues/3640"">#3640</a>)</li>
<li>Remove blank lines between a class definition and its docstring (<a href=""https://redirect.github.com/psf/black/issues/3692"">#3692</a>)</li>
</ul>
<h3>Configuration</h3>
<ul>
<li>The <code>--workers</code> argument to <em>Black</em> can now be specified via the <code>BLACK_NUM_WORKERS</code>
environment variable (<a href=""https://redirect.github.com/psf/black/issues/3743"">#3743</a>)</li>
<li><code>.pytest_cache</code>, <code>.ruff_cache</code> and <code>.vscode</code> are now excluded by default (<a href=""https://redirect.github.com/psf/black/issues/3691"">#3691</a>)</li>
<li>Fix <em>Black</em> not honouring <code>pyproject.toml</code> settings when running <code>--stdin-filename</code>
and the <code>pyproject.toml</code> found isn't in the current working directory (<a href=""https://redirect.github.com/psf/black/issues/3719"">#3719</a>)</li>
<li><em>Black</em> will now error if <code>exclude</code> and <code>extend-exclude</code> have invalid data types in
<code>pyproject.toml</code>, instead of silently doing the wrong thing (<a href=""https://redirect.github.com/psf/black/issues/3764"">#3764</a>)</li>
</ul>
<h3>Packaging</h3>
<ul>
<li>Upgrade mypyc from 0.991 to 1.3 (<a href=""https://redirect.github.com/psf/black/issues/3697"">#3697</a>)</li>
<li>Remove patching of Click that mitigated errors on Python 3.6 with <code>LANG=C</code> (<a href=""https://redirect.github.com/psf/black/issues/3768"">#3768</a>)</li>
</ul>
<h3>Parser</h3>
<ul>
<li>Add support for the new PEP 695 syntax in Python 3.12 (<a href=""https://redirect.github.com/psf/black/issues/3703"">#3703</a>)</li>
</ul>
<h3>Performance</h3>
<ul>
<li>Speed up <em>Black</em> significantly when the cache is full (<a href=""https://redirect.github.com/psf/black/issues/3751"">#3751</a>)</li>
<li>Avoid importing <code>IPython</code> in a case where we wouldn't need it (<a href=""https://redirect.github.com/psf/black/issues/3748"">#3748</a>)</li>
</ul>
<h3>Output</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/blob/main/CHANGES.md"">black's changelog</a>.</em></p>
<blockquote>
<h2>23.7.0</h2>
<h3>Highlights</h3>
<ul>
<li>Runtime support for Python 3.7 has been removed. Formatting 3.7 code will still be
supported until further notice (<a href=""https://redirect.github.com/psf/black/issues/3765"">#3765</a>)</li>
</ul>
<h3>Stable style</h3>
<ul>
<li>Fix a bug where an illegal trailing comma was added to return type annotations using
PEP 604 unions (<a href=""https://redirect.github.com/psf/black/issues/3735"">#3735</a>)</li>
<li>Fix several bugs and crashes where comments in stub files were removed or mishandled
under some circumstances (<a href=""https://redirect.github.com/psf/black/issues/3745"">#3745</a>)</li>
<li>Fix a crash with multi-line magic comments like <code>type: ignore</code> within parentheses
(<a href=""https://redirect.github.com/psf/black/issues/3740"">#3740</a>)</li>
<li>Fix error in AST validation when <em>Black</em> removes trailing whitespace in a type comment
(<a href=""https://redirect.github.com/psf/black/issues/3773"">#3773</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Implicitly concatenated strings used as function args are no longer wrapped inside
parentheses (<a href=""https://redirect.github.com/psf/black/issues/3640"">#3640</a>)</li>
<li>Remove blank lines between a class definition and its docstring (<a href=""https://redirect.github.com/psf/black/issues/3692"">#3692</a>)</li>
</ul>
<h3>Configuration</h3>
<ul>
<li>The <code>--workers</code> argument to <em>Black</em> can now be specified via the <code>BLACK_NUM_WORKERS</code>
environment variable (<a href=""https://redirect.github.com/psf/black/issues/3743"">#3743</a>)</li>
<li><code>.pytest_cache</code>, <code>.ruff_cache</code> and <code>.vscode</code> are now excluded by default (<a href=""https://redirect.github.com/psf/black/issues/3691"">#3691</a>)</li>
<li>Fix <em>Black</em> not honouring <code>pyproject.toml</code> settings when running <code>--stdin-filename</code>
and the <code>pyproject.toml</code> found isn't in the current working directory (<a href=""https://redirect.github.com/psf/black/issues/3719"">#3719</a>)</li>
<li><em>Black</em> will now error if <code>exclude</code> and <code>extend-exclude</code> have invalid data types in
<code>pyproject.toml</code>, instead of silently doing the wrong thing (<a href=""https://redirect.github.com/psf/black/issues/3764"">#3764</a>)</li>
</ul>
<h3>Packaging</h3>
<ul>
<li>Upgrade mypyc from 0.991 to 1.3 (<a href=""https://redirect.github.com/psf/black/issues/3697"">#3697</a>)</li>
<li>Remove patching of Click that mitigated errors on Python 3.6 with <code>LANG=C</code> (<a href=""https://redirect.github.com/psf/black/issues/3768"">#3768</a>)</li>
</ul>
<h3>Parser</h3>
<ul>
<li>Add support for the new PEP 695 syntax in Python 3.12 (<a href=""https://redirect.github.com/psf/black/issues/3703"">#3703</a>)</li>
</ul>
<h3>Performance</h3>
<ul>
<li>Speed up <em>Black</em> significantly when the cache is full (<a href=""https://redirect.github.com/psf/black/issues/3751"">#3751</a>)</li>
<li>Avoid importing <code>IPython</code> in a case where we wouldn't need it (<a href=""https://redirect.github.com/psf/black/issues/3748"">#3748</a>)</li>
</ul>
<h3>Output</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/psf/black/commit/193ee766ca496871f93621d6b58d57a6564ff81b""><code>193ee76</code></a> Prepare release 23.7.0 (<a href=""https://redirect.github.com/psf/black/issues/3776"">#3776</a>)</li>
<li><a href=""https://github.com/psf/black/commit/38723bb7787d50f8751fad2eaa48b52c9e94c18d""><code>38723bb</code></a> Unpin pytest-xdist (<a href=""https://redirect.github.com/psf/black/issues/3772"">#3772</a>)</li>
<li><a href=""https://github.com/psf/black/commit/138769aa27d6bd86507a0cd98d9a5bf8f63a8e99""><code>138769a</code></a> Disable coverage on pypy tests (<a href=""https://redirect.github.com/psf/black/issues/3777"">#3777</a>)</li>
<li><a href=""https://github.com/psf/black/commit/ad3724b7ffc01d8152c97fe7f4dcf35220f21a8e""><code>ad3724b</code></a> Upgrade to latest mypy (<a href=""https://redirect.github.com/psf/black/issues/3775"">#3775</a>)</li>
<li><a href=""https://github.com/psf/black/commit/b8e2ec728cc09d0f00829a9cffcb54da3efa5760""><code>b8e2ec7</code></a> Fix crash on type comment with trailing space (<a href=""https://redirect.github.com/psf/black/issues/3773"">#3773</a>)</li>
<li><a href=""https://github.com/psf/black/commit/257d392217974a76231e306133288748c7b70786""><code>257d392</code></a> Fix removed comments in stub files (<a href=""https://redirect.github.com/psf/black/issues/3745"">#3745</a>)</li>
<li><a href=""https://github.com/psf/black/commit/2593af2c5d211b58e28f7c1472f1f67e6783216a""><code>2593af2</code></a> Improve performance by skipping unnecessary normalisation (<a href=""https://redirect.github.com/psf/black/issues/3751"">#3751</a>)</li>
<li><a href=""https://github.com/psf/black/commit/f3b50e466969f9142393ec32a4b2a383ffbe5f23""><code>f3b50e4</code></a> Add CITATION.cff file (<a href=""https://redirect.github.com/psf/black/issues/3723"">#3723</a>)</li>
<li><a href=""https://github.com/psf/black/commit/0b4d7d55f78913be9e0a3738681ef3aafd5d9a5a""><code>0b4d7d5</code></a> Run pyupgrade on blib2to3 and src (<a href=""https://redirect.github.com/psf/black/issues/3771"">#3771</a>)</li>
<li><a href=""https://github.com/psf/black/commit/114e8357e65384e17baaa3c31aa528371e15679b""><code>114e835</code></a> Remove click patch (<a href=""https://redirect.github.com/psf/black/issues/3768"">#3768</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/psf/black/compare/23.3.0...23.7.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=black&package-manager=pip&previous-version=23.3.0&new-version=23.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2099.org.readthedocs.build/en/2099/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2099/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1796830110,PR_kwDOBm6k_c5VFw3j,2098,Bump blacken-docs from 1.14.0 to 1.15.0,49699333,closed,0,,,2,2023-07-10T13:49:12Z,2023-08-07T16:20:22Z,2023-08-07T16:20:20Z,CONTRIBUTOR,simonw/datasette/pulls/2098,"Bumps [blacken-docs](https://github.com/asottile/blacken-docs) from 1.14.0 to 1.15.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/adamchainz/blacken-docs/blob/main/CHANGELOG.rst"">blacken-docs's changelog</a>.</em></p>
<blockquote>
<h2>1.15.0 (2023-07-09)</h2>
<ul>
<li>Drop Python 3.7 support.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/2e74dc4c30c336176e76e0426c66f09a4e79df9c""><code>2e74dc4</code></a> Version 1.15.0</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/8ddb2f1269b7652a9b668faa92c9d63d764696c0""><code>8ddb2f1</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/257"">#257</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/64fbca6cad36db1822528ece7f97a8152d29e05f""><code>64fbca6</code></a> Drop Python 3.7 support (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/256"">#256</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/f6a0817dbb7957f96ea6cc251edf3a50bf1c3c08""><code>f6a0817</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/255"">#255</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/cbdcb50b125b4f2fdb470122b2ba5e3c15de241a""><code>cbdcb50</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/254"">#254</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/37fc70ee00c7063777ed7343c1bd26fceb5422a6""><code>37fc70e</code></a> Upgrade requirements (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/253"">#253</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/7bbe434415ce9f590cb057010590a648e7bea072""><code>7bbe434</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/250"">#250</a>)</li>
<li>See full diff in <a href=""https://github.com/asottile/blacken-docs/compare/1.14.0...1.15.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=blacken-docs&package-manager=pip&previous-version=1.14.0&new-version=1.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2098.org.readthedocs.build/en/2098/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2098/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1795051447,I_kwDOBm6k_c5q_k-3,2097,Drop Python 3.7,9599,closed,0,,,0,2023-07-08T18:39:44Z,2023-08-23T18:18:00Z,2023-08-23T18:18:00Z,OWNER,,">  I'm going to drop Python 3.7.

_Originally posted by @simonw in https://github.com/simonw/datasette/issues/1153#issuecomment-1627455892_

It's not supported any more: https://devguide.python.org/versions/",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2097/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1794604602,PR_kwDOBm6k_c5U-akg,2096,Clarify docs for descriptions in metadata,15906,open,0,,,0,2023-07-08T01:57:58Z,2023-07-08T01:58:13Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2096,"G'day! I got confused while debugging, earlier today. That's on me, but it does strike me a little repetition in the metadata documentation might help those flicking around it rather than reading it from top to bottom. No worries if you think otherwise.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2096.org.readthedocs.build/en/2096/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2096/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1794097871,I_kwDOBm6k_c5q78LP,2095,"Introduce ""dark mode"" CSS",3315059,open,0,,,0,2023-07-07T19:15:58Z,2023-07-07T19:15:58Z,,NONE,,Using [the CSS media query `prefers-color-scheme`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme) we can provide a dark-mode version of Datasette,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2095/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1783304750,I_kwDOBm6k_c5qSxIu,2094,JS Plugin Hooks for the Code Editor,15178711,open,0,,,0,2023-07-01T00:51:57Z,2023-07-01T00:51:57Z,,CONTRIBUTOR,,"When #2052 merges, I'd like to add support to add extensions/functions to the Datasette code editor. 

I'd eventually like to build a JS plugin for [`sqlite-docs`](https://github.com/asg017/sqlite-docs), to add things like:

- Inline documentation for tables/columns on hover
- Inline docs for custom functions that are loaded in
- More detailed autocomplete for tables/columns/functions

I did some hacking to see what this would look like, see here:

<img width=""1223"" alt=""image"" src=""https://github.com/simonw/datasette/assets/15178711/64f95cbc-1492-4365-896f-b88c6d08a649"">
<img width=""1223"" alt=""image"" src=""https://github.com/simonw/datasette/assets/15178711/73e602ba-5f45-417a-997e-5aea1738527a"">

There can be a new hook that allows JS plugins to add new ""extension"" in the CodeMirror editorview here:

https://github.com/simonw/datasette/blob/8cd60fd1d899952f1153460469b3175465f33f80/datasette/static/cm-editor-6.0.1.js#L25

Will need some more planning. For example, the Codemirror bundle in Datasette has functions that we could re-export for plugins to use (so we don't load 2 version of `""@codemirror/autocomplete""`, for example. ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2094/reactions"", ""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1781530343,I_kwDOBm6k_c5qL_7n,2093,"Proposal: Combine settings, metadata, static, etc. into a single `datasette.yaml` File",15178711,open,0,,,8,2023-06-29T21:18:23Z,2023-09-11T20:19:32Z,,CONTRIBUTOR,,"Very often I get tripped up when trying to configure my Datasette instances. For example: if I want to change the port my app listen too, do I do that with a CLI flag, a `--setting` flag, inside `metadata.json`, or an env var? If I want to up the time limit of SQL statements, is that under `metadata.json` or a setting? Where does my plugin configuration go?

Normally I need to look it up in Datasette docs, and I quickly find my answer, but the number of places where ""config"" goes it overwhelming.

- Flat CLI flags like `--port`, `--host`, `--cors`, etc.
- `--setting`, like `default_page_size`, `sql_time_limit_ms` etc
- Inside `metadata.json`, including plugin configuration

Typically my Datasette deploys are extremely long shell commands, with multiple `--setting` and other CLI flags.

## Proposal: Consolidate all ""config"" into `datasette.toml`

I propose that we add a new `datasette.toml` that combines ""settings"", ""metadata"", and other common CLI flags like `--port` and `--cors` into a single file. It would be similar to ""Cargo.toml"" in Rust projects, ""package.json"" in Node projects, and ""pyproject.toml"" in Python, etc.

A sample of what it could look like:

```toml
# ""top level"" configuration that are currently CLI flags on `datasette serve`
[config]
port = 8020
host = ""0.0.0.0""
cors = true

# replaces multiple `--setting` flags
[settings]
base_url = ""/app/datasette/""
default_allow_sql = true
sql_time_limit_ms = 3500

# replaces `metadata.json`.
# The contents of datasette-metadata.json could be defined in this file instead, but supporting separate files is nice (since those are easy to machine-generate)
[metadata]
include=""./datasette-metadata.json""

# plugin-specific 
[plugins]
[plugins.datasette-auth-github]
client_id = {env = ""DATASETTE_AUTH_GITHUB_CLIENT_ID""}
client_secret = {env = ""GITHUB_CLIENT_SECRET""}

[plugins.datasette-cluster-map]

latitude_column = ""lat""
longitude_column = ""lon""
```

## Pros
- Instead of multiple files and CLI flags, everything could be in one tidy file
- Editing config in a separate file is easier than editing CLI flags, since you don't have to kill a process + edit a command every time
- New users will know ""just edit my `datasette.toml` instead of needing to learn metadata + settings + CLI flags
- Better dev experience for multiple environment. For example, could have `datasette -c datasette-dev.toml` for local dev environments (enables SQL, debug plugins, long timeouts, etc.), and a `datasette -c datasette-prod.toml` for ""production"" (lower timeouts, less plugins, monitoring plugins, etc.)

## Cons
- Yet another config-management system. Now Datasette users will need to know about metadata, settings, CLI flags, _and_ `datasette.toml`. However with enough documentation + announcements + examples, I think we can get ahead of it.
- If toml is chosen, would need to add a toml parser for Python version <3.11
- Multiple sources of config require priority. For example: Would `--setting default_allow_sql off` override the value inside `[settings]`? What about `--port`? 

## Other Notes

### Toml

I chose toml over json because toml supports comments. I chose toml over yaml because Python 3.11 has builtin support for it. I also find toml easier to work with since it doesn't have the odd ""gotchas"" that YAML has (""ex `3.10` resolving to `3.1`, Norway `NO` resolving to `false`, etc.). It also mimics `pyproject.toml` which is nice. Happy to change my mind about this however


### Plugin config will be difficult

Plugin config is currently in `metadata.json` in two places:

1. Top level, under `""plugins.[plugin-name]""`. This fits well into `datasette.toml` as `[plugins.plugin-name]`
2. Table level, under `""databases.[db-name].tables.[table-name].plugins.[plugin-name]`. This doesn't fit that well into `datasette.toml`, unless it's nested under `[metadata]`?

### Extensions, static, one-off plugins?

We could also include equivalents of `--plugins-dir`, `--static`, and `--load-extension` into `datasette.toml`, but I'd imagine there's a few security concerns there to think through. 


### Explicitly list with plugins to use?

I believe Datasette by default will load all install plugins on startup, but maybe `datasette.toml` can specify a list of plugins to use? For example, a dev version of `datasette.toml` can specify `datasette-pretty-traces`, but the prod version can leave it out",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2093/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1781047747,I_kwDOBm6k_c5qKKHD,2092,test_homepage intermittent failure,9599,closed,0,,,2,2023-06-29T15:20:37Z,2023-06-29T15:26:28Z,2023-06-29T15:24:13Z,OWNER,,"e.g. in https://github.com/simonw/datasette/actions/runs/5413590227/jobs/9839373852

```
=================================== FAILURES ===================================
________________________________ test_homepage _________________________________
[gw0] linux -- Python 3.7.17 /opt/hostedtoolcache/Python/3.7.17/x64/bin/python

ds_client = <datasette.app.DatasetteClient object at 0x7f85d271ef50>

    @pytest.mark.asyncio
    async def test_homepage(ds_client):
        response = await ds_client.get(""/.json"")
        assert response.status_code == 200
        assert ""application/json; charset=utf-8"" == response.headers[""content-type""]
        data = response.json()
        assert data.keys() == {""fixtures"": 0}.keys()
        d = data[""fixtures""]
        assert d[""name""] == ""fixtures""
        assert d[""tables_count""] == 24
        assert len(d[""tables_and_views_truncated""]) == 5
        assert d[""tables_and_views_more""] is True
        # 4 hidden FTS tables + no_primary_key (hidden in metadata)
        assert d[""hidden_tables_count""] == 6
        # 201 in no_primary_key, plus 6 in other hidden tables:
>       assert d[""hidden_table_rows_sum""] == 207, data
E       AssertionError: {'fixtures': {'color': '9403e5', 'hash': None, 'hidden_table_rows_sum': 0, 'hidden_tables_count': 6, ...}}
E       assert 0 == 207
```
My guess is that this is a timing error, where very occasionally the ""count rows but stop counting if it exceeds a time limit"" thing fails.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2092/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1781022369,I_kwDOBm6k_c5qKD6h,2091,Drop support for Python 3.7,9599,closed,0,,,3,2023-06-29T15:06:38Z,2023-08-23T18:18:18Z,2023-08-23T18:18:18Z,OWNER,,"It's EOL now, as of 2023-06-27 (two days ago): https://devguide.python.org/versions/

",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2091/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1781005740,I_kwDOBm6k_c5qJ_2s,2090,Adopt ruff for linting,9599,open,0,,,2,2023-06-29T14:56:43Z,2023-06-29T15:05:04Z,,OWNER,,https://beta.ruff.rs/docs/,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2090/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1780973290,I_kwDOBm6k_c5qJ37q,2089,codespell test failure,9599,closed,0,,,5,2023-06-29T14:40:10Z,2023-06-29T14:48:11Z,2023-06-29T14:48:10Z,OWNER,,"https://github.com/simonw/datasette/actions/runs/5413443676/jobs/9838999356
```
  codespell docs/*.rst --ignore-words docs/codespell-ignore-words.txt
  codespell datasette -S datasette/static --ignore-words docs/codespell-ignore-words.txt
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.17/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.17/x64/lib
docs/metadata.rst:192: displaing ==> displaying
```
This failure is legit, it found a spelling mistake: https://github.com/simonw/datasette/blob/ede62036180993dbd9d4e5d280fc21c183cda1c3/docs/metadata.rst#L192",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2089/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1765870617,I_kwDOBm6k_c5pQQwZ,2087,`--settings settings.json` option,9599,open,0,,,2,2023-06-20T17:48:45Z,2023-07-14T17:02:03Z,,OWNER,,"https://discord.com/channels/823971286308356157/823971286941302908/1120705940728066080

> May I add a request to the whole metadata / settings ? Allow to pass `--settings path/to/settings.json` instead of having to rely exclusively on directory mode to centralize settings (this would reflect the behavior of providing metadata)",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2087/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1764792125,I_kwDOBm6k_c5pMJc9,2086,Show information on startup in directory configuration mode,9599,open,0,,,0,2023-06-20T07:13:33Z,2023-06-20T07:13:33Z,,OWNER,,"https://discord.com/channels/823971286308356157/823971286941302908/1120516587036889098

> One thing that would be helpful would be message at launch indicating a metadata.json is getting picked up. I'm using directory mode and was editing the wrong file for awhile before I realize nothing I was doing was having any effect.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2086/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1762180409,I_kwDOBm6k_c5pCL05,2085,Interactive row selection in Datasette ,24938923,open,0,,,0,2023-06-18T08:29:45Z,2023-06-18T08:31:23Z,,NONE,,"Simon did a excellent [prototype](https://til.simonwillison.net/datasette/row-selection-prototype) of an interactive row selection in Datasette.

I hope this [functionality](https://camo.githubusercontent.com/3d4a0f31fb6a27fd279f809af5b53dc3b76faa63c7721e228951c5252b645a77/68747470733a2f2f7374617469632e73696d6f6e77696c6c69736f6e2e6e65742f7374617469632f323032332f6461746173657474652d7069636b65722e676966) can be turned into a Datasette plugin.
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2085/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1761613778,I_kwDOBm6k_c5pABfS,2084,Support facets for columns that contain timestamps,19492893,open,0,,,0,2023-06-17T03:33:54Z,2023-06-17T03:33:54Z,,NONE,,"
Django has this very nice filter for datetime fields -

<img width=""176"" alt=""image"" src=""https://github.com/simonw/datasette/assets/19492893/3c66d7c4-1579-4d30-8f08-89d111f4566e"">

It would be nice to have something similar to facet by a field that contains a timestamp in datasette too - Which doesn't seem to do anything with timestamps right now...

<img width=""283"" alt=""image"" src=""https://github.com/simonw/datasette/assets/19492893/069083e4-13f5-4b28-9473-a7b9d48839ea"">
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2084/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1756975532,PR_kwDOBm6k_c5S_5Jl,2083,Bump blacken-docs from 1.13.0 to 1.14.0,49699333,closed,0,,,0,2023-06-14T13:57:52Z,2023-06-29T14:31:55Z,2023-06-29T14:31:54Z,CONTRIBUTOR,simonw/datasette/pulls/2083,"Bumps [blacken-docs](https://github.com/asottile/blacken-docs) from 1.13.0 to 1.14.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/adamchainz/blacken-docs/blob/main/CHANGELOG.rst"">blacken-docs's changelog</a>.</em></p>
<blockquote>
<h2>1.14.0 (2023-06-13)</h2>
<ul>
<li>Support Python 3.12.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/4b94add9bc83d772ae5e31a679a18609c1750513""><code>4b94add</code></a> Version 1.14.0</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/292cb18828c73dfa5273c88ce261b453fb9fdf43""><code>292cb18</code></a> Support Python 3.12 (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/251"">#251</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/72ecf2c719027fd464f5561d4ab119f736e8a4ad""><code>72ecf2c</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/249"">#249</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/ea8f1ca88f2f0a58371bb07dab9c647d56d5b3ed""><code>ea8f1ca</code></a> Upgrade requirements (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/248"">#248</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/9979d7a78be5b7749ebb000f10f4515e5dc9a574""><code>9979d7a</code></a> Upgrade requirements (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/247"">#247</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/7b71075ceb458be255e24da587c0275818b51faa""><code>7b71075</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/245"">#245</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/6280868a8b944193e72436bb467749a21b790d7c""><code>6280868</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/244"">#244</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/83efc37a18b2aea999985439841d644833cb9b90""><code>83efc37</code></a> Upgrade requirements (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/243"">#243</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/7aedc23ae3fa040c30e122d8beb66928a05d5320""><code>7aedc23</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/242"">#242</a>)</li>
<li><a href=""https://github.com/adamchainz/blacken-docs/commit/d78d593d9a523c8d82d234b94d8ced690ee55fe6""><code>d78d593</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/asottile/blacken-docs/issues/241"">#241</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/asottile/blacken-docs/compare/1.13.0...1.14.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=blacken-docs&package-manager=pip&previous-version=1.13.0&new-version=1.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2083.org.readthedocs.build/en/2083/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2083/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1734786661,PR_kwDOBm6k_c5R0fcK,2082,Catch query interrupted on facet suggest row count,10843208,open,0,,,0,2023-05-31T18:42:46Z,2023-05-31T18:45:26Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2082,"Just like facet's `suggest()` is trapping `QueryInterrupted` for facet columns, we also need to trap `get_row_count()`, which can reach timeout if database tables are big enough. 

I've included `get_columns()` inside the block as that's just another query, despite it's a really cheap one and might never raise the exception.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2082.org.readthedocs.build/en/2082/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2082/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1727478903,I_kwDOBm6k_c5m9zx3,2081,Update Endpoints defined in metadata throws 403 Forbidden after a while,15085007,open,0,,,0,2023-05-26T11:52:30Z,2023-05-26T11:52:30Z,,NONE,,"Hello. I expose an endpoint to update `tasks`:
```
{
    ""title"": ""My Datasette Instance"",
    ""databases"": {
        ""tasks"": {
            ""queries"": {
                ""update_task"": {
                    ""sql"": ""UPDATE tasks SET status = :status, result = :result, systemMessage = :systemMessage WHERE queueID = :queueID"",
                    ""write"": true,
                    ""on_success_message"": ""Task updated"",
                    ""on_success_redirect"": ""/tasks/tasks.json"",
                    ""on_error_message"": ""Task update failed"",
                    ""on_error_redirect"": ""/tasks.json"",
                    ""params"": [""queueID"", ""taskData"", ""status"", ""result"", ""systemMessage""]
                }
            }
        }
    }
}
```

This works really well! But after a while, the Datasette Instanz answers with **403 Forbidden**.
I have to delete the database and recreate it in order to work again.

Any help here? (´。＿。｀)",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2081/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1726603778,PR_kwDOBm6k_c5RYvTU,2080,New View base class,9599,closed,0,,,3,2023-05-25T23:22:55Z,2023-05-26T00:18:45Z,2023-05-26T00:18:44Z,OWNER,simonw/datasette/pulls/2080,"Refs:

- #2078

TODO:

- [x] Teach router layer how to handle this
- [x] Use it for something

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2080.org.readthedocs.build/en/2080/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2080/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1726531350,I_kwDOBm6k_c5m6McW,2079,Datasette should serve Access-Control-Max-Age,9599,closed,0,,,8,2023-05-25T21:50:50Z,2023-05-25T22:56:28Z,2023-05-25T22:08:35Z,OWNER,,"Currently the CORS headers served are:

https://github.com/simonw/datasette/blob/9584879534ff0556e04e4c420262972884cac87b/datasette/utils/__init__.py#L1139-L1143

Serving `Access-Control-Max-Age: 600` would allow browsers to cache that for 10 minutes, avoiding additional CORS pre-flight OPTIONS requests during that time.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2079/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1726236847,I_kwDOBm6k_c5m5Eiv,2078,Resolve the difference between `wrap_view()` and `BaseView`,9599,closed,0,,,16,2023-05-25T17:44:32Z,2023-05-26T00:18:46Z,2023-05-26T00:18:46Z,OWNER,,"There are two patterns for implementing views in Datasette at the moment. I want to combine those.

Part of:
- #2053",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2078/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1719759468,PR_kwDOBm6k_c5RBXH_,2077,Bump furo from 2023.3.27 to 2023.5.20,49699333,closed,0,,,3,2023-05-22T13:58:16Z,2023-07-27T13:40:55Z,2023-07-27T13:40:53Z,CONTRIBUTOR,simonw/datasette/pulls/2077,"Bumps [furo](https://github.com/pradyunsg/furo) from 2023.3.27 to 2023.5.20.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/pradyunsg/furo/blob/main/docs/changelog.md"">furo's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<!-- raw HTML omitted -->
<h2>2023.05.20 -- Unassuming Ultramarine</h2>
<ul>
<li>✨ Add support for Sphinx 7.</li>
<li>Drop support for Sphinx 5.</li>
<li>Improve the screen-reader label for sidebar collapse.</li>
<li>Make it easier to create derived themes from Furo.</li>
<li>Bump all JS dependencies (NodeJS and npm packages).</li>
</ul>
<h2>2023.03.27 -- Tasty Tangerine</h2>
<ul>
<li>Regenerate with newer version of sphinx-theme-builder, to fix RECORD hashes.</li>
<li>Add missing class to Font Awesome examples</li>
</ul>
<h2>2023.03.23 -- Sassy Saffron</h2>
<ul>
<li>Update Python version classifiers.</li>
<li>Increase the icon size in mobile header.</li>
<li>Increase admonition title bg opacity.</li>
<li>Change the default API background to transparent.</li>
<li>Transition the API background change.</li>
<li>Remove the &quot;indent&quot; of API entries which have a background.</li>
<li>Break long inline code literals.</li>
</ul>
<h2>2022.12.07 -- Reverent Raspberry</h2>
<ul>
<li>✨ Add support for Sphinx 6.</li>
<li>✨ Improve footnote presentation with docutils 0.18+.</li>
<li>Drop support for Sphinx 4.</li>
<li>Improve documentation about what the edit button does.</li>
<li>Improve handling of empty-flexboxes for better print experience on Chrome.</li>
<li>Improve styling for inline signatures.</li>
<li>Replace the <code>meta</code> generator tag with a comment.</li>
<li>Tweak labels with icons to prevent users selecting icons as text on touch.</li>
</ul>
<h2>2022.09.29 -- Quaint Quartz</h2>
<ul>
<li>Add ability to set arbitrary URLs for edit button.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/pradyunsg/furo/commit/d2c9ca852542820632361f05521b5c94824d1fdc""><code>d2c9ca8</code></a> Prepare release: 2023.05.20</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/662d21b66c0422693e3bcdac87e1c605ed95b32f""><code>662d21b</code></a> Update changelog</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/591780b0f01378aef769da40e5d7a917304bd1a5""><code>591780b</code></a> Bump compatible Sphinx version</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/c2e7837352d290f75579b1859233e9c77afc8911""><code>c2e7837</code></a> Bump NodeJS and package versions</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/dd85574e803bb5e9416be66696acc1a6f91f3470""><code>dd85574</code></a> Use the reference HtmlFormatter class defined on PygmentsBridge. (<a href=""https://redirect.github.com/pradyunsg/furo/issues/657"">#657</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/6bff41949f18dc204cfaeae82c42a7197ff3a200""><code>6bff419</code></a> Fix broken link (<a href=""https://redirect.github.com/pradyunsg/furo/issues/654"">#654</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/e7f732ea5133d29fc6ca62af0455b16ffaab00dc""><code>e7f732e</code></a> Improve the screen-reader label for sidebar collapse</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/48c0bf2aa983fb1ccd79b4167fe85387249afedf""><code>48c0bf2</code></a> Drop the check for the theme name</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/1b17d8102079c3ec2a49f57ebc1931f6869cd61d""><code>1b17d81</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/pradyunsg/furo/issues/646"">#646</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/4904fd5ce0c74386eaee3bd07940aa46254a11ce""><code>4904fd5</code></a> Remove Python 3.8 constraint from Black pre-commit config (<a href=""https://redirect.github.com/pradyunsg/furo/issues/647"">#647</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/pradyunsg/furo/compare/2023.03.27...2023.05.20"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=furo&package-manager=pip&previous-version=2023.3.27&new-version=2023.5.20)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2077.org.readthedocs.build/en/2077/

<!-- readthedocs-preview datasette end -->
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2077/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1715468032,PR_kwDOBm6k_c5QzEAM,2076,Datsette gpt plugin,130708713,open,0,,,0,2023-05-18T11:22:30Z,2023-05-18T11:22:45Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2076,"

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2076.org.readthedocs.build/en/2076/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2076/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1710164693,PR_kwDOBm6k_c5QhIL2,2075,Bump sphinx from 6.1.3 to 7.0.1,49699333,closed,0,,,2,2023-05-15T13:59:31Z,2023-07-25T13:28:39Z,2023-07-25T13:28:36Z,CONTRIBUTOR,simonw/datasette/pulls/2075,"Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 7.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>v7.0.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.0rc1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 7.0.1 (released May 12, 2023)</h1>
<h2>Dependencies</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11411"">#11411</a>: Support <code>Docutils 0.20</code>_. Patch by Adam Turner.</li>
</ul>
<p>.. _Docutils 0.20: <a href=""https://docutils.sourceforge.io/RELEASE-NOTES.html#release-0-20-2023-05-04"">https://docutils.sourceforge.io/RELEASE-NOTES.html#release-0-20-2023-05-04</a></p>
<h2>Bugs fixed</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11418"">#11418</a>: Clean up remaining references to <code>sphinx.setup_command</code>
following the removal of support for setuptools.
Patch by Willem Mulder.</li>
</ul>
<h1>Release 7.0.0 (released Apr 29, 2023)</h1>
<h2>Incompatible changes</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11359"">#11359</a>: Remove long-deprecated aliases for <code>MecabSplitter</code> and
<code>DefaultSplitter</code> in <code>sphinx.search.ja</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11360"">#11360</a>: Remove deprecated <code>make_old_id</code> functions in domain object
description classes.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11363"">#11363</a>: Remove the Setuptools integration (<code>build_sphinx</code> hook in
<code>setup.py</code>).</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11364"">#11364</a>: Remove deprecated <code>sphinx.ext.napoleon.iterators</code> module.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11365"">#11365</a>: Remove support for the <code>jsdump</code> format in <code>sphinx.search</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11366"">#11366</a>: Make <code>locale</code> a required argument to
<code>sphinx.util.i18n.format_date()</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11370"">#11370</a>: Remove deprecated <code>sphinx.util.stemmer</code> module.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11371"">#11371</a>: Remove deprecated <code>sphinx.pycode.ast.parse()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11372"">#11372</a>: Remove deprecated <code>sphinx.io.read_doc()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11373"">#11373</a>: Removed deprecated <code>sphinx.util.get_matching_files()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11378"">#11378</a>: Remove deprecated <code>sphinx.util.docutils.is_html5_writer_available()</code>
function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11379"">#11379</a>: Make the <code>env</code> argument to <code>Builder</code> subclasses required.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11380"">#11380</a>: autosummary: Always emit grouped import exceptions.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11381"">#11381</a>: Remove deprecated <code>style</code> key for HTML templates.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11382"">#11382</a>: Remove deprecated <code>sphinx.writers.latex.LaTeXTranslator.docclasses</code>
attribute.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11383"">#11383</a>: Remove deprecated <code>sphinx.builders.html.html5_ready</code> and
<code>sphinx.builders.html.HTMLTranslator</code> attributes.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11385"">#11385</a>: Remove support for HTML 4 output.</li>
</ul>
<h1>Release 6.2.1 (released Apr 25, 2023)</h1>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/d48cc783b6e48b99cbbcf5462f44c59a4ed78e6a""><code>d48cc78</code></a> Bump to 7.0.1 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/de6b18ac7de317030be4344ea7a9d553c423ffcf""><code>de6b18a</code></a> Remove remaining references to the setuptools integration (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11418"">#11418</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/db546189ce1d2a345f4399367ced6ecdd538be5d""><code>db54618</code></a> Support Docutils 0.20 (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11411"">#11411</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/8942a1dddf2355928f088d6b631db8658034eaae""><code>8942a1d</code></a> Test with Docutils 0.20</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/c9d0933e5d8e34aa9d2c1d88c5a80b46b575730e""><code>c9d0933</code></a> linkcheck: Use context managers for HTTP requests (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11318"">#11318</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/2b1c106bbff5265e8a6076318db5d083c329d575""><code>2b1c106</code></a> Update documentation workflow</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ba7408209e84ee413f240afc20f3c6b484a81f8f""><code>ba74082</code></a> Change concurrency groups for GitHub workflows</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/b546879539200ec4128bcc6d0ed911ebf28bb3cb""><code>b546879</code></a> Bump version</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/d568b2f4f7cca743fcbf70814d15602d8129b790""><code>d568b2f</code></a> Bump to 7.0.0 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ff79edf353f5cc6e02036f58e0295dc704c5e681""><code>ff79edf</code></a> Remove <code>jsdump</code> references post removal</li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v7.0.1"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=6.1.3&new-version=7.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2075.org.readthedocs.build/en/2075/

<!-- readthedocs-preview datasette end -->
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2075/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1708981860,PR_kwDOBm6k_c5QdMea,2074,sort files by mtime,3919561,open,0,,,0,2023-05-14T15:25:15Z,2023-05-14T15:25:29Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2074,"serving multiple database files and getting tired by the default sort, changes so the sort order puts the latest changed databases to be on top of the list so don't have to scroll down, lazy as i am ;)

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2074.org.readthedocs.build/en/2074/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2074/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1708030220,I_kwDOBm6k_c5lznkM,2073,Faceting doesn't work against integer columns in views,9599,open,0,,,2,2023-05-12T18:20:10Z,2023-05-12T18:24:07Z,,OWNER,,"Spotted this issue here: https://til.simonwillison.net/datasette/baseline

I had to do this workaround:
```sql
create view baseline as select
  _key,
  spec,
  '' || json_extract(status, '$.is_baseline') as is_baseline,
  json_extract(status, '$.since') as baseline_since,
  json_extract(status, '$.support.chrome') as baseline_chrome,
  json_extract(status, '$.support.edge') as baseline_edge,
  json_extract(status, '$.support.firefox') as baseline_firefox,
  json_extract(status, '$.support.safari') as baseline_safari,
  compat_features,
  caniuse,
  usage_stats,
  status
from
  [index]
```
I think the core issue here is that, against a table, `select * from x where integer_column = '1'` works correctly, due to some kind of column type conversion mechanism... but this mechanism doesn't work against views.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2073/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1702354223,I_kwDOBm6k_c5ld90v,2070,Mechanism for deploying a preview of a branch using Vercel,9599,closed,0,,,2,2023-05-09T16:21:45Z,2023-05-09T16:25:00Z,2023-05-09T16:24:31Z,OWNER,,"I prototyped that here: https://github.com/simonw/one-off-actions/blob/main/.github/workflows/deploy-datasette-branch-preview.yml

It deployed the `json-extras-query` branch here: https://datasette-preview-json-extras-query.vercel.app/",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2070/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1698865182,I_kwDOBm6k_c5lQqAe,2069,[BUG] Cannot insert new data to deployed instance,31861128,open,0,,,1,2023-05-07T02:59:42Z,2023-05-07T03:17:35Z,,NONE,,"## Summary

Recently, I deployed an instance of datasette to Vercel with the following plugins:

- datasette-auth-tokens
- datasette-insert

With the above plugins, I was able to insert new data to local sqlite db. However, when it comes to the deployment on Vercel, things behave differently. I observed some errors from the logs console on Vercel:

```console
File ""/var/task/datasette/database.py"", line 179, in _execute_writes
conn = self.connect(write=True)
File ""/var/task/datasette/database.py"", line 93, in connect
assert not (write and not self.is_mutable)
AssertionError
``` 

<img width=""1380"" alt=""image"" src=""https://user-images.githubusercontent.com/31861128/236655274-3fd5e16f-4e06-4ba8-87ff-41130b8ebe90.png"">

I think it is a potential bug.

## Reproduce

<details><summary>metadata.json</summary>
</br>

```json
{
  ""plugins"": {
    ""datasette-insert"": {
      ""allow"": {
        ""id"": ""*""
      }
    },
    ""datasette-auth-tokens"": {
      ""tokens"": [
        {
          ""token"": {
            ""$env"": ""INSERT_TOKEN""
          },
          ""actor"": {
            ""id"": ""repeater""
          }
        }
      ],
      ""param"": ""_auth_token""
    }
  }
}
```

</details>

<details><summary>commands</summary>
</br>

```bash
# deploy
datasette publish vercel remote.db \
  --project=repeater-bot-sqlite \
  --metadata metadata.json \
  --install datasette-auth-tokens \
  --install datasette-insert \
  --vercel-json=vercel.json

# test insert
cat fixtures/dogs.json | curl --request POST -d @- -H ""Authorization: Bearer <token>"" \
  'https://repeater-bot-sqlite.vercel.app/-/insert/remote/dogs?pk=id'
```

</details>

<details><summary>logs</summary>
</br>

```console
Traceback (most recent call last):
File ""/var/task/datasette/app.py"", line 1354, in route_path
response = await view(request, send)
File ""/var/task/datasette/app.py"", line 1500, in async_view_fn
response = await async_call_with_supported_arguments(
File ""/var/task/datasette/utils/__init__.py"", line 1005, in async_call_with_supported_arguments
return await fn(*call_with)
File ""/var/task/datasette_insert/__init__.py"", line 14, in insert_or_upsert
response = await insert_or_upsert_implementation(request, datasette)
File ""/var/task/datasette_insert/__init__.py"", line 91, in insert_or_upsert_implementation
table_count = await db.execute_write_fn(write_in_thread, block=True)
File ""/var/task/datasette/database.py"", line 167, in execute_write_fn
raise result
File ""/var/task/datasette/database.py"", line 179, in _execute_writes
conn = self.connect(write=True)
File ""/var/task/datasette/database.py"", line 93, in connect
assert not (write and not self.is_mutable)
AssertionError
```

</details>",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2069/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1690842199,PR_kwDOBm6k_c5PgNaA,2068,Bump sphinx from 6.1.3 to 7.0.0,49699333,closed,0,,,1,2023-05-01T13:58:46Z,2023-05-15T13:59:38Z,2023-05-15T13:59:36Z,CONTRIBUTOR,simonw/datasette/pulls/2068,"Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 7.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v7.0.0rc1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 7.0.0 (released Apr 29, 2023)</h1>
<h2>Incompatible changes</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11359"">#11359</a>: Remove long-deprecated aliases for <code>MecabSplitter</code> and
<code>DefaultSplitter</code> in <code>sphinx.search.ja</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11360"">#11360</a>: Remove deprecated <code>make_old_id</code> functions in domain object
description classes.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11363"">#11363</a>: Remove the Setuptools integration (<code>build_sphinx</code> hook in
<code>setup.py</code>).</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11364"">#11364</a>: Remove deprecated <code>sphinx.ext.napoleon.iterators</code> module.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11365"">#11365</a>: Remove support for the <code>jsdump</code> format in <code>sphinx.search</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11366"">#11366</a>: Make <code>locale</code> a required argument to
<code>sphinx.util.i18n.format_date()</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11370"">#11370</a>: Remove deprecated <code>sphinx.util.stemmer</code> module.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11371"">#11371</a>: Remove deprecated <code>sphinx.pycode.ast.parse()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11372"">#11372</a>: Remove deprecated <code>sphinx.io.read_doc()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11373"">#11373</a>: Removed deprecated <code>sphinx.util.get_matching_files()</code> function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11378"">#11378</a>: Remove deprecated <code>sphinx.util.docutils.is_html5_writer_available()</code>
function.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11379"">#11379</a>: Make the <code>env</code> argument to <code>Builder</code> subclasses required.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11380"">#11380</a>: autosummary: Always emit grouped import exceptions.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11381"">#11381</a>: Remove deprecated <code>style</code> key for HTML templates.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11382"">#11382</a>: Remove deprecated <code>sphinx.writers.latex.LaTeXTranslator.docclasses</code>
attribute.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11383"">#11383</a>: Remove deprecated <code>sphinx.builders.html.html5_ready</code> and
<code>sphinx.builders.html.HTMLTranslator</code> attributes.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11385"">#11385</a>: Remove support for HTML 4 output.</li>
</ul>
<h1>Release 6.2.1 (released Apr 25, 2023)</h1>
<h2>Bugs fixed</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11355"">#11355</a>: Revert the default type of :confval:<code>nitpick_ignore</code> and
:confval:<code>nitpick_ignore_regex</code> to <code>list</code>.</li>
</ul>
<h1>Release 6.2.0 (released Apr 23, 2023)</h1>
<h2>Dependencies</h2>
<ul>
<li>Require Docutils 0.18.1 or greater.</li>
</ul>
<h2>Incompatible changes</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/d568b2f4f7cca743fcbf70814d15602d8129b790""><code>d568b2f</code></a> Bump to 7.0.0 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ff79edf353f5cc6e02036f58e0295dc704c5e681""><code>ff79edf</code></a> Remove <code>jsdump</code> references post removal</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/1a5133ac391931d8e0e2a271fe8ea9c505176908""><code>1a5133a</code></a> Bump to 7.0.0rc1 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/5795fc7f9f7a5fe968cd11b961fc33fbd952a152""><code>5795fc7</code></a> Update <code>sphinx.deprecation</code> for Sphinx 7.0 (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11386"">#11386</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/6202087f912a2ae32808865072f884ea44cd31cb""><code>6202087</code></a> Add a note to CHANGES for PR 11385</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ad473730a3763f241e9aaea1a87d1893f01b86fd""><code>ad47373</code></a> Remove HTML 4 support (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11385"">#11385</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/3e3251d3ba4f1e5fa6d34d995505f4d3ace5acad""><code>3e3251d</code></a> Remove <code>HTMLTranslator</code> and <code>html5_ready</code> from <code>sphinx.builders.html</code> (...</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/77fd819a09881102bdd48593cc69ec164b2495c8""><code>77fd819</code></a> Remove deprecated <code>LaTeXTranslator.docclasses</code> attribute (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11382"">#11382</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/4be56f3b7ddf44265d2e7a8f26a33ba46be52ab9""><code>4be56f3</code></a> Remove deprecated <code>style</code> key for HTML templates (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11381"">#11381</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/49027a9ae61d0d00016182025f68239a50ba4c09""><code>49027a9</code></a> Autosummary: Always emit grouped <code>ImportError</code> exceptions (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11380"">#11380</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v7.0.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=6.1.3&new-version=7.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2068.org.readthedocs.build/en/2068/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2068/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1690765434,I_kwDOBm6k_c5kxwh6,2067,Litestream-restored db: errors on 3.11 and 3.10.8; but works on py3.10.7 and 3.10.6,39538958,open,0,,,1,2023-05-01T12:42:28Z,2023-05-03T00:16:03Z,,NONE,,"Hi! Wondering if this issue is limited to my local system or if it affects others as well. 

It seems like 3.11 errors out on a ""litestream-restored"" database. On further investigation, it also appears to conk out on 3.10.8 but works on 3.10.7 and 3.10.6.

To demo issue I created a test database, replicated it to an aws s3 bucket, then restored the same under various .pyenv-versioned shells where I test whether I can read the database via the sqlite3 cli.

```sh
# create new shell with 3.11.3
litestream restore -o data/db.sqlite s3://mytestbucketxx/db
sqlite3 data/db.sqlite  
# SQLite version 3.41.2 2023-03-22 11:56:21
# Enter "".help"" for usage hints.
# sqlite> .tables
# _litestream_lock  _litestream_seq   movie           
# sqlite> 
```

However this get me an `OperationalError` when reading via datasette:

<details>
<summary>Error on 3.11.3 and 3.10.8</summary>

```sh
datasette data/db.sqlite
```

```console
/tester/.venv/lib/python3.11/site-packages/pkg_resources/__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
  warnings.warn(""pkg_resources is deprecated as an API"", DeprecationWarning)
Traceback (most recent call last):
  File ""/tester/.venv/bin/datasette"", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/click/core.py"", line 1130, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/click/core.py"", line 1055, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/click/core.py"", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/click/core.py"", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/click/core.py"", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/cli.py"", line 143, in wrapped
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/cli.py"", line 615, in serve
    asyncio.get_event_loop().run_until_complete(check_databases(ds))
  File ""/Users/mv/.pyenv/versions/3.11.3/lib/python3.11/asyncio/base_events.py"", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/cli.py"", line 660, in check_databases
    await database.execute_fn(check_connection)
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/database.py"", line 213, in execute_fn
    return await asyncio.get_event_loop().run_in_executor(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/mv/.pyenv/versions/3.11.3/lib/python3.11/concurrent/futures/thread.py"", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/database.py"", line 211, in in_thread
    return fn(conn)
           ^^^^^^^^
  File ""/tester/.venv/lib/python3.11/site-packages/datasette/utils/__init__.py"", line 951, in check_connection
    for r in conn.execute(
             ^^^^^^^^^^^^^
sqlite3.OperationalError: unable to open database file
```

</details>


<details>
<summary>Works on 3.10.7, 3.10.6</summary>

```sh
# create new shell with 3.10.7 / 3.10.6
litestream restore -o data/db.sqlite s3://mytestbucketxx/db
datasette data/db.sqlite
# ...
# INFO:     Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit)
```

</details>

In both scenarios, the only dependencies were the pinned python version and the latest Datasette version 0.64.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2067/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1686042269,I_kwDOBm6k_c5kfvad,2066,Failing test: httpx.InvalidURL: URL too long,9599,closed,0,,,10,2023-04-27T03:48:47Z,2023-04-27T04:27:50Z,2023-04-27T04:27:50Z,OWNER,,"https://github.com/simonw/datasette/actions/runs/4815723640/jobs/8574667731
```
    def urlparse(url: str = """", **kwargs: typing.Optional[str]) -> ParseResult:
        # Initial basic checks on allowable URLs.
        # ---------------------------------------
    
        # Hard limit the maximum allowable URL length.
        if len(url) > MAX_URL_LENGTH:
>           raise InvalidURL(""URL too long"")
E           httpx.InvalidURL: URL too long

/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/httpx/_urlparse.py:155: InvalidURL
=========================== short test summary info ============================
FAILED tests/test_csv.py::test_max_csv_mb - httpx.InvalidURL: URL too long
```",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2066/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1686033652,I_kwDOBm6k_c5kftT0,2065,Datasette cannot be installed with Rye,9599,closed,0,,,4,2023-04-27T03:35:42Z,2023-04-27T05:09:36Z,2023-04-27T05:09:36Z,OWNER,,"https://github.com/mitsuhiko/rye

I tried this:

    rye install datasette

But now:

```
% ~/.rye/shims/datasette
Traceback (most recent call last):
  File ""/Users/simon/.rye/shims/datasette"", line 5, in <module>
    from datasette.cli import cli
  File ""/Users/simon/.rye/tools/datasette/lib/python3.11/site-packages/datasette/cli.py"", line 17, in <module>
    from .app import (
  File ""/Users/simon/.rye/tools/datasette/lib/python3.11/site-packages/datasette/app.py"", line 14, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
```
I think that's because `setuptools` is not included in Rye.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2065/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1683229834,PR_kwDOBm6k_c5PG0wF,2064,Bump sphinx from 6.1.3 to 6.2.1,49699333,closed,0,,,1,2023-04-25T13:57:49Z,2023-05-01T13:58:53Z,2023-05-01T13:58:52Z,CONTRIBUTOR,simonw/datasette/pulls/2064,"Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 6.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>v6.2.1</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
<h2>v6.2.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 6.2.1 (released Apr 25, 2023)</h1>
<h2>Bugs fixed</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11355"">#11355</a>: Revert the default type of :confval:<code>nitpick_ignore</code> and
:confval:<code>nitpick_ignore_regex</code> to <code>list</code>.</li>
</ul>
<h1>Release 6.2.0 (released Apr 23, 2023)</h1>
<h2>Dependencies</h2>
<ul>
<li>Require Docutils 0.18.1 or greater.</li>
</ul>
<h2>Incompatible changes</h2>
<ul>
<li>LaTeX: removal of some internal TeX <code>\dimen</code> registers (not previously
publicly documented) as per 5.1.0 code comments in <code>sphinx.sty</code>:
<code>\sphinxverbatimsep</code>, <code>\sphinxverbatimborder</code>, <code>\sphinxshadowsep</code>,
<code>\sphinxshadowsize</code>, and <code>\sphinxshadowrule</code>. (refs: <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11105"">#11105</a>)</li>
<li>Remove <code>.egg</code> support from pycode <code>ModuleAnalyser</code>; Python eggs are a
now-obsolete binary distribution format</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11089"">#11089</a>: Remove deprecated code in <code>sphinx.builders.linkcheck</code>.
Patch by Daniel Eades</li>
<li>Remove internal-only <code>sphinx.locale.setlocale</code></li>
</ul>
<h2>Deprecated</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11247"">#11247</a>: Deprecate the legacy <code>intersphinx_mapping</code> format</li>
<li><code>sphinx.util.osutil.cd</code> is deprecated in favour of <code>contextlib.chdir</code>.</li>
</ul>
<h2>Features added</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11277"">#11277</a>: :rst:dir:<code>autoproperty</code> allows the return type to be specified as
a type comment (e.g., <code># type: () -&gt; int</code>). Patch by Bénédikt Tran</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/10811"">#10811</a>: Autosummary: extend <code>__all__</code> to imported members for template rendering
when option <code>autosummary_ignore_module_all</code> is set to <code>False</code>. Patch by
Clement Pinard</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11147"">#11147</a>: Add a <code>content_offset</code> parameter to <code>nested_parse_with_titles()</code>,
allowing for correct line numbers during nested parsing.
Patch by Jeremy Maitin-Shepard</li>
<li>Update to Unicode CLDR 42</li>
<li>Add a <code>--jobs</code> synonym for <code>-j</code>. Patch by Hugo van Kemenade</li>
<li>LaTeX: a command <code>\sphinxbox</code> for styling text elements with a (possibly</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ec993dda3690f260345133c47a4a0f6ef0b18493""><code>ec993dd</code></a> Bump to 6.2.1 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/d2aa91f63ce2fa749e4d8835ea7b771ead29e54a""><code>d2aa91f</code></a> Revert the default type of <code>nitpick_ignore[_regex]</code> to <code>list</code></li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/60d8fa10b881308c97012d478fb13770a41b469f""><code>60d8fa1</code></a> Bump version</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/70102ac2ee4d89e1293d8efa7763dcdd104ad548""><code>70102ac</code></a> Bump to 6.2.0 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/4e27a5fba146bf85b6e2e0ba8b9f5ac30b1c1e29""><code>4e27a5f</code></a> Remove unneeded JavaScript from <code>sphinx13</code> theme</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/bffb54734f64e88c95b1d5558ec3fb7cb44ceda7""><code>bffb547</code></a> Note correct deprecation version for <code>sphinx.util.osutil.cd</code></li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/59de8d52029deca803d38b5d084a3a32c7b7f994""><code>59de8d5</code></a> Revert &quot;Support and prefer <code>.jinja</code> to <code>_t</code> for static templates (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11165"">#11165</a>)...</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/aee3c0ab75974790adf359a9c5089d1d781a6b21""><code>aee3c0a</code></a> Partially revert &quot;Disable localisation when SOURCE_DATE_EPOCH is set (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/10949"">#10949</a>)...</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/186d596f3323f3141c34618e2e788e5cdff8fec3""><code>186d596</code></a> Use <code>overwrite_file</code> context manager in <code>test_ext_autodoc_configs</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11320"">#11320</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/77483f28244dac1e7459d09397180812cfb36946""><code>77483f2</code></a> Add missing test decorator for <code>test_util_inspect</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11321"">#11321</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v6.2.1"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=6.1.3&new-version=6.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2064.org.readthedocs.build/en/2064/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2064/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1681339696,PR_kwDOBm6k_c5PAcGt,2063,Bump sphinx from 6.1.3 to 6.2.0,49699333,closed,0,,,1,2023-04-24T13:58:21Z,2023-04-25T13:57:55Z,2023-04-25T13:57:53Z,CONTRIBUTOR,simonw/datasette/pulls/2063,"Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 6.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>v6.2.0</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 6.2.0 (released Apr 23, 2023)</h1>
<h2>Dependencies</h2>
<ul>
<li>Require Docutils 0.18.1 or greater.</li>
</ul>
<h2>Incompatible changes</h2>
<ul>
<li>LaTeX: removal of some internal TeX <code>\dimen</code> registers (not previously
publicly documented) as per 5.1.0 code comments in <code>sphinx.sty</code>:
<code>\sphinxverbatimsep</code>, <code>\sphinxverbatimborder</code>, <code>\sphinxshadowsep</code>,
<code>\sphinxshadowsize</code>, and <code>\sphinxshadowrule</code>. (refs: <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11105"">#11105</a>)</li>
<li>Remove <code>.egg</code> support from pycode <code>ModuleAnalyser</code>; Python eggs are a
now-obsolete binary distribution format</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11089"">#11089</a>: Remove deprecated code in <code>sphinx.builders.linkcheck</code>.
Patch by Daniel Eades</li>
<li>Remove internal-only <code>sphinx.locale.setlocale</code></li>
</ul>
<h2>Deprecated</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11247"">#11247</a>: Deprecate the legacy <code>intersphinx_mapping</code> format</li>
<li><code>sphinx.util.osutil.cd</code> is deprecated in favour of <code>contextlib.chdir</code>.</li>
</ul>
<h2>Features added</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11277"">#11277</a>: :rst:dir:<code>autoproperty</code> allows the return type to be specified as
a type comment (e.g., <code># type: () -&gt; int</code>). Patch by Bénédikt Tran</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/10811"">#10811</a>: Autosummary: extend <code>__all__</code> to imported members for template rendering
when option <code>autosummary_ignore_module_all</code> is set to <code>False</code>. Patch by
Clement Pinard</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11147"">#11147</a>: Add a <code>content_offset</code> parameter to <code>nested_parse_with_titles()</code>,
allowing for correct line numbers during nested parsing.
Patch by Jeremy Maitin-Shepard</li>
<li>Update to Unicode CLDR 42</li>
<li>Add a <code>--jobs</code> synonym for <code>-j</code>. Patch by Hugo van Kemenade</li>
<li>LaTeX: a command <code>\sphinxbox</code> for styling text elements with a (possibly
rounded) box, optional background color and shadow, has been added.
See :ref:<code>sphinxbox</code>. (refs: <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11224"">#11224</a>)</li>
<li>LaTeX: add <code>\sphinxstylenotetitle</code>, ..., <code>\sphinxstylewarningtitle</code>, ...,
for an extra layer of mark-up freeing up <code>\sphinxstrong</code> for other uses.
See :ref:<code>latex-macros</code>. (refs: <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11267"">#11267</a>)</li>
<li>LaTeX: :dudir:<code>note</code>, :dudir:<code>hint</code>, :dudir:<code>important</code> and :dudir:<code>tip</code> can
now each be styled as the other admonitions, i.e. possibly with a background
color, individual border widths and paddings, possibly rounded corners, and
optional shadow.  See :ref:<code>additionalcss</code>. (refs: <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11234"">#11234</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/e7d4c3669cec32721ee7fc25d9cb8dc3497095ed""><code>e7d4c36</code></a> Bump to 6.2.0 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/4e27a5fba146bf85b6e2e0ba8b9f5ac30b1c1e29""><code>4e27a5f</code></a> Remove unneeded JavaScript from <code>sphinx13</code> theme</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/bffb54734f64e88c95b1d5558ec3fb7cb44ceda7""><code>bffb547</code></a> Note correct deprecation version for <code>sphinx.util.osutil.cd</code></li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/59de8d52029deca803d38b5d084a3a32c7b7f994""><code>59de8d5</code></a> Revert &quot;Support and prefer <code>.jinja</code> to <code>_t</code> for static templates (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11165"">#11165</a>)...</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/aee3c0ab75974790adf359a9c5089d1d781a6b21""><code>aee3c0a</code></a> Partially revert &quot;Disable localisation when SOURCE_DATE_EPOCH is set (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/10949"">#10949</a>)...</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/186d596f3323f3141c34618e2e788e5cdff8fec3""><code>186d596</code></a> Use <code>overwrite_file</code> context manager in <code>test_ext_autodoc_configs</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11320"">#11320</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/77483f28244dac1e7459d09397180812cfb36946""><code>77483f2</code></a> Add missing test decorator for <code>test_util_inspect</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11321"">#11321</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/d8f15c7361c4766667db65252b685f19d4a08b56""><code>d8f15c7</code></a> Increase timeout threshold for <code>linkcheck</code> tests (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11326"">#11326</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/b430e052858c490a4e90f3143f159ee6240eb948""><code>b430e05</code></a> Create a 'search field' component for themes (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11045"">#11045</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/e2f66cea4997b6d8c588d3509adb68d4e9108ee6""><code>e2f66ce</code></a> Update CHANGES for PR <a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11333"">#11333</a></li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v6.2.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=6.1.3&new-version=6.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2063.org.readthedocs.build/en/2063/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2063/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1674322631,PR_kwDOBm6k_c5OpEz_,2061,"Add ""Packaging a plugin using Poetry"" section in docs",1238873,open,0,,,0,2023-04-19T07:23:28Z,2023-04-19T07:27:18Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2061,"This PR adds a new section about packaging a plugin using `poetry` within the ""Writing plugins"" page of the documentation.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2061.org.readthedocs.build/en/2061/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2061/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1665510265,I_kwDOBm6k_c5jRat5,2060,Clean up a bunch of warnings from ruff,9599,open,0,,,0,2023-04-13T01:23:02Z,2023-04-13T01:23:02Z,,OWNER,,"See:
- #2056

`ruff` spots a bunch of warnings about things like unused variables - would be good to clean up as many of these as possible.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2060/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1665053646,I_kwDOBm6k_c5jPrPO,2059,"""Deceptive site ahead"" alert on Heroku deployment",1186275,open,0,,,1,2023-04-12T18:34:51Z,2023-04-13T01:13:01Z,,NONE,,"I deployed a fairly basic instance of Datasette (`datasette-auth-passwords` is the only plugin) using Heroku. The deployed URL now gives a ""Deceptive site ahead"" warning to users.

Is there way around this? Maybe a way to add ownership verification [through Google's search console](https://search.google.com/search-console/welcome)? ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2059/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1663399821,I_kwDOBm6k_c5jJXeN,2058,"500 ""attempt to write a readonly database"" error caused by ""PRAGMA schema_version""",9599,open,0,,,9,2023-04-11T23:57:50Z,2023-04-13T16:35:21Z,,OWNER,,"I've not been able to replicate this myself yet, but I've seen log files from a user affected by it.

```
File ""/usr/local/lib/python3.11/site-packages/datasette/views/base.py"", line 89, in dispatch_request
await self.ds.refresh_schemas()
File ""/usr/local/lib/python3.11/site-packages/datasette/app.py"", line 371, in refresh_schemas
await self._refresh_schemas()
File ""/usr/local/lib/python3.11/site-packages/datasette/app.py"", line 386, in _refresh_schemas
schema_version = (await db.execute(""PRAGMA schema_version"")).first()[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ""/usr/local/lib/python3.11/site-packages/datasette/database.py"", line 267, in execute
results = await self.execute_fn(sql_operation_in_thread)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ""/usr/local/lib/python3.11/site-packages/datasette/database.py"", line 213, in execute_fn
return await asyncio.get_event_loop().run_in_executor(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ""/usr/local/lib/python3.11/concurrent/futures/thread.py"", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ""/usr/local/lib/python3.11/site-packages/datasette/database.py"", line 211, in in_thread
return fn(conn)
^^^^^^^^
File ""/usr/local/lib/python3.11/site-packages/datasette/database.py"", line 237, in sql_operation_in_thread
cursor.execute(sql, params if params is not None else {})
sqlite3.OperationalError: attempt to write a readonly database
```
That's running the official Datasette Docker image on https://fly.io/ - it's causing 500 errors on every page of their site.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2058/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1662951875,I_kwDOBm6k_c5jHqHD,2057,DeprecationWarning: pkg_resources is deprecated as an API,9599,closed,0,,,25,2023-04-11T17:41:20Z,2023-09-21T22:09:10Z,2023-09-21T22:09:10Z,OWNER,,"Got this running tests against Python 3.11.

```
../../../.local/share/virtualenvs/datasette-big-local-6Yn-280V/lib/python3.11/site-packages/datasette/app.py:14: in <module>
    import pkg_resources
../../../.local/share/virtualenvs/datasette-big-local-6Yn-280V/lib/python3.11/site-packages/pkg_resources/__init__.py:121: in <module>
    warnings.warn(""pkg_resources is deprecated as an API"", DeprecationWarning)
E   DeprecationWarning: pkg_resources is deprecated as an API
```

I ran with `pytest -Werror --pdb -x` to get the debugger for that warning, but it turned out searching the code worked better. It's used in these two places:

https://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/datasette/plugins.py#L43-L50

https://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/datasette/app.py#L1037",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2057/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1661860507,PR_kwDOBm6k_c5N_bMw,2056,GitHub Action to lint Python code with ruff,3709715,open,0,,,6,2023-04-11T06:41:27Z,2023-04-15T14:24:46Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2056,"[Ruff](https://beta.ruff.rs/) supports [over 500 lint rules](https://beta.ruff.rs/docs/rules) and can be used to replace [Flake8](https://pypi.org/project/flake8/) (plus dozens of plugins), [isort](https://pypi.org/project/isort/), [pydocstyle](https://pypi.org/project/pydocstyle/), [yesqa](https://github.com/asottile/yesqa), [eradicate](https://pypi.org/project/eradicate/), [pyupgrade](https://pypi.org/project/pyupgrade/), and [autoflake](https://pypi.org/project/autoflake/), all while executing (in Rust) tens or hundreds of times faster than any individual tool.

The ruff Action uses minimal steps to run in ~5 seconds, rapidly providing intuitive GitHub Annotations to contributors.

![image](https://user-images.githubusercontent.com/3709715/223758136-afc386d2-70aa-4eff-953a-2c2d82ceea23.png)

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2056.org.readthedocs.build/en/2056/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2056/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1657861026,I_kwDOBm6k_c5i0POi,2054,"Make detailed notes on how table, query and row views work right now",9599,open,0,,,13,2023-04-06T18:21:09Z,2023-04-07T20:14:38Z,,OWNER,,"Research to help influence the following:
- #2049 
- #2053 
- #2050 
- #262 ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2054/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1656432059,PR_kwDOBm6k_c5NuBNG,2053,WIP new JSON for queries,9599,closed,0,,,12,2023-04-05T23:26:15Z,2023-07-26T18:28:59Z,2023-07-26T18:26:45Z,OWNER,simonw/datasette/pulls/2053,"Refs:
- #2049

TODO:

- [x] Read queries JSON
- Implement error display with `""ok"": false` and an errors key
- Read queries HTML
- Read queries other formats (plugins)
- Canned read queries (dispatched to from table)
- Write queries (a canned query thing)
- Implement different shapes, refactoring to share code with table
- Implement a sensible subset of extras, also refactoring to share code with table
- Get all tests passing

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2053.org.readthedocs.build/en/2053/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2053/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1,
1651082214,PR_kwDOBm6k_c5NcFCf,2052,"feat: Javascript Plugin API (Custom panels, column menu items with JS actions)",9020979,closed,0,9599,,20,2023-04-02T20:23:44Z,2023-10-14T17:49:03Z,2023-10-13T00:00:27Z,CONTRIBUTOR,simonw/datasette/pulls/2052,"## Motivation

- Allow plugins that add data visualizations [`datasette-vega`](https://github.com/simonw/datasette-vega), [`datasette-leaflet`](https://github.com/simonw/datasette-leaflet), and [`datasette-nteract-data-explorer`](https://github.com/hydrosquall/datasette-nteract-data-explorer) to co-exist safely
- Standardize APIs / hooks to ease development for new JS plugin developers (better compat with datasette-lite) through standardized DOM selectors, methods for extending the existing Table UI. This has come up as a feature request several times (see research notes for examples)
- Discussion w/ @simonw about a general-purpose Datasette JS API

## Changes

Summary: Provide 2 new surface areas for Datasette JS plugin developers. See alpha [documentation](https://github.com/simonw/datasette/pull/2052#issuecomment-1510423051)

1. Custom column header items: <https://a.cl.ly/Kou97wJr>
2. Basic ""panels"" controlled by buttons: <https://a.cl.ly/rRugWobd>

### User Facing Changes

- Allow creating menu items under table header that triggers JS (instead of opening hrefs per the existing [menu_link](https://docs.datasette.io/en/stable/plugin_hooks.html#menu-links-datasette-actor-request) hook). Items can respond to any column metadata provided by the column header (e.g. label). The proof of concept plugins log data to the console, or copy the column name to clipboard.
- Allow plugins to register UI elements in a panel controller. The parent component handles switching the visibility of active plugins.
  - Because native button elements are used, the panel is keyboard-accessible - use tab / shift-tab to cycle through tab options, and `enter` to select.
  - There's room to improve the styling, but the focus of this PR is on the API rather than the UX.

### (plugin) Developer Facing Changes

- Dispatch a `datasette_init` [CustomEvent](https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent) when the `datasetteManager` is finished loading.
- Provide `manager.registerPlugin` API for adding new functionality that coordinates with Datasette lifecycle events.
- Provide a `manager.selectors` map of DOM elements that users may want to hook into.
  - Updated `table.js` to use refer to these to motivating keeping things in sync
- Allow plugins to register themselves with 2 hooks:
  - `makeColumnActions`: Add items to menu in table column headers. Users can provide a `label`, and either `href` or `onClick` with full access to the metadata for the clicked column (name, type, misc. booleans)
  - `makeAboveTablePanelConfigs`: Add items to the panel. Each panel has a unique ID (namespaced within that plugin), a render function, and a string label.

See [this file](https://github.com/simonw/datasette/blob/2d92b9328022d86505261bcdac419b6ed9cb2236/datasette/static/table-example-plugins.js) for example plugin usage.

###  Core Developer Facing Changes

- Modified `table.js` to make use of the `datasetteManager` API.
- Added example plugins to the `demos/plugins` folder, and stored the test js in the `statics/` folder

## Testing

For Datasette plugin developers, please see the [alpha-level documentation](https://github.com/simonw/datasette/pull/2052#issuecomment-1510423051) .

To run the examples:

```bash
datasette serve fixtures.db  --plugins-dir=demos/plugins/
```

Open local server: `http://127.0.0.1:8001/fixtures/facetable`

Open to all feedback on this PR, from API design to variable naming, to what additional hooks might be useful for the future.

My focus was more on the general shape of the API for developers, rather than on the UX of the test plugins.

## Design notes

- The manager tab panel could be a separate plugin if the implementation is too custom.
- The `makeColumnHeaderItems` benefits from hooking into the logic of `table.js`
- I wanted to offer this to the Datasette core, since the `datasette-manager` would be more powerful if it were connected to lifecycle and JS events that are part of the existing table.js.
- Non-goals:
  - Dependency management (for now) - there's no ""build"" step, we don't know when new plugins will be added. While there are some valid use cases (for example, allow multiple plugins to wait for a global leaflet object to be loaded), I don't see enough use-cases to justify doing this yet.
  - Enabling single-page-app features - for now, most datasette actions lead to a new page being loaded. SPA development offers some benefits (no page jumping after clicking on a link), but also complexity that doesn't need to be in the core Datasette project.

## Research Notes

- Relocated to a [comment](https://github.com/simonw/datasette/pull/2052#issuecomment-1510423215), as this isn't required to review when evaluating the plugin. Including it just for those who are curious.
",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2052/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1649793525,I_kwDOBm6k_c5iVdn1,2051,`?_extra=row_urls` for table pages,9599,open,0,,,0,2023-03-31T17:58:36Z,2023-03-31T17:58:36Z,,OWNER,,Provides URLs to the JSON version of those rows. Maybe it persists the `?_shape=` option too? Not sure about that.,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2051/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1649791661,I_kwDOBm6k_c5iVdKt,2050,Row page JSON should use new ?_extra= format,9599,open,0,,8755003,1,2023-03-31T17:56:53Z,2023-03-31T17:59:49Z,,OWNER,,"https://latest.datasette.io/fixtures/facetable/2.json

Related:
- #2049
- #1709 ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2050/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1646734246,I_kwDOBm6k_c5iJyum,2049,Custom SQL queries should use new JSON ?_extra= format,9599,open,0,,8755003,4,2023-03-30T00:42:53Z,2023-04-05T23:29:27Z,,OWNER,,"Related:
- #262

I've made the change to the table view, now I need the new format to work for arbitrary SQL queries too.

Note that this incorporates both arbitrary SQL queries and canned queries.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2049/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1646068413,I_kwDOBm6k_c5iHQK9,2048,Test failures encountered while packaging for GNU Guix,8332263,open,0,,,0,2023-03-29T15:36:54Z,2023-03-29T15:36:54Z,,NONE,,"Hello,

While reviewing a packaged submitted to Guix to add `datasette`, the test suite produces the following errors:
```
=================================== FAILURES ===================================
_________________________ test_row_strange_table_name __________________________
[gw21] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffef099be0>

    def test_row_strange_table_name(app_client):
        response = app_client.get(
            ""/fixtures/table~2Fwith~2Fslashes~2Ecsv/3.json?_shape=objects""
        )
>       assert response.status == 200
E       assert 400 == 200
E        +  where 400 = <datasette.utils.testing.TestResponse object at 0x7fffef236a30>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:701: AssertionError
----------------------------- Captured stderr call -----------------------------
ERROR: conn=<sqlite3.Connection object at 0x7fffeedfe5d0>, sql = 'select rowid, * from [table%7E2Fwith%7E2Fslashes%7E2Ecsv] where ""rowid""=:p0', params = {'p0': '3'}: no such table: table%7E2Fwith%7E2Fslashes%7E2Ecsv
_______________ test_database_page_for_database_with_dot_in_name _______________
[gw15] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_with_dot = <datasette.utils.testing.TestClient object at 0x7fffef3416a0>

    def test_database_page_for_database_with_dot_in_name(app_client_with_dot):
        response = app_client_with_dot.get(""/fixtures~2Edot.json"")
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffef089fa0>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:633: AssertionError
___________________ test_tilde_encoded_database_names[fo%o] ____________________
[gw6] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

db_name = 'fo%o'

    @pytest.mark.asyncio
    @pytest.mark.parametrize(""db_name"", (""foo"", r""fo%o"", ""f~/c.d""))
    async def test_tilde_encoded_database_names(db_name):
        ds = Datasette()
        ds.add_memory_database(db_name)
        response = await ds.client.get(""/.json"")
        assert db_name in response.json().keys()
        path = response.json()[db_name][""path""]
        # And the JSON for that database
        response2 = await ds.client.get(path + "".json"")
>       assert response2.status_code == 200
E       assert 302 == 200
E        +  where 302 = <Response [302 Found]>.status_code

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:983: AssertionError
__________________ test_tilde_encoded_database_names[f~/c.d] ___________________
[gw7] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

db_name = 'f~/c.d'

    @pytest.mark.asyncio
    @pytest.mark.parametrize(""db_name"", (""foo"", r""fo%o"", ""f~/c.d""))
    async def test_tilde_encoded_database_names(db_name):
        ds = Datasette()
        ds.add_memory_database(db_name)
        response = await ds.client.get(""/.json"")
        assert db_name in response.json().keys()
        path = response.json()[db_name][""path""]
        # And the JSON for that database
        response2 = await ds.client.get(path + "".json"")
>       assert response2.status_code == 200
E       assert 302 == 200
E        +  where 302 = <Response [302 Found]>.status_code

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:983: AssertionError
______________ test_database_with_space_in_name[/searchable.json] ______________
[gw21] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffef11d730>
path = '/searchable.json'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffef11d940>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database/searchable%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E2Ejson')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
___________________ test_database_with_space_in_name[.json] ____________________
[gw19] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffef085a90>
path = '.json'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffecd99ca0>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E2Ejson')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
______________ test_database_with_space_in_name[/searchable_view] ______________
[gw22] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffeeab4c70>
path = '/searchable_view'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffec5b3580>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database/searchable_view')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
_____________________ test_database_with_space_in_name[/] ______________________
[gw18] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffef085be0>
path = '/'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffec5f1370>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database/')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
________________ test_database_with_space_in_name[/searchable] _________________
[gw20] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffef099f10>
path = '/searchable'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffecd8c790>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database/searchable')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
___________ test_database_with_space_in_name[/searchable_view.json] ____________
[gw23] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client_two_attached_databases = <datasette.utils.testing.TestClient object at 0x7fffef341520>
path = '/searchable_view.json'

    @pytest.mark.parametrize(
        ""path"",
        (
            ""/"",
            "".json"",
            ""/searchable"",
            ""/searchable.json"",
            ""/searchable_view"",
            ""/searchable_view.json"",
        ),
    )
    def test_database_with_space_in_name(app_client_two_attached_databases, path):
>       response = app_client_two_attached_databases.get(
            ""/extra~20database"" + path, follow_redirects=True
        )

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_api.py:920: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:223: in __call__
    return call_result.result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:438: in result
    return self.__get_result()
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/concurrent/futures/_base.py:390: in __get_result
    raise self._exception
/gnu/store/mcclmphjgbrgpa0v037a4nlq336482g8-python-asgiref-3.4.1/lib/python3.9/site-packages/asgiref/sync.py:292: in main_wrap
    result = await self.awaitable(*args, **kwargs)
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:66: in get
    return await self._request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:156: in _request
    httpx_response = await self.ds.client.request(
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/app.py:1602: in request
    return await client.request(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1527: in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1614: in send
    response = await self._send_handling_auth(
/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1642: in _send_handling_auth
    response = await self._send_handling_redirects(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <httpx.AsyncClient object at 0x7fffef085460>
request = <Request('GET', 'http://localhost/extra%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E20database/searchable_view%7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E7E2Ejson')>
follow_redirects = True
history = [<Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, <Response [302 Found]>, ...]

    async def _send_handling_redirects(
        self,
        request: Request,
        follow_redirects: bool,
        history: typing.List[Response],
    ) -> Response:
        while True:
            if len(history) > self.max_redirects:
>               raise TooManyRedirects(
                    ""Exceeded maximum allowed redirects."", request=request
                )
E               httpx.TooManyRedirects: Exceeded maximum allowed redirects.

/gnu/store/bj5lb299rfb4cbbq5kczq9imdk9a7y64-python-httpx-0.23.0/lib/python3.9/site-packages/httpx/_client.py:1672: TooManyRedirects
________________ test_weird_database_names[database (1).sqlite] ________________
[gw7] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

tmpdir = local('/tmp/guix-build-datasette-0.64.2.drv-0/pytest-of-nixbld/pytest-0/popen-gw7/test_weird_database_names_data0')
filename = 'database (1).sqlite'

    @pytest.mark.parametrize(
        ""filename"", [""test-database (1).sqlite"", ""database (1).sqlite""]
    )
    def test_weird_database_names(tmpdir, filename):
        # https://github.com/simonw/datasette/issues/1181
        runner = CliRunner()
        db_path = str(tmpdir / filename)
        sqlite3.connect(db_path).execute(""vacuum"")
        result1 = runner.invoke(cli, [db_path, ""--get"", ""/""])
        assert result1.exit_code == 0, result1.output
        filename_no_stem = filename.rsplit(""."", 1)[0]
        expected_link = '<a href=""/{}"">{}</a>'.format(
            tilde_encode(filename_no_stem), filename_no_stem
        )
        assert expected_link in result1.output
        # Now try hitting that database page
        result2 = runner.invoke(
            cli, [db_path, ""--get"", ""/{}"".format(tilde_encode(filename_no_stem))]
        )
>       assert result2.exit_code == 0, result2.output
E       AssertionError: 
E         
E       assert 1 == 0
E        +  where 1 = <Result SystemExit(1)>.exit_code

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_cli.py:321: AssertionError
_____________ test_weird_database_names[test-database (1).sqlite] ______________
[gw6] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

tmpdir = local('/tmp/guix-build-datasette-0.64.2.drv-0/pytest-of-nixbld/pytest-0/popen-gw6/test_weird_database_names_test0')
filename = 'test-database (1).sqlite'

    @pytest.mark.parametrize(
        ""filename"", [""test-database (1).sqlite"", ""database (1).sqlite""]
    )
    def test_weird_database_names(tmpdir, filename):
        # https://github.com/simonw/datasette/issues/1181
        runner = CliRunner()
        db_path = str(tmpdir / filename)
        sqlite3.connect(db_path).execute(""vacuum"")
        result1 = runner.invoke(cli, [db_path, ""--get"", ""/""])
        assert result1.exit_code == 0, result1.output
        filename_no_stem = filename.rsplit(""."", 1)[0]
        expected_link = '<a href=""/{}"">{}</a>'.format(
            tilde_encode(filename_no_stem), filename_no_stem
        )
        assert expected_link in result1.output
        # Now try hitting that database page
        result2 = runner.invoke(
            cli, [db_path, ""--get"", ""/{}"".format(tilde_encode(filename_no_stem))]
        )
>       assert result2.exit_code == 0, result2.output
E       AssertionError: 
E         
E       assert 1 == 0
E        +  where 1 = <Result SystemExit(1)>.exit_code

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_cli.py:321: AssertionError
_ test_row_html_compound_primary_key[/fixtures/compound_primary_key/a~2Fb,~2Ec~2Dd-expected1] _
[gw11] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffec2d37f0>
path = '/fixtures/compound_primary_key/a~2Fb,~2Ec~2Dd'
expected = [['<td class=""col-pk1 type-str"">a/b</td>', '<td class=""col-pk2 type-str"">.c-d</td>', '<td class=""col-content type-str"">c</td>']]

    @pytest.mark.parametrize(
        ""path,expected"",
        (
            (
                ""/fixtures/compound_primary_key/a,b"",
                [
                    [
                        '<td class=""col-pk1 type-str"">a</td>',
                        '<td class=""col-pk2 type-str"">b</td>',
                        '<td class=""col-content type-str"">c</td>',
                    ]
                ],
            ),
            (
                ""/fixtures/compound_primary_key/a~2Fb,~2Ec~2Dd"",
                [
                    [
                        '<td class=""col-pk1 type-str"">a/b</td>',
                        '<td class=""col-pk2 type-str"">.c-d</td>',
                        '<td class=""col-content type-str"">c</td>',
                    ]
                ],
            ),
        ),
    )
    def test_row_html_compound_primary_key(app_client, path, expected):
        response = app_client.get(path)
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffd47c23a0>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_html.py:370: AssertionError
_ test_css_classes_on_body[/fixtures/table~2Fwith~2Fslashes~2Ecsv-expected_classes5] _
[gw3] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffd4743fa0>
path = '/fixtures/table~2Fwith~2Fslashes~2Ecsv'
expected_classes = ['table', 'db-fixtures', 'table-tablewithslashescsv-fa7563']

    @pytest.mark.parametrize(
        ""path,expected_classes"",
        [
            (""/"", [""index""]),
            (""/fixtures"", [""db"", ""db-fixtures""]),
            (""/fixtures?sql=select+1"", [""query"", ""db-fixtures""]),
            (
                ""/fixtures/simple_primary_key"",
                [""table"", ""db-fixtures"", ""table-simple_primary_key""],
            ),
            (
                ""/fixtures/neighborhood_search"",
                [""query"", ""db-fixtures"", ""query-neighborhood_search""],
            ),
            (
                ""/fixtures/table~2Fwith~2Fslashes~2Ecsv"",
                [""table"", ""db-fixtures"", ""table-tablewithslashescsv-fa7563""],
            ),
            (
                ""/fixtures/simple_primary_key/1"",
                [""row"", ""db-fixtures"", ""table-simple_primary_key""],
            ),
        ],
    )
    def test_css_classes_on_body(app_client, path, expected_classes):
        response = app_client.get(path)
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffd4628dc0>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_html.py:238: AssertionError
_ test_templates_considered[/fixtures/table~2Fwith~2Fslashes~2Ecsv-table-fixtures-tablewithslashescsv-fa7563.html, *table.html] _
[gw3] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffd4743fa0>
path = '/fixtures/table~2Fwith~2Fslashes~2Ecsv'
expected_considered = 'table-fixtures-tablewithslashescsv-fa7563.html, *table.html'

    @pytest.mark.parametrize(
        ""path,expected_considered"",
        [
            (""/"", ""*index.html""),
            (""/fixtures"", ""database-fixtures.html, *database.html""),
            (
                ""/fixtures/simple_primary_key"",
                ""table-fixtures-simple_primary_key.html, *table.html"",
            ),
            (
                ""/fixtures/table~2Fwith~2Fslashes~2Ecsv"",
                ""table-fixtures-tablewithslashescsv-fa7563.html, *table.html"",
            ),
            (
                ""/fixtures/simple_primary_key/1"",
                ""row-fixtures-simple_primary_key.html, *row.html"",
            ),
        ],
    )
    def test_templates_considered(app_client, path, expected_considered):
        response = app_client.get(path)
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffd44f2d60>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_html.py:264: AssertionError
_ test_alternate_url_json[/fixtures/table~2Fwith~2Fslashes~2Ecsv-http://localhost/fixtures/table~2Fwith~2Fslashes~2Ecsv.json] _
[gw21] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffecd9fac0>
path = '/fixtures/table~2Fwith~2Fslashes~2Ecsv'
expected = 'http://localhost/fixtures/table~2Fwith~2Fslashes~2Ecsv.json'

    @pytest.mark.parametrize(
        ""path,expected"",
        (
            # Instance index page
            (""/"", ""http://localhost/.json""),
            # Table page
            (""/fixtures/facetable"", ""http://localhost/fixtures/facetable.json""),
            (
                ""/fixtures/table~2Fwith~2Fslashes~2Ecsv"",
                ""http://localhost/fixtures/table~2Fwith~2Fslashes~2Ecsv.json"",
            ),
            # Row page
            (
                ""/fixtures/no_primary_key/1"",
                ""http://localhost/fixtures/no_primary_key/1.json"",
            ),
            # Database index page
            (
                ""/fixtures"",
                ""http://localhost/fixtures.json"",
            ),
            # Custom query page
            (
                ""/fixtures?sql=select+*+from+facetable"",
                ""http://localhost/fixtures.json?sql=select+*+from+facetable"",
            ),
            # Canned query page
            (
                ""/fixtures/neighborhood_search?text=town"",
                ""http://localhost/fixtures/neighborhood_search.json?text=town"",
            ),
            # /-/ pages
            (
                ""/-/plugins"",
                ""http://localhost/-/plugins.json"",
            ),
        ),
    )
    def test_alternate_url_json(app_client, path, expected):
        response = app_client.get(path)
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffd4650b80>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_html.py:948: AssertionError
_ test_edit_sql_link_on_canned_queries[/fixtures/~F0~9D~90~9C~F0~9D~90~A2~F0~9D~90~AD~F0~9D~90~A2~F0~9D~90~9E~F0~9D~90~AC-/fixtures?sql=select+id%2C+name+from+facet_cities+order+by+id+limit+1%3B] _
[gw18] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffec5952e0>
path = '/fixtures/~F0~9D~90~9C~F0~9D~90~A2~F0~9D~90~AD~F0~9D~90~A2~F0~9D~90~9E~F0~9D~90~AC'
expected = '/fixtures?sql=select+id%2C+name+from+facet_cities+order+by+id+limit+1%3B'

    @pytest.mark.parametrize(
        ""path,expected"",
        [
            (
                ""/fixtures/neighborhood_search"",
                ""/fixtures?sql=%0Aselect+_neighborhood%2C+facet_cities.name%2C+state%0Afrom+facetable%0A++++join+facet_cities%0A++++++++on+facetable._city_id+%3D+facet_cities.id%0Awhere+_neighborhood+like+%27%25%27+%7C%7C+%3Atext+%7C%7C+%27%25%27%0Aorder+by+_neighborhood%3B%0A&amp;text="",
            ),
            (
                ""/fixtures/neighborhood_search?text=ber"",
                ""/fixtures?sql=%0Aselect+_neighborhood%2C+facet_cities.name%2C+state%0Afrom+facetable%0A++++join+facet_cities%0A++++++++on+facetable._city_id+%3D+facet_cities.id%0Awhere+_neighborhood+like+%27%25%27+%7C%7C+%3Atext+%7C%7C+%27%25%27%0Aorder+by+_neighborhood%3B%0A&amp;text=ber"",
            ),
            (""/fixtures/pragma_cache_size"", None),
            (
                # /fixtures/𝐜𝐢𝐭𝐢𝐞𝐬
                ""/fixtures/~F0~9D~90~9C~F0~9D~90~A2~F0~9D~90~AD~F0~9D~90~A2~F0~9D~90~9E~F0~9D~90~AC"",
                ""/fixtures?sql=select+id%2C+name+from+facet_cities+order+by+id+limit+1%3B"",
            ),
            (""/fixtures/magic_parameters"", None),
        ],
    )
    def test_edit_sql_link_on_canned_queries(app_client, path, expected):
        response = app_client.get(path)
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffec4a6f70>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_html.py:841: AssertionError
_______________________ test_table_with_slashes_in_name ________________________
[gw9] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffec0860a0>

    def test_table_with_slashes_in_name(app_client):
        response = app_client.get(
            ""/fixtures/table~2Fwith~2Fslashes~2Ecsv.json?_shape=objects""
        )
>       assert response.status == 200
E       assert 302 == 200
E        +  where 302 = <datasette.utils.testing.TestResponse object at 0x7fffec086fa0>.status

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_table_api.py:141: AssertionError
__________________ test_custom_query_with_unicode_characters ___________________
[gw8] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffec1cda90>

    def test_custom_query_with_unicode_characters(app_client):
        # /fixtures/𝐜𝐢𝐭𝐢𝐞𝐬.json
        response = app_client.get(
            ""/fixtures/~F0~9D~90~9C~F0~9D~90~A2~F0~9D~90~AD~F0~9D~90~A2~F0~9D~90~9E~F0~9D~90~AC.json?_shape=array""
        )
>       assert [{""id"": 1, ""name"": ""San Francisco""}] == response.json

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_table_api.py:1042: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/tmp/guix-build-datasette-0.64.2.drv-0/source/datasette/utils/testing.py:40: in json
    return json.loads(self.text)
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/json/__init__.py:346: in loads
    return _default_decoder.decode(s)
/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/json/decoder.py:337: in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <json.decoder.JSONDecoder object at 0x7ffff7479760>, s = '', idx = 0

    def raw_decode(self, s, idx=0):
        """"""Decode a JSON document from ``s`` (a ``str`` beginning with
        a JSON document) and return a 2-tuple of the Python
        representation and the index in ``s`` where the document ended.
    
        This can be used to decode a JSON document from a string that may
        have extraneous data at the end.
    
        """"""
        try:
            obj, end = self.scan_once(s, idx)
        except StopIteration as err:
>           raise JSONDecodeError(""Expecting value"", s, err.value) from None
E           json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/json/decoder.py:355: JSONDecodeError
_ test_searchable[/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw-expected_rows3] _
[gw13] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

app_client = <datasette.utils.testing.TestClient object at 0x7fffd470bf10>
path = '/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw'
expected_rows = [[1, 'barry cat', 'terry dog', 'panther'], [2, 'terry dog', 'sara weasel', 'puma']]

    @pytest.mark.parametrize(
        ""path,expected_rows"",
        [
            (
                ""/fixtures/searchable.json?_search=dog"",
                [
                    [1, ""barry cat"", ""terry dog"", ""panther""],
                    [2, ""terry dog"", ""sara weasel"", ""puma""],
                ],
            ),
            (
                # Special keyword shouldn't break FTS query
                ""/fixtures/searchable.json?_search=AND"",
                [],
            ),
            (
                # Without _searchmode=raw this should return no results
                ""/fixtures/searchable.json?_search=te*+AND+do*"",
                [],
            ),
            (
                # _searchmode=raw
                ""/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw"",
                [
                    [1, ""barry cat"", ""terry dog"", ""panther""],
                    [2, ""terry dog"", ""sara weasel"", ""puma""],
                ],
            ),
            (
                # _searchmode=raw combined with _search_COLUMN
                ""/fixtures/searchable.json?_search_text2=te*&_searchmode=raw"",
                [
                    [1, ""barry cat"", ""terry dog"", ""panther""],
                ],
            ),
            (
                ""/fixtures/searchable.json?_search=weasel"",
                [[2, ""terry dog"", ""sara weasel"", ""puma""]],
            ),
            (
                ""/fixtures/searchable.json?_search_text2=dog"",
                [[1, ""barry cat"", ""terry dog"", ""panther""]],
            ),
            (
                ""/fixtures/searchable.json?_search_name%20with%20.%20and%20spaces=panther"",
                [[1, ""barry cat"", ""terry dog"", ""panther""]],
            ),
        ],
    )
    def test_searchable(app_client, path, expected_rows):
        response = app_client.get(path)
>       assert expected_rows == response.json[""rows""]
E       AssertionError: assert [[1, 'barry cat', 'terry dog', 'panther'],\n [2, 'terry dog', 'sara weasel', 'puma']] == []
E         Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther']
E         Full diff:
E           [
E         -  ,
E         +  [1,
E         +   'barry cat',
E         +   'terry dog',
E         +   'panther'],
E         +  [2,
E         +   'terry dog',
E         +   'sara weasel',
E         +   'puma'],
E           ]

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_table_api.py:402: AssertionError
_____ test_searchmode[table_metadata1-_search=te*+AND+do*-expected_rows1] ______
[gw20] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

table_metadata = {'searchmode': 'raw'}, querystring = '_search=te*+AND+do*'
expected_rows = [[1, 'barry cat', 'terry dog', 'panther'], [2, 'terry dog', 'sara weasel', 'puma']]

    @pytest.mark.parametrize(
        ""table_metadata,querystring,expected_rows"",
        [
            (
                {},
                ""_search=te*+AND+do*"",
                [],
            ),
            (
                {""searchmode"": ""raw""},
                ""_search=te*+AND+do*"",
                _SEARCHMODE_RAW_RESULTS,
            ),
            (
                {},
                ""_search=te*+AND+do*&_searchmode=raw"",
                _SEARCHMODE_RAW_RESULTS,
            ),
            # Can be over-ridden with _searchmode=escaped
            (
                {""searchmode"": ""raw""},
                ""_search=te*+AND+do*&_searchmode=escaped"",
                [],
            ),
        ],
    )
    def test_searchmode(table_metadata, querystring, expected_rows):
        with make_app_client(
            metadata={""databases"": {""fixtures"": {""tables"": {""searchable"": table_metadata}}}}
        ) as client:
            response = client.get(""/fixtures/searchable.json?"" + querystring)
>           assert expected_rows == response.json[""rows""]
E           AssertionError: assert [[1, 'barry cat', 'terry dog', 'panther'],\n [2, 'terry dog', 'sara weasel', 'puma']] == []
E             Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther']
E             Full diff:
E               [
E             -  ,
E             +  [1,
E             +   'barry cat',
E             +   'terry dog',
E             +   'panther'],
E             +  [2,
E             +   'terry dog',
E             +   'sara weasel',
E             +   'puma'],
E               ]

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_table_api.py:442: AssertionError
_ test_searchmode[table_metadata2-_search=te*+AND+do*&_searchmode=raw-expected_rows2] _
[gw20] linux -- Python 3.9.9 /gnu/store/slsh0qjv5j68xda2bb6h8gsxwyi1j25a-python-wrapper-3.9.9/bin/python

table_metadata = {}, querystring = '_search=te*+AND+do*&_searchmode=raw'
expected_rows = [[1, 'barry cat', 'terry dog', 'panther'], [2, 'terry dog', 'sara weasel', 'puma']]

    @pytest.mark.parametrize(
        ""table_metadata,querystring,expected_rows"",
        [
            (
                {},
                ""_search=te*+AND+do*"",
                [],
            ),
            (
                {""searchmode"": ""raw""},
                ""_search=te*+AND+do*"",
                _SEARCHMODE_RAW_RESULTS,
            ),
            (
                {},
                ""_search=te*+AND+do*&_searchmode=raw"",
                _SEARCHMODE_RAW_RESULTS,
            ),
            # Can be over-ridden with _searchmode=escaped
            (
                {""searchmode"": ""raw""},
                ""_search=te*+AND+do*&_searchmode=escaped"",
                [],
            ),
        ],
    )
    def test_searchmode(table_metadata, querystring, expected_rows):
        with make_app_client(
            metadata={""databases"": {""fixtures"": {""tables"": {""searchable"": table_metadata}}}}
        ) as client:
            response = client.get(""/fixtures/searchable.json?"" + querystring)
>           assert expected_rows == response.json[""rows""]
E           AssertionError: assert [[1, 'barry cat', 'terry dog', 'panther'],\n [2, 'terry dog', 'sara weasel', 'puma']] == []
E             Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther']
E             Full diff:
E               [
E             -  ,
E             +  [1,
E             +   'barry cat',
E             +   'terry dog',
E             +   'panther'],
E             +  [2,
E             +   'terry dog',
E             +   'sara weasel',
E             +   'puma'],
E               ]

/tmp/guix-build-datasette-0.64.2.drv-0/source/tests/test_table_api.py:442: AssertionError
=========================== short test summary info ============================
FAILED tests/test_api.py::test_row_strange_table_name - assert 400 == 200
FAILED tests/test_api.py::test_database_page_for_database_with_dot_in_name - ...
FAILED tests/test_api.py::test_tilde_encoded_database_names[fo%o] - assert 30...
FAILED tests/test_api.py::test_tilde_encoded_database_names[f~/c.d] - assert ...
FAILED tests/test_api.py::test_database_with_space_in_name[/searchable.json]
FAILED tests/test_api.py::test_database_with_space_in_name[.json] - httpx.Too...
FAILED tests/test_api.py::test_database_with_space_in_name[/searchable_view]
FAILED tests/test_api.py::test_database_with_space_in_name[/] - httpx.TooMany...
FAILED tests/test_api.py::test_database_with_space_in_name[/searchable] - htt...
FAILED tests/test_api.py::test_database_with_space_in_name[/searchable_view.json]
FAILED tests/test_cli.py::test_weird_database_names[database (1).sqlite] - As...
FAILED tests/test_cli.py::test_weird_database_names[test-database (1).sqlite]
FAILED tests/test_html.py::test_row_html_compound_primary_key[/fixtures/compound_primary_key/a~2Fb,~2Ec~2Dd-expected1]
FAILED tests/test_html.py::test_css_classes_on_body[/fixtures/table~2Fwith~2Fslashes~2Ecsv-expected_classes5]
FAILED tests/test_html.py::test_templates_considered[/fixtures/table~2Fwith~2Fslashes~2Ecsv-table-fixtures-tablewithslashescsv-fa7563.html, *table.html]
FAILED tests/test_html.py::test_alternate_url_json[/fixtures/table~2Fwith~2Fslashes~2Ecsv-http://localhost/fixtures/table~2Fwith~2Fslashes~2Ecsv.json]
FAILED tests/test_html.py::test_edit_sql_link_on_canned_queries[/fixtures/~F0~9D~90~9C~F0~9D~90~A2~F0~9D~90~AD~F0~9D~90~A2~F0~9D~90~9E~F0~9D~90~AC-/fixtures?sql=select+id%2C+name+from+facet_cities+order+by+id+limit+1%3B]
FAILED tests/test_table_api.py::test_table_with_slashes_in_name - assert 302 ...
FAILED tests/test_table_api.py::test_custom_query_with_unicode_characters - j...
FAILED tests/test_table_api.py::test_searchable[/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw-expected_rows3]
FAILED tests/test_table_api.py::test_searchmode[table_metadata1-_search=te*+AND+do*-expected_rows1]
FAILED tests/test_table_api.py::test_searchmode[table_metadata2-_search=te*+AND+do*&_searchmode=raw-expected_rows2]
=========== 22 failed, 1049 passed, 3 skipped in 1522.28s (0:25:22) ============
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: ""/gnu/store/ziqwkzz6znb5d3c245xn0cq5ra2ly0w3-python-pytest-7.1.3/bin/pytest"" arguments: (""-vv"" ""-n"" ""24"" ""-m"" ""not serial"") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `check' failed after 1523.3 seconds
```
The tests run in a private namespace without internet connectivity, and the Python dependencies are at:
```
python-aiofiles@0.6.0 python-asgi-csrf@0.9 python-asgiref@3.4.1
+ python-beautifulsoup4@4.11.1 python-black@22.3.0 python-click-default-group@1.2.2 python-click@8.1.3
+ python-cogapp@3.3.0 python-httpx@0.23.0 python-hupper@1.10.3 python-itsdangerous@2.0.1
+ python-janus@1.0.0 python-jinja2@3.1.1 python-mergedeep@1.3.4 python-pint@0.20.1 python-pluggy@1.0.0
+ python-pytest-asyncio@0.17.2 python-pytest-runner@5.2 python-pytest-timeout@2.0.2
+ python-pytest-xdist@2.5.0 python-pytest@7.1.3 python-pyyaml@6.0 python-setuptools@64.0.3
+ python-trustme@0.9.0 python-uvicorn@0.17.6
```
With Python 3.9.9.

Thank you!",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2048/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1645098678,PR_kwDOBm6k_c5NIQri,2047,Bump black from 22.12.0 to 23.3.0,49699333,closed,0,,,0,2023-03-29T06:09:06Z,2023-03-29T06:12:21Z,2023-03-29T06:12:05Z,CONTRIBUTOR,simonw/datasette/pulls/2047,"Bumps [black](https://github.com/psf/black) from 22.12.0 to 23.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/releases"">black's releases</a>.</em></p>
<blockquote>
<h2>23.3.0</h2>
<h3>Highlights</h3>
<p>This release fixes a longstanding confusing behavior in Black's GitHub action, where the
version of the action did not determine the version of Black being run (issue <a href=""https://redirect.github.com/psf/black/issues/3382"">#3382</a>). In
addition, there is a small bug fix around imports and a number of improvements to the
preview style.</p>
<p>Please try out the
<a href=""https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#preview-style"">preview style</a>
with <code>black --preview</code> and tell us your feedback. All changes in the preview style are
expected to become part of Black's stable style in January 2024.</p>
<h3>Stable style</h3>
<ul>
<li>Import lines with <code># fmt: skip</code> and <code># fmt: off</code> no longer have an extra blank line
added when they are right after another import line (<a href=""https://redirect.github.com/psf/black/issues/3610"">#3610</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Add trailing commas to collection literals even if there's a comment after the last
entry (<a href=""https://redirect.github.com/psf/black/issues/3393"">#3393</a>)</li>
<li><code>async def</code>, <code>async for</code>, and <code>async with</code> statements are now formatted consistently
compared to their non-async version. (<a href=""https://redirect.github.com/psf/black/issues/3609"">#3609</a>)</li>
<li><code>with</code> statements that contain two context managers will be consistently wrapped in
parentheses (<a href=""https://redirect.github.com/psf/black/issues/3589"">#3589</a>)</li>
<li>Let string splitters respect <a href=""https://www.unicode.org/reports/tr11/"">East Asian Width</a>
(<a href=""https://redirect.github.com/psf/black/issues/3445"">#3445</a>)</li>
<li>Now long string literals can be split after East Asian commas and periods (<code>、</code> U+3001
IDEOGRAPHIC COMMA, <code>。</code> U+3002 IDEOGRAPHIC FULL STOP, &amp; <code>，</code> U+FF0C FULLWIDTH COMMA)
besides before spaces (<a href=""https://redirect.github.com/psf/black/issues/3445"">#3445</a>)</li>
<li>For stubs, enforce one blank line after a nested class with a body other than just
<code>...</code> (<a href=""https://redirect.github.com/psf/black/issues/3564"">#3564</a>)</li>
<li>Improve handling of multiline strings by changing line split behavior (<a href=""https://redirect.github.com/psf/black/issues/1879"">#1879</a>)</li>
</ul>
<h3>Parser</h3>
<ul>
<li>Added support for formatting files with invalid type comments (<a href=""https://redirect.github.com/psf/black/issues/3594"">#3594</a>)</li>
</ul>
<h3>Integrations</h3>
<ul>
<li>Update GitHub Action to use the version of Black equivalent to action's version if
version input is not specified (<a href=""https://redirect.github.com/psf/black/issues/3543"">#3543</a>)</li>
<li>Fix missing Python binary path in autoload script for vim (<a href=""https://redirect.github.com/psf/black/issues/3508"">#3508</a>)</li>
</ul>
<h3>Documentation</h3>
<ul>
<li>Document that only the most recent release is supported for security issues;
vulnerabilities should be reported through Tidelift (<a href=""https://redirect.github.com/psf/black/issues/3612"">#3612</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/blob/main/CHANGES.md"">black's changelog</a>.</em></p>
<blockquote>
<h2>23.3.0</h2>
<h3>Highlights</h3>
<p>This release fixes a longstanding confusing behavior in Black's GitHub action, where the
version of the action did not determine the version of Black being run (issue <a href=""https://redirect.github.com/psf/black/issues/3382"">#3382</a>). In
addition, there is a small bug fix around imports and a number of improvements to the
preview style.</p>
<p>Please try out the
<a href=""https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#preview-style"">preview style</a>
with <code>black --preview</code> and tell us your feedback. All changes in the preview style are
expected to become part of Black's stable style in January 2024.</p>
<h3>Stable style</h3>
<ul>
<li>Import lines with <code># fmt: skip</code> and <code># fmt: off</code> no longer have an extra blank line
added when they are right after another import line (<a href=""https://redirect.github.com/psf/black/issues/3610"">#3610</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Add trailing commas to collection literals even if there's a comment after the last
entry (<a href=""https://redirect.github.com/psf/black/issues/3393"">#3393</a>)</li>
<li><code>async def</code>, <code>async for</code>, and <code>async with</code> statements are now formatted consistently
compared to their non-async version. (<a href=""https://redirect.github.com/psf/black/issues/3609"">#3609</a>)</li>
<li><code>with</code> statements that contain two context managers will be consistently wrapped in
parentheses (<a href=""https://redirect.github.com/psf/black/issues/3589"">#3589</a>)</li>
<li>Let string splitters respect <a href=""https://www.unicode.org/reports/tr11/"">East Asian Width</a>
(<a href=""https://redirect.github.com/psf/black/issues/3445"">#3445</a>)</li>
<li>Now long string literals can be split after East Asian commas and periods (<code>、</code> U+3001
IDEOGRAPHIC COMMA, <code>。</code> U+3002 IDEOGRAPHIC FULL STOP, &amp; <code>，</code> U+FF0C FULLWIDTH COMMA)
besides before spaces (<a href=""https://redirect.github.com/psf/black/issues/3445"">#3445</a>)</li>
<li>For stubs, enforce one blank line after a nested class with a body other than just
<code>...</code> (<a href=""https://redirect.github.com/psf/black/issues/3564"">#3564</a>)</li>
<li>Improve handling of multiline strings by changing line split behavior (<a href=""https://redirect.github.com/psf/black/issues/1879"">#1879</a>)</li>
</ul>
<h3>Parser</h3>
<ul>
<li>Added support for formatting files with invalid type comments (<a href=""https://redirect.github.com/psf/black/issues/3594"">#3594</a>)</li>
</ul>
<h3>Integrations</h3>
<ul>
<li>Update GitHub Action to use the version of Black equivalent to action's version if
version input is not specified (<a href=""https://redirect.github.com/psf/black/issues/3543"">#3543</a>)</li>
<li>Fix missing Python binary path in autoload script for vim (<a href=""https://redirect.github.com/psf/black/issues/3508"">#3508</a>)</li>
</ul>
<h3>Documentation</h3>
<ul>
<li>Document that only the most recent release is supported for security issues;
vulnerabilities should be reported through Tidelift (<a href=""https://redirect.github.com/psf/black/issues/3612"">#3612</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/psf/black/commit/bf7a16254ec96b084a6caf3d435ec18f0f245cc7""><code>bf7a162</code></a> Fixup the changelog (<a href=""https://redirect.github.com/psf/black/issues/3628"">#3628</a>)</li>
<li><a href=""https://github.com/psf/black/commit/9b2b048692f0bd642f38230b4e61c778a4653f91""><code>9b2b048</code></a> Prepare release 23.3.0 (<a href=""https://redirect.github.com/psf/black/issues/3625"">#3625</a>)</li>
<li><a href=""https://github.com/psf/black/commit/bf5abdb0b6cf6644628977230736a0a6478c1bff""><code>bf5abdb</code></a> Specify Python exec path with minor version if available (<a href=""https://redirect.github.com/psf/black/issues/3508"">#3508</a>)</li>
<li><a href=""https://github.com/psf/black/commit/b542f589a5c4041f54847591104cd51684849f2e""><code>b542f58</code></a> Use GH action version when version argument not specified (<a href=""https://redirect.github.com/psf/black/issues/3543"">#3543</a>)</li>
<li><a href=""https://github.com/psf/black/commit/f3b1a3b9d2fc6de8f0845399cb80d8bdfd6400fd""><code>f3b1a3b</code></a> Bump furo from 2022.12.7 to 2023.3.23 in /docs (<a href=""https://redirect.github.com/psf/black/issues/3624"">#3624</a>)</li>
<li><a href=""https://github.com/psf/black/commit/ef6e079901d53a42dfae4ab10b081ce7a73a47b5""><code>ef6e079</code></a> Let string splitters respect <code>East_Asian_Width</code> property (<a href=""https://redirect.github.com/psf/black/issues/3445"">#3445</a>)</li>
<li><a href=""https://github.com/psf/black/commit/5c064a986c388e2be1e448c3e4b28e5f5ba7ce5a""><code>5c064a9</code></a> Bump sphinx from 5.3.0 to 6.1.3 in /docs (<a href=""https://redirect.github.com/psf/black/issues/3499"">#3499</a>)</li>
<li><a href=""https://github.com/psf/black/commit/3a9d6f0a5f9013b97676f3d24246bd34d93fce4c""><code>3a9d6f0</code></a> Bump myst-parser from 0.18.1 to 1.0.0 in /docs (<a href=""https://redirect.github.com/psf/black/issues/3601"">#3601</a>)</li>
<li><a href=""https://github.com/psf/black/commit/53c23e62df9b182edf9e7ccf726acdcf8c25846f""><code>53c23e6</code></a> Support files with type comment syntax errors (<a href=""https://redirect.github.com/psf/black/issues/3594"">#3594</a>)</li>
<li><a href=""https://github.com/psf/black/commit/dba3c2695c59fdb11825dbdf8f3b0ab6e0b368b2""><code>dba3c26</code></a> Fix bug introduced in <a href=""https://redirect.github.com/psf/black/issues/3564"">#3564</a>. (<a href=""https://redirect.github.com/psf/black/issues/3615"">#3615</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/psf/black/compare/22.12.0...23.3.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=black&package-manager=pip&previous-version=22.12.0&new-version=23.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2047.org.readthedocs.build/en/2047/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2047/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1644018605,PR_kwDOBm6k_c5NEqBO,2046,Bump furo from 2022.12.7 to 2023.3.27,49699333,closed,0,,,0,2023-03-28T13:58:14Z,2023-03-29T06:08:02Z,2023-03-29T06:08:01Z,CONTRIBUTOR,simonw/datasette/pulls/2046,"Bumps [furo](https://github.com/pradyunsg/furo) from 2022.12.7 to 2023.3.27.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/pradyunsg/furo/blob/main/docs/changelog.md"">furo's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<!-- raw HTML omitted -->
<h2>2023.03.27 -- Tasty Tangerine</h2>
<ul>
<li>Regenerate with newer version of sphinx-theme-builder, to fix RECORD hashes.</li>
<li>Add missing class to Font Awesome examples</li>
</ul>
<h2>2023.03.23 -- Sassy Saffron</h2>
<ul>
<li>Update Python version classifiers.</li>
<li>Increase the icon size in mobile header.</li>
<li>Increase admonition title bg opacity.</li>
<li>Change the default API background to transparent.</li>
<li>Transition the API background change.</li>
<li>Remove the &quot;indent&quot; of API entries which have a background.</li>
<li>Break long inline code literals.</li>
</ul>
<h2>2022.12.07 -- Reverent Raspberry</h2>
<ul>
<li>✨ Add support for Sphinx 6.</li>
<li>✨ Improve footnote presentation with docutils 0.18+.</li>
<li>Drop support for Sphinx 4.</li>
<li>Improve documentation about what the edit button does.</li>
<li>Improve handling of empty-flexboxes for better print experience on Chrome.</li>
<li>Improve styling for inline signatures.</li>
<li>Replace the <code>meta</code> generator tag with a comment.</li>
<li>Tweak labels with icons to prevent users selecting icons as text on touch.</li>
</ul>
<h2>2022.09.29 -- Quaint Quartz</h2>
<ul>
<li>Add ability to set arbitrary URLs for edit button.</li>
<li>Add support for aligning text in MyST-parser generated tables.</li>
</ul>
<h2>2022.09.15 -- Pragmatic Pistachio</h2>
<ul>
<li>Add a minimum version constraint on pygments.</li>
<li>Add an explicit dependency on <code>sass</code>.</li>
<li>Change right sidebar title from &quot;Contents&quot; to &quot;On this page&quot;.</li>
<li>Correctly position sidebars on small screens.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/pradyunsg/furo/commit/2f61e10319413adf533488bf4770df391e8a1b53""><code>2f61e10</code></a> Prepare release: 2023.03.27</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/5c7aedd107ad8005c85ac7803ca13870408b3c46""><code>5c7aedd</code></a> Update changelog</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/05350110cf02d033ebb57147eb54e9371a63545a""><code>0535011</code></a> Add missing class to Font Awesome examples (<a href=""https://redirect.github.com/pradyunsg/furo/issues/629"">#629</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/811f1e7e7445e93f6210754db444a58b51741476""><code>811f1e7</code></a> Remove unused <code>templates_path</code> (<a href=""https://redirect.github.com/pradyunsg/furo/issues/627"">#627</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/961d4e9ff2ef15015dc65b1fa095b4fbbc295387""><code>961d4e9</code></a> Add a inline-code as an example heading</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/48af8eb8e7f53ec68ae9a623cf72f31a2ef1bb51""><code>48af8eb</code></a> Back to development</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/81139dd37ed2f7634812eed274b3fb03b6a21a60""><code>81139dd</code></a> Prepare release: 2023.03.23</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/dafa73a0bae8e52522f70fcbfcbde55cded954ea""><code>dafa73a</code></a> Update changelog</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/82591efde2925e212d97c861ab881a21e8c18435""><code>82591ef</code></a> Allow all <code>pre</code> tags to have overflows</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/55b32f0dd5ac9a055629a8fbb8914e9c62a8b072""><code>55b32f0</code></a> Update Python version classifiers (<a href=""https://redirect.github.com/pradyunsg/furo/issues/626"">#626</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/pradyunsg/furo/compare/2022.12.07...2023.03.27"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=furo&package-manager=pip&previous-version=2022.12.7&new-version=2023.3.27)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2046.org.readthedocs.build/en/2046/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2046/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1641013220,I_kwDOBm6k_c5hz9_k,2045,First column on a view page has no facet option in cog menu,9599,open,0,,3268330,0,2023-03-26T18:02:47Z,2023-03-26T18:02:48Z,,OWNER,,"e.g. first column on this page - cog menu has no option to facet.

https://datasette.io/content/tools

<img width=""531"" alt=""image"" src=""https://user-images.githubusercontent.com/9599/227795084-1a36bec3-f274-4381-909d-c691317d803b.png"">
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2045/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1639873822,PR_kwDOBm6k_c5M29tt,2044,Expand labels in row view as well (patch for 0.64.x branch),82332573,open,0,,,0,2023-03-24T18:44:44Z,2023-03-24T18:44:57Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2044,"This is a version of #2031 for the 0.64.x branch.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2044.org.readthedocs.build/en/2044/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2044/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1639446870,PR_kwDOBm6k_c5M1izI,2043,Bump furo from 2022.12.7 to 2023.3.23,49699333,closed,0,,,2,2023-03-24T13:58:08Z,2023-03-28T13:58:24Z,2023-03-28T13:58:21Z,CONTRIBUTOR,simonw/datasette/pulls/2043,"Bumps [furo](https://github.com/pradyunsg/furo) from 2022.12.7 to 2023.3.23.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/pradyunsg/furo/blob/main/docs/changelog.md"">furo's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<!-- raw HTML omitted -->
<h2>2023.03.23 -- Sassy Saffron</h2>
<ul>
<li>Regenerate with newer version of sphinx-theme-builder, to fix RECORD hashes.</li>
<li>Update Python version classifiers.</li>
<li>Increase the icon size in mobile header.</li>
<li>Increase admonition title bg opacity.</li>
<li>Change the default API background to transparent.</li>
<li>Transition the API background change.</li>
<li>Remove the &quot;indent&quot; of API entries which have a background.</li>
<li>Break long inline code literals.</li>
</ul>
<h2>2022.12.07 -- Reverent Raspberry</h2>
<ul>
<li>✨ Add support for Sphinx 6.</li>
<li>✨ Improve footnote presentation with docutils 0.18+.</li>
<li>Drop support for Sphinx 4.</li>
<li>Improve documentation about what the edit button does.</li>
<li>Improve handling of empty-flexboxes for better print experience on Chrome.</li>
<li>Improve styling for inline signatures.</li>
<li>Replace the <code>meta</code> generator tag with a comment.</li>
<li>Tweak labels with icons to prevent users selecting icons as text on touch.</li>
</ul>
<h2>2022.09.29 -- Quaint Quartz</h2>
<ul>
<li>Add ability to set arbitrary URLs for edit button.</li>
<li>Add support for aligning text in MyST-parser generated tables.</li>
</ul>
<h2>2022.09.15 -- Pragmatic Pistachio</h2>
<ul>
<li>Add a minimum version constraint on pygments.</li>
<li>Add an explicit dependency on <code>sass</code>.</li>
<li>Change right sidebar title from &quot;Contents&quot; to &quot;On this page&quot;.</li>
<li>Correctly position sidebars on small screens.</li>
<li>Correctly select only Furo's own <code>svg</code> in related pages <code>nav</code>.</li>
<li>Make numpy-style documentation headers consistent.</li>
<li>Retitle the reference section.</li>
<li>Update npm dependencies.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/pradyunsg/furo/commit/81139dd37ed2f7634812eed274b3fb03b6a21a60""><code>81139dd</code></a> Prepare release: 2023.03.23</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/dafa73a0bae8e52522f70fcbfcbde55cded954ea""><code>dafa73a</code></a> Update changelog</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/82591efde2925e212d97c861ab881a21e8c18435""><code>82591ef</code></a> Allow all <code>pre</code> tags to have overflows</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/55b32f0dd5ac9a055629a8fbb8914e9c62a8b072""><code>55b32f0</code></a> Update Python version classifiers (<a href=""https://redirect.github.com/pradyunsg/furo/issues/626"">#626</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/cd6ecdd5d3292f547ceb0cc175b3acf59831cf34""><code>cd6ecdd</code></a> Update linters</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/82a1cec456d5af4386caa46cd4db3a54950a45f4""><code>82a1cec</code></a> Drop the black pin in blacken-docs</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/483b05c8ba74c59f151f17ecf415a7a984507d25""><code>483b05c</code></a> Increase the icon size in mobile header</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/ab3ca77172738f9b2a000948513ddce09fc3b529""><code>ab3ca77</code></a> Revert &quot;Increase icon sizes (<a href=""https://redirect.github.com/pradyunsg/furo/issues/554"">#554</a>)&quot;</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/82376d29fd5687a81fd9926b1c464c884919b1ab""><code>82376d2</code></a> Supply encoding. Fixes <a href=""https://redirect.github.com/pradyunsg/furo/issues/621"">#621</a>. (<a href=""https://redirect.github.com/pradyunsg/furo/issues/622"">#622</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/193643fdb6787501195555244f4a9e953ef544bb""><code>193643f</code></a> Increase admonition title bg opacity (<a href=""https://redirect.github.com/pradyunsg/furo/issues/555"">#555</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/pradyunsg/furo/compare/2022.12.07...2023.03.23"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=furo&package-manager=pip&previous-version=2022.12.7&new-version=2023.3.23)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2043.org.readthedocs.build/en/2043/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2043/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1636616315,I_kwDOBm6k_c5hjMh7,2042,Gather feedback on new ?_extra= design,9599,open,0,,,0,2023-03-22T23:07:43Z,2023-03-22T23:08:19Z,,OWNER,,"Now that I've landed:
- #1999

See also:
- #262

I want to get some feedback from people on the design of the new `?_extra=` feature, before freezing it into Datasette 1.0.

The big change is that the default JSON representation is now MUCH slimmer - it only gives you keys for `""next""` and `""rows""`, where rows is a list of JSON objects (not a list of arrays as was previously the default) - for example https://latest.datasette.io/fixtures/sortable.json

If you want extra stuff you can ask for it with the new `?_extra=` parameter - e.g. https://latest.datasette.io/fixtures/sortable.json?_extra=columns&_extra=suggested_facets

You can use `?_extra=extras` to see a list of available extras: https://latest.datasette.io/fixtures/sortable.json?_extra=extras
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2042/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1633077183,I_kwDOBm6k_c5hVse_,2041,Remove obsolete table POST code,9599,closed,0,,8755003,2,2023-03-21T01:01:40Z,2023-03-21T01:17:44Z,2023-03-21T01:17:43Z,OWNER,,"Spotted this in:
- #1999

`POST /db/table` currently executes obsolete code for inserting a row - I replaced that with `/db/table/-/insert` in 
https://github.com/simonw/datasette/commit/6e788b49edf4f842c0817f006eb9d865778eea5e but forgot to remove the old code.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2041/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1620515757,I_kwDOBm6k_c5glxut,2039,Subtle bug with `--load-extension` and `--static` flags with absolute Windows paths with`C:\`,15178711,open,0,,,0,2023-03-12T21:18:52Z,2023-03-12T21:18:52Z,,CONTRIBUTOR,,"From the Datasette discord: A user tried running the following command on windows:

```
datasette  --load-extension=""C:\spatialite\mod_spatialite-5.0.1-win-x86\mod_spatialite.dll""
```
This failed with `""The specified module could not be found""`, because the entrypoint option introduced in #1789 splits the input differently. Instead of loading the extension found at `""C:\spatialite\mod_spatialite-5.0.1-win-x86\mod_spatialite.dll""`, it instead tried to load the extension at `""C""` with entrypoint `""\spatialite\mod_spatialite-5.0.1-win-x86\mod_spatialite.dll"". 

This is hard because most absolute windows paths have a colon in them, like `C:\foo.txt` or `D:\bar.txt`.  I'd image the `--static` flag is also vulnerable to this type of bug.


The ""solution"" is to use a relative path instead, but that doesn't feel that great. ",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2039/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1618249044,I_kwDOBm6k_c5gdIVU,2038,Consider a `strict_templates` setting,9599,open,0,,,2,2023-03-10T02:09:13Z,2023-03-10T02:11:06Z,,OWNER,,"A setting which turns on Jinja strict mode, so any templates that access undefined variables raise a hard error.

Prototype here:
```diff
diff --git a/datasette/app.py b/datasette/app.py
index 40416713..1428a3f0 100644
--- a/datasette/app.py
+++ b/datasette/app.py
@@ -200,6 +200,7 @@ SETTINGS = (
         ""Allow display of SQL trace debug information with ?_trace=1"",
     ),
     Setting(""base_url"", ""/"", ""Datasette URLs should use this base path""),
+    Setting(""strict_templates"", False, ""Raise errors for undefined template variables""),
 )
 _HASH_URLS_REMOVED = ""The hash_urls setting has been removed, try the datasette-hashed-urls plugin instead""
 OBSOLETE_SETTINGS = {
@@ -399,11 +400,14 @@ class Datasette:
                 ),
             ]
         )
+        env_extras = {}
+        if self.setting(""strict_templates""):
+            env_extras[""undefined""] = StrictUndefined
         self.jinja_env = Environment(
             loader=template_loader,
             autoescape=True,
             enable_async=True,
-            undefined=StrictUndefined,
+            **env_extras,
         )
         self.jinja_env.filters[""escape_css_string""] = escape_css_string
         self.jinja_env.filters[""quote_plus""] = urllib.parse.quote_plus
```
Explored this idea a bit in:
- #1999",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2038/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1615891776,I_kwDOBm6k_c5gUI1A,2037,Test failure: FAILED tests/test_cli.py::test_install_requirements - FileNotFoundError,9599,closed,0,,,3,2023-03-08T20:30:06Z,2023-03-09T22:33:39Z,2023-03-09T22:33:39Z,OWNER,,"> FAILED tests/test_cli.py::test_install_requirements - FileNotFoundError: [Errno 2] No such file or directory

From https://github.com/simonw/datasette/actions/runs/4348548218/jobs/7597208191

```
=================================== FAILURES ===================================
__________________________ test_install_requirements ___________________________

run_module = <MagicMock name='run_module' id='139768358191936'>

    @mock.patch(""datasette.cli.run_module"")
    def test_install_requirements(run_module):
        runner = CliRunner()
>       with runner.isolated_filesystem():

/home/runner/work/datasette/datasette/tests/test_cli.py:184: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/contextlib.py:119: in __enter__
    return next(self.gen)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <click.testing.CliRunner object at 0x7f1e5bfb9490>, temp_dir = None

    @contextlib.contextmanager
    def isolated_filesystem(
        self, temp_dir: t.Optional[t.Union[str, os.PathLike]] = None
    ) -> t.Iterator[str]:
        """"""A context manager that creates a temporary directory and
        changes the current working directory to it. This isolates tests
        that affect the contents of the CWD to prevent them from
        interfering with each other.
    
        :param temp_dir: Create the temporary directory under this
            directory. If given, the created directory is not removed
            when exiting.
    
        .. versionchanged:: 8.0
            Added the ``temp_dir`` parameter.
        """"""
>       cwd = os.getcwd()
E       FileNotFoundError: [Errno 2] No such file or directory

/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/click/testing.py:466: FileNotFoundError
```
Not sure why it only affected the ""[Calculate test coverage](https://github.com/simonw/datasette/actions/workflows/test-coverage.yml)"" one.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2037/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1615862295,I_kwDOBm6k_c5gUBoX,2036,"`publish cloudrun` reuses image tags, which can lead to very surprising deploy problems",9599,closed,0,,,6,2023-03-08T20:11:44Z,2023-03-08T20:57:34Z,2023-03-08T20:57:34Z,OWNER,,"See this issue:
- https://github.com/simonw/datasette.io/issues/141",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2036/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1615692818,I_kwDOBm6k_c5gTYQS,2035,Potential feature: special support for `?a=1&a=2` on the query page,9599,open,0,,3268330,14,2023-03-08T18:05:03Z,2023-03-31T16:09:08Z,,OWNER,,"From a discussion on Discord: https://discord.com/channels/823971286308356157/996877076982415491/1082789517062320138

The key idea is to make it easier for people to implement `where id in (...)` that's populated from query string arguments.

What if you could add `?id=11&id=32&id=62` to the URL and have that made available as a list that can be used in the query?",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2035/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1613974869,PR_kwDOBm6k_c5LgPS-,2034,remove an unused `app` var in cli.py,4370201,open,0,,,2,2023-03-07T18:19:05Z,2023-03-29T20:56:20Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2034,"this var `app` isn't actually used? unless init it does some side-effect outside of the event loop, idon't think it's necessary. 

Feel free to ignore this PR if the deleted line actually does something.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2034.org.readthedocs.build/en/2034/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2034/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1612296210,I_kwDOBm6k_c5gGbAS,2033,`datasette install -r requirements.txt`,9599,closed,0,,,2,2023-03-06T22:17:17Z,2023-03-06T22:54:52Z,2023-03-06T22:27:34Z,OWNER,,"Would be useful for cases where you want to install a whole set of plugins in one go, e.g. when running tutorials in GitHub Codespaces.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2033/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1605959201,I_kwDOBm6k_c5fuP4h,2032,datasette errors when foreign key integrity is enabled,193185,open,0,,,0,2023-03-02T01:27:51Z,2023-03-02T01:31:58Z,,CONTRIBUTOR,,"By default, [SQLite does not enforce foreign key constraints](https://www.sqlite.org/foreignkeys.html#fk_enable). I typically enable these checks by running:

```sql
PRAGMA foreign_keys = ON;
```

inside of a `prepare_connection` hook.

If a plugin causes the schema to change (eg datasette-scraper creating a new table, or datasette-edit-schema changing a column), then https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/utils/internal_db.py#L71-L77 will fail with:

```
FOREIGN KEY constraint failed
```

This could be resolved by either:
- deleting from the `tables` column last
- changing the schema so that the foreign keys have [ON DELETE CASCADE](https://www.sqlite.org/foreignkeys.html#fk_actions)

Let me know if you'd be open to a PR that addresses this -- since foreign key constraints aren't enabled by default, I guess it's questionable whether this is a bug. I think I can workaround this by inspecting the database parameter in `prepare_connection` and trying not to enable fkey checks on the `_internal` database.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2032/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1605481359,PR_kwDOBm6k_c5LDwrF,2031,Expand foreign key references in row view as well,82332573,open,0,,,5,2023-03-01T18:43:09Z,2023-03-24T18:35:25Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2031,"Unlike the table view, the single row view does not resolve foreign key references into labels. This patch extracts the foreign key reference expansion code from TableView.data() into a standalone function that is then called by both TableView.data() and RowView.data().

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2031.org.readthedocs.build/en/2031/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2031/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1594383280,I_kwDOBm6k_c5fCFuw,2030,How to use Datasette with apache webserver on GCP?,19700859,closed,0,,,2,2023-02-22T03:08:49Z,2023-02-22T21:54:39Z,2023-02-22T21:54:39Z,NONE,,"Hi Simon and Datasette team-

I have installed apache2 webserver inside GCP VM using apt.

I can see my ""Hello World"" index.html if I use the external IP of this GCP in a browser.

However, when I try to run datasette with different combinations of -h and -p, I am still unable to access the webpage.

I cannot invest Docker on this VM.

Any pointers to use datasette with already existing apache2 webserver on GCP is appreciated.

Thanks.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2030/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1592327343,I_kwDOBm6k_c5e6Pyv,2029,"Sorry Simon, didn't know how else to contact you",5804626,open,0,,,0,2023-02-20T19:02:53Z,2023-02-20T19:02:53Z,,NONE,,"Hi Simon,

Would you be willing to chat with me about Datasette? I have some questions. I am working on a project to evaluate data ingestion tools for a research organization and I ran across Datasette. I have looked through a lot of your documentation, but still have some questions, which are very specific. If you would be willing to write me back about this, my email is laura@renci.org.

Thanks,
Laura",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2029/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1590839187,PR_kwDOBm6k_c5KSs9T,2028,add Python 3.11 classifier,614233,closed,0,,,2,2023-02-19T20:16:03Z,2023-03-06T21:01:20Z,2023-03-06T21:01:19Z,CONTRIBUTOR,simonw/datasette/pulls/2028,"Python 3.11 is tested in CI and is used in the docker image, so add the Python 3.11 Trove classifier.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2028.org.readthedocs.build/en/2028/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2028/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1590183272,I_kwDOBm6k_c5eyEVo,2027,"How to redirect from ""/"" to a specific db/table",1350673,open,0,,,4,2023-02-18T03:14:01Z,2023-03-08T04:42:22Z,,NONE,,"Using nginx to redirect public IP to the local uvicorn server as 'normal'.  I can't figure out how to redirect such that '/' results in accessing the one db/table I want to serve; redirecting / to /db/table breaks some of the CSS; fooling with base_url doesn't seem to help.  Can someone explain this, if it's possible?",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2027/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1586980089,PR_kwDOBm6k_c5KF-by,2026,Avoid repeating primary key columns if included in _col args,8513,open,0,,,0,2023-02-16T04:16:25Z,2023-02-16T04:16:41Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2026,"...while maintaining given order.

Fixes #1975 (if I'm understanding correctly).

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2026.org.readthedocs.build/en/2026/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2026/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1581218043,PR_kwDOBm6k_c5JyqPy,2025,Add database metadata to index.html template context,9993,open,0,,,0,2023-02-12T11:16:58Z,2023-02-12T11:17:14Z,,FIRST_TIME_CONTRIBUTOR,simonw/datasette/pulls/2025,"Fixes #2016 

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2025.org.readthedocs.build/en/2025/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2025/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1579973223,I_kwDOBm6k_c5eLHpn,2024,Mention WAL mode in documentation,9599,open,0,,,1,2023-02-10T16:11:10Z,2023-02-10T16:11:53Z,,OWNER,,It's not currently obvious from the docs how you can ensure that Datasette runs well in situations where other processes may update the underlying SQLite files.,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2024/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1579695809,I_kwDOBm6k_c5eKD7B,2023,Error: Invalid setting 'hash_urls' in settings.json in 0.64.1,80409402,closed,0,,,2,2023-02-10T13:35:01Z,2023-02-10T15:40:00Z,2023-02-10T15:39:59Z,NONE,,"On a Debian machine, using datasette 0.64.1 installed with `pip3`, I am getting a `datasette[114272]: Error: Invalid setting 'hash_urls' in settings.json` in `journalctl -xe`. The same settings work on 0.54.1 on another Debian server.

This is my `settings.json`:

```json
{
    ""default_page_size"": 200,
    ""max_returned_rows"": 8000,
    ""num_sql_threads"": 3,
    ""sql_time_limit_ms"": 1000,
    ""default_facet_size"": 30,
    ""facet_time_limit_ms"": 200,
    ""facet_suggest_time_limit_ms"": 50,
    ""hash_urls"": false,
    ""allow_facet"": true,
    ""allow_download"": true,
    ""suggest_facets"": true,
    ""default_cache_ttl"": 5,
    ""default_cache_ttl_hashed"": 31536000,
    ""cache_size_kb"": 0,
    ""allow_csv_stream"": true,
    ""max_csv_mb"": 100,
    ""truncate_cells_html"": 2048,
    ""force_https_urls"": false,
    ""template_debug"": false,
    ""base_url"": ""/pclim/db/""
}
```

This looks ok to me. Would you have any ideas?",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2023/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1578609658,I_kwDOBm6k_c5eF6v6,2022,Error 500 - not clear the cause,1667631,closed,0,,,1,2023-02-09T20:57:17Z,2023-02-09T21:13:50Z,2023-02-09T21:13:50Z,NONE,,"On the database that I have sent via linkedIn, datasette works great, but the following URL gives a 500 error.

http://127.0.0.1:8001/literature/authors_papers?authorId=100550354

The cause of the error is not apparent.

Is this expected behaviour?

David",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2022/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1577548579,I_kwDOBm6k_c5eB3sj,2021,Docker images for 1.0 alphas?,1563881,open,0,,,0,2023-02-09T09:35:52Z,2023-02-09T09:35:52Z,,NONE,,"Hi,
would you consider putting 1.0alpha images on Dockerhub? 

(Also, how usable are the alphas?)",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2021/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1575880841,I_kwDOBm6k_c5d7giJ,2020,"Documentation refers to ""off"" setting; doesn't seem to work, ""false"" does",1350673,open,0,,,0,2023-02-08T10:38:10Z,2023-02-08T10:38:10Z,,NONE,,"https://docs.datasette.io/en/stable/settings.html#suggest-facets, among others, suggests using ""off"" to disable the setting; however, this doesn't appear to work in the JSON config files, where it apparently needs to be a ""JSON boolean"" and have the values ""true"" or ""false"".  Perhaps the Python code is more flexible?...but either way, the documentation probably should mention it.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2020/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1573424830,I_kwDOBm6k_c5dyI6-,2019,Refactor out the keyset pagination code,9599,open,0,,,14,2023-02-06T23:04:00Z,2023-02-08T01:40:46Z,,OWNER,,"While working on:
- #1999

I noticed that some of the most complex code in the existing table view is the code that implements keyset pagination:

https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/views/table.py#L417-L493

Extracting that into a utility function would simplify that code a lot.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2019/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1571711808,I_kwDOBm6k_c5drmtA,2018,`check_visibility` gives confusing (wrong?) results if permission is `None`,193185,open,0,,,0,2023-02-06T01:03:08Z,2023-02-06T01:03:46Z,,CONTRIBUTOR,,"I'm trying to gate access to an edit UI on the user having `update-row` on the underlying view or table.

I expected [datasette.check_visibility](https://docs.datasette.io/en/latest/internals.html#await-check-visibility-actor-action-none-resource-none-permissions-none) to be a good way to do this:

```python
    visible, private = await datasette.check_visibility(
        request.actor,
        permissions=[
            (""update-row"", (database, table)),
        ],
    )

    if not visible:
        return None
```

But `visible` is returning true, even when there is no explicit `update-row` permission. (In this case, `request.actor` is `None`.)

Based on [the update-row permissions docs](https://docs.datasette.io/en/latest/authentication.html#update-row), I expected this to be default deny, and so no explicit permission would result in false.

I think the root cause is that `check_visibility` calls `ensure_permissions` and expects it to throw if the permission is not available.

But `ensure_permissions` does not throw when `permission_allowed` returns None: https://github.com/simonw/datasette/blob/1.0a2/datasette/app.py#L825-L829",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2018/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1571207083,I_kwDOBm6k_c5dprer,2016,Database metadata fields like description are not available in the index page template's context,9993,open,0,,3268330,1,2023-02-05T02:25:53Z,2023-02-05T22:56:43Z,,NONE,,"When looping through `databases` in the index.html template, I'd like to print the description of each database alongside its name. But it appears that isn't passed in from the view, unless I'm missing it. It would be great to have that.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2016/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1566081801,PR_kwDOBm6k_c5JAcGy,2014,Bump black from 22.12.0 to 23.1.0,49699333,closed,0,,,2,2023-02-01T13:06:16Z,2023-03-29T06:09:14Z,2023-03-29T06:09:12Z,CONTRIBUTOR,simonw/datasette/pulls/2014,"Bumps [black](https://github.com/psf/black) from 22.12.0 to 23.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/releases"">black's releases</a>.</em></p>
<blockquote>
<h2>23.1.0</h2>
<h3>Highlights</h3>
<p>This is the first release of 2023, and following our <a href=""https://black.readthedocs.io/en/stable/the_black_code_style/index.html#stability-policy"">stability policy</a>, it comes with a number of improvements to our stable style, notably improvements to empty line handling and the removal of redundant parentheses in several contexts.</p>
<p>There are also many changes to the preview style; try out <code>black --preview</code> and give us feedback to help us set the stable style for next year.</p>
<p>In addition to style changes, Black now automatically infers the supported Python versions from your <code>pyproject.toml</code> file, removing the need to set Black's target versions separately.</p>
<h3>Stable style</h3>
<!-- raw HTML omitted -->
<ul>
<li>Introduce the 2023 stable style, which incorporates most aspects of last year's preview style (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3418"">#3418</a>). Specific changes:
<ul>
<li>Enforce empty lines before classes and functions with sticky leading comments (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3302"">#3302</a>) (22.12.0)</li>
<li>Reformat empty and whitespace-only files as either an empty file (if no newline is present) or as a single newline character (if a newline is present) (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3348"">#3348</a>) (22.12.0)</li>
<li>Correctly handle trailing commas that are inside a line's leading non-nested parens (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3370"">#3370</a>) (22.12.0)</li>
<li><code>--skip-string-normalization</code> / <code>-S</code> now prevents docstring prefixes from being normalized as expected (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3168"">#3168</a>) (since 22.8.0)</li>
<li>When using <code>--skip-magic-trailing-comma</code> or <code>-C</code>, trailing commas are stripped from subscript expressions with more than 1 element (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3209"">#3209</a>) (22.8.0)</li>
<li>Fix a string merging/split issue when a comment is present in the middle of implicitly concatenated strings on its own line (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3227"">#3227</a>) (22.8.0)</li>
<li>Docstring quotes are no longer moved if it would violate the line length limit (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3044"">#3044</a>, <a href=""https://github-redirect.dependabot.com/psf/black/issues/3430"">#3430</a>) (22.6.0)</li>
<li>Parentheses around return annotations are now managed (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2990"">#2990</a>) (22.6.0)</li>
<li>Remove unnecessary parentheses around awaited objects (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2991"">#2991</a>) (22.6.0)</li>
<li>Remove unnecessary parentheses in <code>with</code> statements (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2926"">#2926</a>) (22.6.0)</li>
<li>Remove trailing newlines after code block open (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3035"">#3035</a>) (22.6.0)</li>
<li>Code cell separators <code>#%%</code> are now standardised to <code># %%</code> (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2919"">#2919</a>) (22.3.0)</li>
<li>Remove unnecessary parentheses from <code>except</code> statements (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2939"">#2939</a>) (22.3.0)</li>
<li>Remove unnecessary parentheses from tuple unpacking in <code>for</code> loops (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2945"">#2945</a>) (22.3.0)</li>
<li>Avoid magic-trailing-comma in single-element subscripts (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2942"">#2942</a>) (22.3.0)</li>
</ul>
</li>
<li>Fix a crash when a colon line is marked between <code># fmt: off</code> and <code># fmt: on</code> (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3439"">#3439</a>)</li>
</ul>
<h3>Preview style</h3>
<!-- raw HTML omitted -->
<ul>
<li>Format hex codes in unicode escape sequences in string literals (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2916"">#2916</a>)</li>
<li>Add parentheses around <code>if</code>-<code>else</code> expressions (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2278"">#2278</a>)</li>
<li>Improve performance on large expressions that contain many strings (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3467"">#3467</a>)</li>
<li>Fix a crash in preview style with assert + parenthesized string (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3415"">#3415</a>)</li>
<li>Fix crashes in preview style with walrus operators used in function return annotations and except clauses (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3423"">#3423</a>)</li>
<li>Fix a crash in preview advanced string processing where mixed implicitly concatenated regular and f-strings start with an empty span (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3463"">#3463</a>)</li>
<li>Fix a crash in preview advanced string processing where a standalone comment is placed before a dict's value (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3469"">#3469</a>)</li>
<li>Fix an issue where extra empty lines are added when a decorator has <code># fmt: skip</code> applied or there is a standalone comment between decorators (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3470"">#3470</a>)</li>
<li>Do not put the closing quotes in a docstring on a separate line, even if the line is too long (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3430"">#3430</a>)</li>
<li>Long values in dict literals are now wrapped in parentheses; correspondingly unnecessary parentheses around short values in dict literals are now removed; long string lambda values are now wrapped in parentheses (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3440"">#3440</a>)</li>
<li>Fix two crashes in preview style involving edge cases with docstrings (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3451"">#3451</a>)</li>
<li>Exclude string type annotations from improved string processing; fix crash when the return type annotation is stringified and spans across multiple lines (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3462"">#3462</a>)</li>
<li>Wrap multiple context managers in parentheses when targeting Python 3.9+ (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3489"">#3489</a>)</li>
<li>Fix several crashes in preview style with walrus operators used in <code>with</code> statements or tuples (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3473"">#3473</a>)</li>
<li>Fix an invalid quote escaping bug in f-string expressions where it produced invalid code. Implicitly concatenated f-strings with different quotes can now be merged or quote-normalized by changing the quotes used in expressions. (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3509"">#3509</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/blob/main/CHANGES.md"">black's changelog</a>.</em></p>
<blockquote>
<h2>23.1.0</h2>
<h3>Highlights</h3>
<p>This is the first release of 2023, and following our
<a href=""https://black.readthedocs.io/en/stable/the_black_code_style/index.html#stability-policy"">stability policy</a>,
it comes with a number of improvements to our stable style, including improvements to
empty line handling, removal of redundant parentheses in several contexts, and output
that highlights implicitly concatenated strings better.</p>
<p>There are also many changes to the preview style; try out <code>black --preview</code> and give us
feedback to help us set the stable style for next year.</p>
<p>In addition to style changes, Black now automatically infers the supported Python
versions from your <code>pyproject.toml</code> file, removing the need to set Black's target
versions separately.</p>
<h3>Stable style</h3>
<!-- raw HTML omitted -->
<ul>
<li>Introduce the 2023 stable style, which incorporates most aspects of last year's
preview style (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3418"">#3418</a>). Specific changes:
<ul>
<li>Enforce empty lines before classes and functions with sticky leading comments
(<a href=""https://github-redirect.dependabot.com/psf/black/issues/3302"">#3302</a>) (22.12.0)</li>
<li>Reformat empty and whitespace-only files as either an empty file (if no newline is
present) or as a single newline character (if a newline is present) (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3348"">#3348</a>)
(22.12.0)</li>
<li>Implicitly concatenated strings used as function args are now wrapped inside
parentheses (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3307"">#3307</a>) (22.12.0)</li>
<li>Correctly handle trailing commas that are inside a line's leading non-nested parens
(<a href=""https://github-redirect.dependabot.com/psf/black/issues/3370"">#3370</a>) (22.12.0)</li>
<li><code>--skip-string-normalization</code> / <code>-S</code> now prevents docstring prefixes from being
normalized as expected (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3168"">#3168</a>) (since 22.8.0)</li>
<li>When using <code>--skip-magic-trailing-comma</code> or <code>-C</code>, trailing commas are stripped from
subscript expressions with more than 1 element (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3209"">#3209</a>) (22.8.0)</li>
<li>Implicitly concatenated strings inside a list, set, or tuple are now wrapped inside
parentheses (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3162"">#3162</a>) (22.8.0)</li>
<li>Fix a string merging/split issue when a comment is present in the middle of
implicitly concatenated strings on its own line (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3227"">#3227</a>) (22.8.0)</li>
<li>Docstring quotes are no longer moved if it would violate the line length limit
(<a href=""https://github-redirect.dependabot.com/psf/black/issues/3044"">#3044</a>, <a href=""https://github-redirect.dependabot.com/psf/black/issues/3430"">#3430</a>) (22.6.0)</li>
<li>Parentheses around return annotations are now managed (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2990"">#2990</a>) (22.6.0)</li>
<li>Remove unnecessary parentheses around awaited objects (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2991"">#2991</a>) (22.6.0)</li>
<li>Remove unnecessary parentheses in <code>with</code> statements (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2926"">#2926</a>) (22.6.0)</li>
<li>Remove trailing newlines after code block open (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3035"">#3035</a>) (22.6.0)</li>
<li>Code cell separators <code>#%%</code> are now standardised to <code># %%</code> (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2919"">#2919</a>) (22.3.0)</li>
<li>Remove unnecessary parentheses from <code>except</code> statements (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2939"">#2939</a>) (22.3.0)</li>
<li>Remove unnecessary parentheses from tuple unpacking in <code>for</code> loops (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2945"">#2945</a>) (22.3.0)</li>
<li>Avoid magic-trailing-comma in single-element subscripts (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2942"">#2942</a>) (22.3.0)</li>
</ul>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/psf/black/commit/b0d1fba7ac3be53c71fb0d3211d911e629f8aecb""><code>b0d1fba</code></a> Prepare release 23.1.0 (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3536"">#3536</a>)</li>
<li><a href=""https://github.com/psf/black/commit/69ca0a4c7a365c5f5eea519a90980bab72cab764""><code>69ca0a4</code></a> Infer target version based on project metadata (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3219"">#3219</a>)</li>
<li><a href=""https://github.com/psf/black/commit/c4bd2e31ceeac84d68592986fe70920f3d3d0443""><code>c4bd2e3</code></a> Draft for Black 2023 stable style (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3418"">#3418</a>)</li>
<li><a href=""https://github.com/psf/black/commit/226cbf0226ee3bc26972357ba54c36409e9a84ae""><code>226cbf0</code></a> Fix unsafe cast in linegen.py w/ await yield handling (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3533"">#3533</a>)</li>
<li><a href=""https://github.com/psf/black/commit/f4ebc683208d095b252b87147d002e925c9c1171""><code>f4ebc68</code></a> Upgrade isort (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3534"">#3534</a>)</li>
<li><a href=""https://github.com/psf/black/commit/6407ebb870afe0062ee581abdea07c1ef5213d31""><code>6407ebb</code></a> Remove Python version in the_basics.md (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3528"">#3528</a>)</li>
<li><a href=""https://github.com/psf/black/commit/196b1f349eb2baa9bbbc483226874cc01fb7567d""><code>196b1f3</code></a> Fix <code>black --help</code> output for <code>--python-cell-magics</code> option to be reproducibl...</li>
<li><a href=""https://github.com/psf/black/commit/d950f15987a49a5f3e37127ec718b4c12666b8cf""><code>d950f15</code></a> Update document now that paren wrapping CMs on Python 3.9+ is implemented (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3"">#3</a>...</li>
<li><a href=""https://github.com/psf/black/commit/a36878eb2f375e2ac1e13052f663909f3835ec46""><code>a36878e</code></a> Fix an invalid quote escaping bug in f-string expressions (<a href=""https://github-redirect.dependabot.com/psf/black/issues/3509"">#3509</a>)</li>
<li><a href=""https://github.com/psf/black/commit/eabff673b37c5430d4cf72fa050a189a57be2deb""><code>eabff67</code></a> Format hex code in unicode escape sequences in string literals (<a href=""https://github-redirect.dependabot.com/psf/black/issues/2916"">#2916</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/psf/black/compare/22.12.0...23.1.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=black&package-manager=pip&previous-version=22.12.0&new-version=23.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2014.org.readthedocs.build/en/2014/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2014/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1565179870,I_kwDOBm6k_c5dSr_e,2013,Datasette uses non-standard quoting for identifiers,193185,open,0,,,0,2023-02-01T00:05:39Z,2023-02-01T00:06:30Z,,CONTRIBUTOR,,"Related to #2001, but where #2001 was about literals, this is about identifiers

From https://www.sqlite.org/lang_keywords.html:

> ""keyword""  A keyword in double-quotes is an identifier.
> [keyword]   A keyword enclosed in square brackets is an identifier. This is not standard SQL. This quoting mechanism is used by MS Access and SQL Server and is included in SQLite for compatibility.

Datasette uses this quoting here -- https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/utils/__init__.py#L345-L349, in some of the other DB access code, and in some of the test fixtures.

Migrating to standard double quote identifiers would make it easier to get Datasette working with alternative backends",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2013/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1564774831,I_kwDOBm6k_c5dRJGv,2012,Missing space in database summary,9599,open,0,,,0,2023-01-31T18:01:13Z,2023-01-31T18:01:13Z,,OWNER,,"Spotted this on an instance index page:

<img width=""441"" alt=""image"" src=""https://user-images.githubusercontent.com/9599/215844680-9648fefa-dfbb-4ed6-bbbf-c3891e4dbdcc.png"">
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2012/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1564769997,I_kwDOBm6k_c5dRH7N,2011,"Applied facet did not result in an ""x"" icon to dismiss it",9599,open,0,,,1,2023-01-31T17:57:44Z,2023-01-31T17:58:54Z,,OWNER,,"![CleanShot 2023-01-31 at 09 55 56@2x](https://user-images.githubusercontent.com/9599/215843684-1761a230-d490-4f87-be6d-186319366794.png)

That's against this data https://data.sfgov.org/City-Management-and-Ethics/Supplier-Contracts/cqi5-hm2d imported using https://datasette.io/plugins/datasette-socrata

It's for `Contract Type` of `Non-Purchasing Contract (Rents, etc.)` - so possible that some of the spaces or punctuation in either the name of the value tripped up the code that decides if the X icon should be displayed.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2011/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1563264257,I_kwDOBm6k_c5dLYUB,2010,Row page should default to card view,9599,open,0,,3268330,1,2023-01-30T21:49:37Z,2023-01-30T21:52:06Z,,OWNER,,"Datasette currently uses the same table layout on the row pages as it does on the table pages:

https://datasette.io/content/pypi_packages?_sort=name&name__exact=datasette-column-inspect

<img width=""1068"" alt=""image"" src=""https://user-images.githubusercontent.com/9599/215602793-b15dad48-c3e9-4f34-9875-3e79b7aa586d.png"">

https://datasette.io/content/pypi_packages/datasette-column-inspect

<img width=""1068"" alt=""image"" src=""https://user-images.githubusercontent.com/9599/215602883-9d714eec-3908-493e-93d0-c788af47ba21.png"">

If you shrink down to mobile width you get this instead, on both of those pages:

<img width=""613"" alt=""image"" src=""https://user-images.githubusercontent.com/9599/215602964-b95aa089-0269-4647-beae-66fffad332f5.png"">

I think that view, which I think of as the ""card view"", is plain better if you're looking at just a single row - and it (or a variant of it) should be the default presentation on the row page.

",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2010/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1560982210,PR_kwDOBm6k_c5IvYKw,2008,array facet: don't materialize unnecessary columns,193185,open,0,,,8,2023-01-28T19:33:40Z,2023-01-29T18:17:40Z,,CONTRIBUTOR,simonw/datasette/pulls/2008,"The presence of `inner.*` causes SQLite to materialize a row with all the columns. Those columns will be discarded later.

Instead, we can select only the column we'll use. This lets SQLite's optimizer realize that the other columns in the CTE definition aren't needed.

On a test table with 278K rows, 98K of which had an array, this speeds up the facet calculation from 4 sec to 1 sec.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2008.org.readthedocs.build/en/2008/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2008/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1560662739,I_kwDOBm6k_c5dBdLT,2007,`render_cell()` hook should take an optional `request` argument,9599,closed,0,,,1,2023-01-28T03:13:00Z,2023-08-09T17:15:03Z,2023-01-28T03:34:26Z,OWNER,,From Discord: https://discordapp.com/channels/823971286308356157/996877076982415491/1068227071156965486,107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2007/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1558644003,I_kwDOBm6k_c5c5wUj,2006,Teach `datasette publish` to pin to `datasette<1.0` in a 0.x release,9599,open,0,,3268330,2,2023-01-26T19:17:40Z,2023-01-26T19:20:53Z,,OWNER,,"I just realized that when I ship Datasette 1.0 there may be automated deployments out there which could deploy the 1.0 version by accident, potentially breaking any customizations that aren't compatible with the 1.0 changes.

I can hopefully help avoid that by shipping one last entry in the `0.x` series that ensures `datasette publish` pins to `<1.0` when it installs Datasette itself.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2006/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1557507274,I_kwDOBm6k_c5c1azK,2005,`extra_template_vars` should be OK to return `None`,9599,open,0,,,1,2023-01-26T01:40:45Z,2023-01-26T01:41:50Z,,OWNER,,"Got this exception and had to make sure it always returned `{}`:

```
  File "".../python3.11/site-packages/datasette/app.py"", line 1049, in render_template
    assert isinstance(extra_vars, dict), ""extra_vars is of type {}"".format(
AssertionError: extra_vars is of type <class 'NoneType'>
```",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2005/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1556065335,PR_kwDOBm6k_c5Ie5nA,2004,"use single quotes for string literals, fixes #2001",193185,open,0,,,1,2023-01-25T05:08:46Z,2023-02-01T06:37:18Z,,CONTRIBUTOR,simonw/datasette/pulls/2004,"This modernizes some uses of double quotes for string literals to use only single quotes, fixes simonw/datasette#2001

While developing it, I manually enabled the stricter mode by using the code snippet at https://gist.github.com/cldellow/85bba507c314b127f85563869cd94820

I think that code snippet isn't generally safe/portable, so I haven't tried to automate it in the tests.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2004.org.readthedocs.build/en/2004/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2004/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1555701851,PR_kwDOBm6k_c5IdsD7,2003,Show referring tables and rows when the referring foreign key is compound,536941,open,0,,,3,2023-01-24T21:31:31Z,2023-01-25T18:44:42Z,,CONTRIBUTOR,simonw/datasette/pulls/2003,"sqlite foreign keys can be compound, but that is not as well supported by datasette as single column foreign keys.

in particular, 

1. in a table view, there is not a link from the row to the referenced row if the foreign key is compound
2. in a row view, there is no listing of tables and rows that refer to the focal row if those referencing foreign keys are compound.

Both of these issues are discussed in #1099. 

This PR only fixes the second one, because it's not clear what the right UX is for the first issue.

![Screenshot 2023-01-24 at 19-47-40 nlrb bargaining_unit](https://user-images.githubusercontent.com/536941/214454749-d53deead-4151-4329-a5d4-8a7a454de7d3.png)

Some things that might not be desirable about this approach.

1. it changes the external API, by changing `column` => `columns` and `other_column` => `other_columns` (see inline comment for more discussion.
2. There are various places where the plural foreign keys have to be checked for length and discarded or transformed to singular. 
",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2003/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1554032168,I_kwDOBm6k_c5coKYo,2002,Document how actors are displayed,9599,open,0,,,0,2023-01-24T00:08:49Z,2023-01-24T00:08:49Z,,OWNER,,"https://github.com/simonw/datasette/blob/e4ebef082de90db4e1b8527abc0d582b7ae0bc9d/datasette/utils/__init__.py#L1052-L1056

This logic should be reflected in the documentation on https://docs.datasette.io/en/stable/authentication.html#actors",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2002/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1553615704,I_kwDOBm6k_c5cmktY,2001,Datasette is not compatible with SQLite's strict quoting compilation option,406380,open,0,,,4,2023-01-23T19:10:07Z,2023-01-25T04:59:58Z,,NONE,,"I have linked Python3.11 on macOS against recent SQLite that was compiled using `-DSQLITE_DQS=0`. This option disables interpretation of double-quoted identifiers as string literals, described in the SQLite docs as a ""MySQL 3.x misfeature"". See https://www.sqlite.org/quirks.html#dblquote for background.

Datasette uses the double-quote syntax in a number of key places, and is thus completely broken in this environment.

My experience was to `pip install datasette`, then run `datasette serve -I my-data.db`. When I visit `http://127.0.0.1:8001` I get a 500 response.

The error: `sqlite3.OperationalError: no such column: geometry_columns`

The responsible SQL: `'select 1 from sqlite_master where tbl_name = ""geometry_columns""'`

I then installed datasette from GitHub master in development mode and changed the offending SQL to use correct quotes: `""select 1 from sqlite_master where tbl_name = 'geometry_columns'""`.

With this change, I get a little further, but have the same problem with the first table name in my database (in my case, ""Meta""):
```
OperationalError: no such column: Meta
Traceback (most recent call last):
  File ""/Users/gwk/external/datasette/datasette/app.py"", line 1522, in route_path
    response = await view(request, send)
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/views/base.py"", line 151, in view
    return await self.dispatch_request(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/views/base.py"", line 105, in dispatch_request
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/views/index.py"", line 70, in get
    ""fts_table"": await db.fts_table(table),
                 ^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/database.py"", line 363, in fts_table
    return await self.execute_fn(lambda conn: detect_fts(conn, table))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/database.py"", line 213, in execute_fn
    return await asyncio.get_event_loop().run_in_executor(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/usr/local/py/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/thread.py"", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/database.py"", line 211, in in_thread
    return fn(conn)
           ^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/database.py"", line 363, in <lambda>
    return await self.execute_fn(lambda conn: detect_fts(conn, table))
                                              ^^^^^^^^^^^^^^^^^^^^^^^
  File ""/Users/gwk/external/datasette/datasette/utils/__init__.py"", line 588, in detect_fts
    rows = conn.execute(detect_fts_sql(table)).fetchall()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sqlite3.OperationalError: no such column: Meta
INFO:     127.0.0.1:50258 - ""GET / HTTP/1.1"" 500 Internal Server Error
```

I will try to continue playing with this, but I also hope that the datasette developers will enable this mode in a test environment as I am unlikely to be able to exercise all of the SQL in the codebase, or make a pull request very soon.

Note that the DQS setting compile-time option can be overridden at runtime with calls to the C API:
```
sqlite3_db_config(db, SQLITE_DBCONFIG_DQS_DDL, 0, (void*)0);
sqlite3_db_config(db, SQLITE_DBCONFIG_DQS_DML, 0, (void*)0);
```

As far as I can tell, `sqlite3_db_config` is not exposed in Python, but perhaps we could figure out how to invoke it using `ctypes`.
",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2001/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1552368054,I_kwDOBm6k_c5ch0G2,2000,rewrite_sql hook,193185,open,0,,,1,2023-01-23T01:02:52Z,2023-01-23T06:08:01Z,,CONTRIBUTOR,,"I'm not sold that this is a good idea, but thought it'd be worth writing up a ticket. Proposal: add a hook like

```python
def rewrite_sql(datasette, database, request, fn, sql, params)
```

It would be called from Database.execute, Database.execute_write, Database.execute_write_script, Database.execute_write_many before running the user's SQL. `fn` would indicate which method was being used, in case that's relevant for the SQL inspection -- for example `execute` only permits a single statement.

The hook could return a SQL statement to be executed instead, or an async function to be awaited on that returned the SQL to be executed.

Plugins that could be written with this hook:

- https://github.com/cldellow/datasette-ersatz-table-valued-functions would use this to avoid monkey-patching
- a plugin to inspect and reject unsafe Spatialite function calls (reported by [Simon in Discord](https://discord.com/channels/823971286308356157/823971286941302908/1066438832293159004))
- a plugin to do more general rewrites of queries to enforce table or row-level security, for example, based on the currently logged in actor's ID
- a plugin to maintain audit tables when users write to a table
- a plugin to cache expensive queries (eg the queries that drive facets) - these could allow stale reads if previously cached, then refresh them in an offline queue

Flaws with this idea:

`execute_fn` and `execute_write_fn` would not go through this hook, which limits the guarantees you can make about it for security purposes.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2000/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1551694938,PR_kwDOBm6k_c5IQeKz,1999,?_extra= support (draft),9599,closed,0,,,49,2023-01-21T04:55:18Z,2023-03-22T22:49:41Z,2023-03-22T22:49:40Z,OWNER,simonw/datasette/pulls/1999,"Refs:
- #262

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--1999.org.readthedocs.build/en/1999/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1999/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,