html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app https://github.com/simonw/datasette/issues/633#issuecomment-620841496,https://api.github.com/repos/simonw/datasette/issues/633,620841496,MDEyOklzc3VlQ29tbWVudDYyMDg0MTQ5Ng==,46165,nryberg,2020-04-28T20:37:50Z,2020-04-28T20:37:50Z,NONE,"Using the Heroku web interface, you can set the WEB_CONCURRENCY = 1 ![image](https://user-images.githubusercontent.com/46165/80535319-352c8100-8966-11ea-9d4f-df2622ec8bff.png) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",522334771,"Publish to Heroku is broken: ""WARNING: You must pass the application as an import string to enable 'reload' or 'workers""", https://github.com/simonw/datasette/issues/633#issuecomment-553483633,https://api.github.com/repos/simonw/datasette/issues/633,553483633,MDEyOklzc3VlQ29tbWVudDU1MzQ4MzYzMw==,9599,simonw,2019-11-13T16:36:02Z,2019-11-13T16:36:35Z,OWNER,Short term fix: set `--workers=1` when publishing with Heroku. Or even easier - set WEB_CONCURRENCY to 1.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",522334771,"Publish to Heroku is broken: ""WARNING: You must pass the application as an import string to enable 'reload' or 'workers""", https://github.com/simonw/datasette/issues/633#issuecomment-553483419,https://api.github.com/repos/simonw/datasette/issues/633,553483419,MDEyOklzc3VlQ29tbWVudDU1MzQ4MzQxOQ==,9599,simonw,2019-11-13T16:35:34Z,2019-11-13T16:35:34Z,OWNER,"The problem is this code in uvicorn: https://github.com/encode/uvicorn/blob/020dd085a0a5b609f14ddd2b36fc0a97ba4df019/uvicorn/main.py#L297-L302 ```python if (config.reload or config.workers > 1) and not isinstance(app, str): logger = logging.getLogger(""uvicorn.error"") logger.warn( ""You must pass the application as an import string to enable 'reload' or 'workers'."" ) sys.exit(1) ``` From this commit 4 days ago: https://github.com/encode/uvicorn/commit/b034f7a136c5e57a33ffd10ce2404cc1faee9033 - see Uvicorn https://github.com/encode/uvicorn/issues/478 and https://github.com/encode/uvicorn/pull/481 This is breaking because `--workers` ""Defaults to the $WEB_CONCURRENCY environment variable if available"" - and it turns out on Heroku WEB_CONCURRENCY is set to 2 by default!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",522334771,"Publish to Heroku is broken: ""WARNING: You must pass the application as an import string to enable 'reload' or 'workers""",