html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130422,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229130422,IC_kwDOCGYnMM5JQwq2,9599,simonw,2022-08-27T05:55:01Z,2022-08-27T05:55:01Z,OWNER,cc @asg017 since this feature was inspired by his work on Datasette.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette, https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130242,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229130242,IC_kwDOCGYnMM5JQwoC,9599,simonw,2022-08-27T05:53:31Z,2022-08-27T05:53:31Z,OWNER,"Tests passed in CI against Ubuntu: ``` tests/test_cli.py::test_load_extension[None-should_pass0-should_fail0] PASSED [ 19%] tests/test_cli.py::test_load_extension[sqlite3_ext_b_init-b-should_fail1] PASSED [ 19%] tests/test_cli.py::test_load_extension[sqlite3_ext_c_init-c-should_fail2] PASSED [ 19%] ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette, https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130158,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229130158,IC_kwDOCGYnMM5JQwmu,9599,simonw,2022-08-27T05:52:46Z,2022-08-27T05:52:46Z,OWNER,"To run the tests locally on my Mac I needed to run Ubuntu in Docker (for the compilation step). This worked: docker run -it -v ""$(pwd):/app"" ubuntu:latest /bin/bash Then: ``` apt-get update && apt-get install python3-pip gcc libsqlite3-dev -y cd /app/tests gcc ext.c -fPIC -shared -o ext.so cd /app pip3 install -e '.[test]' pytest -k test_load_extension ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette, https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229128950,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229128950,IC_kwDOCGYnMM5JQwT2,9599,simonw,2022-08-27T05:42:04Z,2022-08-27T05:42:04Z,OWNER,"Extension looks to be correctly compiled: ``` Run (cd tests && gcc ext.c -fPIC -shared -o ext.so && ls -lah) total 412K drwxr-xr-x 3 runner docker 4.0K Aug 27 05:40 . drwxr-xr-x 8 runner docker 4.0K Aug 27 05:40 .. -rw-r--r-- 1 runner docker 0 Aug 27 05:40 __init__.py -rw-r--r-- 1 runner docker 760 Aug 27 05:40 conftest.py -rw-r--r-- 1 runner docker 1.6K Aug 27 05:40 ext.c -rwxr-xr-x 1 runner docker 16K Aug 27 05:40 ext.so drwxr-xr-x 2 runner docker 4.0K Aug 27 05:40 sniff ``` So why doesn't this check pass? https://github.com/simonw/sqlite-utils/blob/3f694e51a0212a297f663e2fc7f9cdad8775a550/tests/test_cli.py#L25-L30","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette, https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229128617,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229128617,IC_kwDOCGYnMM5JQwOp,9599,simonw,2022-08-27T05:39:06Z,2022-08-27T05:39:06Z,OWNER,"That didn't run the tests as expected on Ubuntu: https://github.com/simonw/sqlite-utils/runs/8048229213?check_suite_focus=true ``` tests/test_cli.py::test_load_extension[None-should_pass0-should_fail0] SKIPPED [ 19%] tests/test_cli.py::test_load_extension[sqlite3_ext_b_init-b-should_fail1] SKIPPED [ 19%] tests/test_cli.py::test_load_extension[sqlite3_ext_c_init-c-should_fail2] SKIPPED [ 19%] ``` That should have worked because of this: https://github.com/simonw/sqlite-utils/blob/3f694e51a0212a297f663e2fc7f9cdad8775a550/.github/workflows/test.yml#L38-L41 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette, https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229115501,https://api.github.com/repos/simonw/sqlite-utils/issues/470,1229115501,IC_kwDOCGYnMM5JQtBt,9599,simonw,2022-08-27T03:54:26Z,2022-08-27T03:54:26Z,OWNER,I can borrow Alex's example extension for the tests too: https://github.com/simonw/datasette/blob/ba35105eee2d3ba620e4f230028a02b2e2571df2/tests/ext.c,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1352932038,Upgrade `--load-extension` to accept entrypoints like Datasette,