html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,issue,performed_via_github_app
https://github.com/simonw/datasette/pull/595#issuecomment-541931047,https://api.github.com/repos/simonw/datasette/issues/595,541931047,MDEyOklzc3VlQ29tbWVudDU0MTkzMTA0Nw==,9599,2019-10-14T21:25:38Z,2019-10-14T21:25:38Z,OWNER,I like the conditional dependency for the moment - maybe until 3.5 becomes officially unsupported.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",506300941,
https://github.com/simonw/datasette/pull/595#issuecomment-541922637,https://api.github.com/repos/simonw/datasette/issues/595,541922637,MDEyOklzc3VlQ29tbWVudDU0MTkyMjYzNw==,9599,2019-10-14T21:08:19Z,2019-10-14T21:08:19Z,OWNER,There more discussion around this on the Glitch forums here: https://support.glitch.com/t/can-you-upgrade-python-to-latest-version/7980,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",506300941,
https://github.com/simonw/datasette/pull/578#issuecomment-541495682,https://api.github.com/repos/simonw/datasette/issues/578,541495682,MDEyOklzc3VlQ29tbWVudDU0MTQ5NTY4Mg==,9599,2019-10-14T03:57:17Z,2019-10-14T03:57:17Z,OWNER,"So this is a new Docker feature from April 2019? https://engineering.docker.com/2019/04/multi-arch-images/

> So why buildx?  Let’s first start with the name.  The x stands for experimental.  In the future, when these new build features are stable and made generally available, we will drop the x and integrate these features directly into the existing docker build command.  Note that as buildx is experimental, features and flags are subject to change.

Is there a strong use-case for supporting this while it's still experimental? Users who want Datasette to run on ARM can build their own image pretty easily, so I'm not sure if it's worth depending on an experimental feature for the core Datasette project.

Is there any indication from the Docker team as to when this experimental feature might stop being marked as experimental?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",499954048,
https://github.com/simonw/datasette/pull/591#issuecomment-541495108,https://api.github.com/repos/simonw/datasette/issues/591,541495108,MDEyOklzc3VlQ29tbWVudDU0MTQ5NTEwOA==,9599,2019-10-14T03:52:09Z,2019-10-14T03:52:09Z,OWNER,Neat solution.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",505837199,
https://github.com/simonw/datasette/pull/590#issuecomment-541495034,https://api.github.com/repos/simonw/datasette/issues/590,541495034,MDEyOklzc3VlQ29tbWVudDU0MTQ5NTAzNA==,9599,2019-10-14T03:51:32Z,2019-10-14T03:51:32Z,OWNER,"We need some unit tests for this.

I'd be fine with us renaming `extra_database.db` to `extra database.py` in these existing fixtures:

https://github.com/simonw/datasette/blob/af2e6a5cf186a7200d76cb67ac30fa59cc24d84e/tests/fixtures.py#L174-L185

Then we could add an extra `test_database_name_with_spaces(...)` test in `test_api.py` which uses parametrize to exercise a bunch of URLs and check they all return a 200 - something a bit like this but covering a range of URL paths (one for database, table, row and table with filters):

https://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/tests/test_api.py#L746-L765","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",505818256,
https://github.com/simonw/datasette/pull/592#issuecomment-541494347,https://api.github.com/repos/simonw/datasette/issues/592,541494347,MDEyOklzc3VlQ29tbWVudDU0MTQ5NDM0Nw==,9599,2019-10-14T03:45:29Z,2019-10-14T03:45:29Z,OWNER,"This is a really nice implementation. I particularly like how you have the button as hidden until JavaScript runs and makes it visible.

https://github.com/simonw/datasette/pull/592/files#diff-0932659dded7aa3ce2d4c7badb187a9cR6-R8","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",505950145,
https://github.com/simonw/datasette/pull/595#issuecomment-541494080,https://api.github.com/repos/simonw/datasette/issues/595,541494080,MDEyOklzc3VlQ29tbWVudDU0MTQ5NDA4MA==,9599,2019-10-14T03:43:11Z,2019-10-14T03:43:11Z,OWNER,"Ooh this is tricky... https://travis-ci.org/simonw/datasette/jobs/597216285 failed because it looks like `websockets-8.0.2` isn't compatible with Python 3.5

This is a problem. I need to keep Datasette working with 3.5 for compatibility with Glitch. But obviously I also want it to work with 3.8. 

I wonder if there's a smart solution here. @tomchristie any thoughts?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",506300941,