html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,issue,performed_via_github_app
https://github.com/simonw/datasette/issues/2114#issuecomment-1670454222,https://api.github.com/repos/simonw/datasette/issues/2114,1670454222,IC_kwDOBm6k_c5jkRvO,9599,2023-08-08T23:44:42Z,2023-08-08T23:44:42Z,OWNER,"The tests for this are still passing:

```bash
pytest tests/test_canned_queries.py
```
Because I left in the old code:

https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L752-L767

https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L701-L727","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1822940263,
https://github.com/dogsheep/dogsheep-photos/pull/31#issuecomment-1669877769,https://api.github.com/repos/dogsheep/dogsheep-photos/issues/31,1669877769,IC_kwDOD079W85jiFAJ,22996,2023-08-08T15:52:52Z,2023-08-08T15:52:52Z,NONE,"You can also install this with pip using this oneliner:

```
pip install git+https://github.com/RhetTbull/dogsheep-photos.git@update_for_bigsur
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",771511344,
https://github.com/simonw/datasette/issues/2132#issuecomment-1669640626,https://api.github.com/repos/simonw/datasette/issues/2132,1669640626,IC_kwDOBm6k_c5jhLGy,9599,2023-08-08T13:39:54Z,2023-08-08T13:39:54Z,OWNER,https://github.com/simonw/datasette/blob/1377a290cd85ba8d3338b1da47c4665ed4c6c625/datasette/views/database.py#L509-L517,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1841343173,
https://github.com/simonw/datasette/issues/2113#issuecomment-1668983779,https://api.github.com/repos/simonw/datasette/issues/2113,1668983779,IC_kwDOBm6k_c5jeqvj,9599,2023-08-08T06:27:42Z,2023-08-08T06:27:42Z,OWNER,"I've now shipped the new query JSON without any extras: https://latest.datasette.io/fixtures.json?sql=select+*+from+facetable

There aren't actually that many extras that make sense for the query page. These are the most obvious:

- `query` - adding a `{""sql"": ""..."", ""params"": ""..""}` block, as seen on https://latest.datasette.io/fixtures/facetable.json?_extra=query&_size=0
- `duration_ms` to show the duration - which isn't an extra on table right now but should be.
- `metadata` - https://latest.datasette.io/fixtures/facetable.json?_extra=metadata&_size=0","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1822939274,
https://github.com/simonw/datasette/issues/2117#issuecomment-1668799233,https://api.github.com/repos/simonw/datasette/issues/2117,1668799233,IC_kwDOBm6k_c5jd9sB,9599,2023-08-08T02:02:07Z,2023-08-08T02:02:07Z,OWNER,I just need to pass `view_name` to `datasette.render_template()`.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1822982933,
https://github.com/simonw/datasette/issues/2112#issuecomment-1668798642,https://api.github.com/repos/simonw/datasette/issues/2112,1668798642,IC_kwDOBm6k_c5jd9iy,9599,2023-08-08T02:01:01Z,2023-08-08T02:01:01Z,OWNER,Shipped: https://latest.datasette.io/fixtures?sql=select+*+from+facetable,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1822938661,
https://github.com/simonw/datasette/issues/2111#issuecomment-1668798261,https://api.github.com/repos/simonw/datasette/issues/2111,1668798261,IC_kwDOBm6k_c5jd9c1,9599,2023-08-08T02:00:22Z,2023-08-08T02:00:37Z,OWNER,"Shipped: https://latest.datasette.io/_memory.json?sql=select+sqlite_version()
```json
{
  ""rows"": [
    {
      ""sqlite_version()"": ""3.34.1""
    }
  ],
  ""columns"": [
    ""sqlite_version()""
  ],
  ""ok"": true,
  ""truncated"": false
}
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1822937426,
https://github.com/simonw/datasette/issues/2130#issuecomment-1668793100,https://api.github.com/repos/simonw/datasette/issues/2130,1668793100,IC_kwDOBm6k_c5jd8MM,9599,2023-08-08T01:51:54Z,2023-08-08T01:51:54Z,OWNER,Updated documentation is here: https://docs.datasette.io/en/latest/plugin_hooks.html#register-output-renderer-datasette,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1840329615,
https://github.com/simonw/datasette/issues/2127#issuecomment-1668792576,https://api.github.com/repos/simonw/datasette/issues/2127,1668792576,IC_kwDOBm6k_c5jd8EA,9599,2023-08-08T01:51:14Z,2023-08-08T01:51:14Z,OWNER,"OK, I've landed the first example of this now. I'm cautiously optimistic about it, but I think I need to use it in a few more places AND add the actual code that uses it for documentation before I'm completely happy and close this issue.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1838469176,
https://github.com/simonw/datasette/pull/2118#issuecomment-1668789134,https://api.github.com/repos/simonw/datasette/issues/2118,1668789134,IC_kwDOBm6k_c5jd7OO,9599,2023-08-08T01:46:12Z,2023-08-08T01:46:12Z,OWNER,"I'm going to squash merge this even though it's a bit big, because I want a clean passing commit in the `main` branch.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1823352380,
https://github.com/simonw/datasette/pull/2118#issuecomment-1668786770,https://api.github.com/repos/simonw/datasette/issues/2118,1668786770,IC_kwDOBm6k_c5jd6pS,9599,2023-08-08T01:42:55Z,2023-08-08T01:42:55Z,OWNER,"> UPDATE: Fixed the `_size=max` bit, but I've not replicated the behaviour where it adds `?_labels=on` if there are expandable columns yet.

It looks like that behaviour is only relevant to table views, and it's already implemented - https://latest.datasette.io/fixtures/roadside_attraction_characteristics links to https://latest.datasette.io/fixtures/roadside_attraction_characteristics.csv?_labels=on&_size=max","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1823352380,
https://github.com/simonw/datasette/pull/2118#issuecomment-1668781558,https://api.github.com/repos/simonw/datasette/issues/2118,1668781558,IC_kwDOBm6k_c5jd5X2,9599,2023-08-08T01:34:42Z,2023-08-08T01:34:42Z,OWNER,"3 failures left:
```
=================================================================== short test summary info ====================================================================
FAILED tests/test_html.py::test_query_json_csv_export_links - assert '<a href=""/fixtures.csv?sql=select+1&amp;_size=max"">CSV</a>' in '<!DOCTYPE html>\n<html>\n<head>\n    <title>fixtures: select 1</title>\n    <link r...
FAILED tests/test_api.py::test_cors[/fixtures.json?sql=select+blah-400] - KeyError: 'Access-Control-Allow-Origin'
FAILED tests/test_table_api.py::test_max_returned_rows - KeyError: 'query'
=============================================== 3 failed, 1309 passed, 2 skipped, 1 xfailed in 61.34s (0:01:01) ================================================
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1823352380,