html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,issue,performed_via_github_app https://github.com/simonw/datasette/pull/546#issuecomment-555263597,https://api.github.com/repos/simonw/datasette/issues/546,555263597,MDEyOklzc3VlQ29tbWVudDU1NTI2MzU5Nw==,9599,2019-11-18T23:46:01Z,2019-11-18T23:46:01Z,OWNER,"Also maybe this should be added as a suggested facet if a column clearly contains commas that, when split upon, would result in a array recommendation?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",464987783, https://github.com/simonw/datasette/pull/546#issuecomment-555263426,https://api.github.com/repos/simonw/datasette/issues/546,555263426,MDEyOklzc3VlQ29tbWVudDU1NTI2MzQyNg==,9599,2019-11-18T23:45:23Z,2019-11-18T23:45:23Z,OWNER,Still needs tests and documentation.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",464987783, https://github.com/simonw/datasette/issues/617#issuecomment-555111571,https://api.github.com/repos/simonw/datasette/issues/617,555111571,MDEyOklzc3VlQ29tbWVudDU1NTExMTU3MQ==,9599,2019-11-18T17:04:56Z,2019-11-18T17:04:56Z,OWNER,I made some comments on an annotated version of this method a few days ago: https://gist.github.com/simonw/66aca058195d77bae5f614ef73352eb5,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",519613116, https://github.com/simonw/datasette/issues/620#issuecomment-554869243,https://api.github.com/repos/simonw/datasette/issues/620,554869243,MDEyOklzc3VlQ29tbWVudDU1NDg2OTI0Mw==,9599,2019-11-18T06:16:17Z,2019-11-18T06:16:51Z,OWNER,"I think I should move the `ds.expand_foreign_keys()` method somewhere else: https://github.com/simonw/datasette/blob/c2779e5af0d056ef1637f9f0e191dca421259a5e/datasette/app.py#L355-L390 Moving it to `Database` makes sense to me. The question we then ask it is: ""Given this column containing these values, give me back a dictionary mapping each column and value to a label - `(column, value) -> label`"" Passing in the foreign keys we have calculated as an argument makes sense.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",520667773,