{"html_url": "https://github.com/simonw/datasette/issues/417#issuecomment-586066798", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/417", "id": 586066798, "node_id": "MDEyOklzc3VlQ29tbWVudDU4NjA2Njc5OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-14T02:24:54Z", "updated_at": "2020-02-14T02:24:54Z", "author_association": "OWNER", "body": "I'm going to move this over to a draft pull request.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421546944, "label": "Datasette Library"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/417#issuecomment-586065843", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/417", "id": 586065843, "node_id": "MDEyOklzc3VlQ29tbWVudDU4NjA2NTg0Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-14T02:20:53Z", "updated_at": "2020-02-14T02:20:53Z", "author_association": "OWNER", "body": "MVP for this feature: just do it once on startup, don't scan for new files every X seconds.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421546944, "label": "Datasette Library"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/417#issuecomment-586047525", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/417", "id": 586047525, "node_id": "MDEyOklzc3VlQ29tbWVudDU4NjA0NzUyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-14T01:03:43Z", "updated_at": "2020-02-14T01:59:02Z", "author_association": "OWNER", "body": "OK, I have a plan. I'm going to try and implement this is a core Datasette feature (no plugins) with the following design:\r\n\r\n- You can tell Datasette \"load any databases you find in this directory\" by passing the `--dir=path/to/dir` option to `datasette` that are valid SQLite files and will attach them to Datasette\r\n- Every 10 seconds Datasette will re-scan those directories to see if any new files have been added\r\n- That 10s will be the default for a new `--config directory_scan_s:10` config option. You can set this to `0` to disable scanning entirely, at which point Datasette will only run the scan once on startup.\r\n\r\nTo check if a file is valid SQLite, Datasette will first check if the first few bytes of the file are `b\"SQLite format 3\\x00\"`. If they are, it will open a connection to the file and attempt to run `select * from sqlite_master` against it. If that runs without any errors it will assume the file is usable and connect it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421546944, "label": "Datasette Library"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/417#issuecomment-586047995", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/417", "id": 586047995, "node_id": "MDEyOklzc3VlQ29tbWVudDU4NjA0Nzk5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-14T01:05:20Z", "updated_at": "2020-02-14T01:05:20Z", "author_association": "OWNER", "body": "I'm going to add two methods to the Datasette class to help support this work (and to enable exciting new plugin opportunities in the future):\r\n\r\n- `datasette.add_database(name, db)` - adds a new named database to the list of connected databases. `db` will be a `Database()` object, which may prove useful in the future for things like #670 and could also allow some plugins to provide in-memory SQLite databases.\r\n- `datasette.remove_database(name)`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421546944, "label": "Datasette Library"}, "performed_via_github_app": null}