{"html_url": "https://github.com/simonw/datasette/issues/1432#issuecomment-898084675", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1432", "id": 898084675, "node_id": "IC_kwDOBm6k_c41h69D", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-13T01:11:30Z", "updated_at": "2021-08-13T01:11:30Z", "author_association": "OWNER", "body": "It's only `datasette-publish-vercel` that will break the actual functionality - the others will have broken tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 969855774, "label": "Rename Datasette.__init__(config=) parameter to settings="}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1432#issuecomment-898079507", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1432", "id": 898079507, "node_id": "IC_kwDOBm6k_c41h5sT", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-13T01:08:42Z", "updated_at": "2021-08-13T01:09:41Z", "author_association": "OWNER", "body": "This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=%21datasette%2F**\r\n\r\n> ### datasette-cluster-map/tests/test_cluster_map.py\r\n> \r\n> @pytest.mark.asyncio\r\n> \r\n> async def test_respects_base_url():\r\n> ds = Datasette([], memory=True, config={\"base_url\": \"/foo/\"})\r\n> response = await ds.client.get(\"/:memory:?sql=select+1+as+latitude,+2+as+longitude\")\r\n> assert (\r\n> \r\n> ### datasette-export-notebook/tests/test_export_notebook.py\r\n> \r\n> @pytest.mark.asyncio\r\n> \r\n> async def test_notebook_no_csv(db_path):\r\n> datasette = Datasette([db_path], config={\"allow_csv_stream\": False})\r\n> response = await datasette.client.get(\"/db/big.Notebook\")\r\n> assert \".csv\" not in response.text\r\n> \r\n> ### datasette-publish-vercel/tests/test_publish_vercel.py\r\n> metadata=metadata,\r\n> cors=True,\r\n> config={\"default_page_size\": 10, \"sql_time_limit_ms\": 2000}\r\n> ).app()\r\n> \"\"\"\r\n> \r\n> ### datasette-publish-vercel/datasette_publish_vercel/__init__.py\r\n> metadata=metadata{extras},\r\n> cors=True,\r\n> config={settings}\r\n> \r\n> ).app()\r\n> \r\n> \"\"\".strip()\r\n> \r\n> ### datasette-search-all/tests/test_search_all.py\r\n> \r\n> async def test_base_url(db_path, path):\r\n> sqlite_utils.Database(db_path)[\"creatures\"].enable_fts([\"name\", \"description\"])\r\n> datasette = Datasette([db_path], config={\"base_url\": \"/foo/\"})\r\n> response = await datasette.client.get(path)\r\n> assert response.status_code == 200\r\n\r\nI should fix those as soon as this goes out in a release. I won't close this issue until then.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 969855774, "label": "Rename Datasette.__init__(config=) parameter to settings="}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1432#issuecomment-898074849", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1432", "id": 898074849, "node_id": "IC_kwDOBm6k_c41h4jh", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-08-13T01:03:40Z", "updated_at": "2021-08-13T01:03:40Z", "author_association": "OWNER", "body": "Also this method: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/app.py#L422-L424\r\n\r\nAnd the places that use it:\r\n\r\nhttps://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/base.py#L617\r\n\r\nhttps://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/database.py#L459\r\n\r\nWhich is used in this template: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/templates/table.html#L204\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 969855774, "label": "Rename Datasette.__init__(config=) parameter to settings="}, "performed_via_github_app": null}