{"html_url": "https://github.com/simonw/sqlite-utils/issues/66#issuecomment-553171414", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/66", "id": 553171414, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MzE3MTQxNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T23:52:35Z", "updated_at": "2019-11-12T23:52:35Z", "author_association": "OWNER", "body": "If I do implement the correct definition of `.upsert()` I think I'll use this pattern, since it works in versions of SQLite prior to 3.24:\r\n```sql\r\nINSERT OR IGNORE INTO book(id) VALUES(1001);\r\nUPDATE book SET name = 'Programming' WHERE id = 1001;\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 521868864, "label": "The \".upsert()\" method is misnamed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/66#issuecomment-553171011", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/66", "id": 553171011, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MzE3MTAxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T23:50:52Z", "updated_at": "2019-11-12T23:50:52Z", "author_association": "OWNER", "body": "Fixing this is going to be a real pain. There's lots of code out there that uses `sqlite-utils` with the expectation that `upsert()` behaves as it currently does.\r\n\r\nMaybe I need to introduce new terms for both of these different patterns and deprecate the existing `.upsert()` and `.upsert_all()` since their behaviour can't be changed?\r\n\r\nOr maybe I fix this and ship `sqlite-utils 2.0` with a breaking change?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 521868864, "label": "The \".upsert()\" method is misnamed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/66#issuecomment-553170650", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/66", "id": 553170650, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MzE3MDY1MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T23:49:29Z", "updated_at": "2019-11-12T23:49:29Z", "author_association": "OWNER", "body": "This relates to this bug: https://github.com/dogsheep/github-to-sqlite/pull/8#issuecomment-549233778", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 521868864, "label": "The \".upsert()\" method is misnamed"}, "performed_via_github_app": null}