{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355823260", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355823260, "node_id": "IC_kwDOBm6k_c5Q0Dic", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T23:36:07Z", "updated_at": "2022-12-16T23:36:07Z", "author_association": "OWNER", "body": "I ran `pytest --pdb -x` to drop into the debugger on the first failing test.\r\n\r\n```\r\n        assert expected_rows == len(fetched)\r\n>       assert expected_pages == count\r\nE       assert 9 == 5\r\n```\r\nThat's in `test_paginate_tables_and_views()`.\r\n\r\nOn a hunch, I checked the current settings:\r\n\r\n```\r\n(Pdb) ds_client.ds._settings\r\n{'default_page_size': 50, 'max_returned_rows': 100, 'max_insert_rows': 100, 'num_sql_threads': 1, 'sql_time_limit_ms': 200, 'default_facet_size': 30, 'facet_time_limit_ms': 200, 'facet_suggest_time_limit_ms': 50, 'allow_facet': True, 'allow_download': True, 'allow_signed_tokens': True, 'max_signed_tokens_ttl': 0, 'suggest_facets': True, 'default_cache_ttl': 5, 'cache_size_kb': 0, 'allow_csv_stream': True, 'max_csv_mb': 100, 'truncate_cells_html': 2048, 'force_https_urls': False, 'template_debug': False, 'trace_debug': False, 'base_url': '/'}\r\n```\r\nLooks like something changed `default_page_size` to 50 and forgot to change it back!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355685828", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355685828, "node_id": "IC_kwDOBm6k_c5Qzh_E", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T21:50:01Z", "updated_at": "2022-12-16T21:50:01Z", "author_association": "OWNER", "body": "Looks like that `@pytest.mark.ds_client` mark I've been using isn't necessary - I added that so I could easily run `pytest -m ds_client` to execute all tests that I had ported to the new feature, but actually this achieves the same thing:\r\n\r\n    pytest -k ds_client\r\n\r\nSo I'm going to remove the mark.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355478743", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355478743, "node_id": "IC_kwDOBm6k_c5QyvbX", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T19:27:12Z", "updated_at": "2022-12-16T19:27:12Z", "author_association": "OWNER", "body": "Bad news: they're definitely caused by tests that are subtly affected by other tests.\r\n\r\nThis passes without errors:\r\n\r\n    pytest -k test_paginate_tables_and_views", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355475671", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355475671, "node_id": "IC_kwDOBm6k_c5QyurX", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T19:26:08Z", "updated_at": "2022-12-16T19:26:08Z", "author_association": "OWNER", "body": "Great news! The test failures I got running on my laptop (with that fresh Ubuntu Docker image) look like they match the failures I saw in CI:\r\n\r\n```\r\n======== short test summary info ========\r\nFAILED tests/test_table_api.py::test_paginate_tables_and_views[/fixtures/paginated_view.json-201-9] - assert 9 == 5\r\nFAILED tests/test_table_api.py::test_sortable_columns_metadata - KeyError: 'error'\r\nFAILED tests/test_table_api.py::test_searchable_views[/fixtures/searchable_view_configured_by_metadata.json?_search=weasel-expected_rows0] - AssertionError: assert [[2, 'terry d...sel', 'puma']] == [[1, 'barry c...sel', 'puma']]\r\nFAILED tests/test_table_api.py::test_unit_filters - KeyError: 'distance'\r\nFAILED tests/test_table_api.py::test_custom_query_with_unicode_characters - AssertionError: assert {'error': 'Ta...'title': None} == [{'id': 1, 'n...n Francisco'}]\r\nFAILED tests/test_table_html.py::test_sort_links - AssertionError: assert [{'a_href': N...', ...}}, ...] == [{'a_href': N...', ...}}, ...]\r\nFAILED tests/test_table_html.py::test_table_html_no_primary_key - AttributeError: 'NoneType' object has no attribute 'strip'\r\nFAILED tests/test_table_html.py::test_table_html_foreign_key_custom_label_column - assert [['<td class=...1</em></td>']] == [['<td class=...>1</a></td>']]\r\nFAILED tests/test_table_html.py::test_view_html - assert <a href=\"/fixtures/simple_view?_size=3&amp;_sort=upper_content\" rel=\"nofollow\">upper_content</a> is None\r\nFAILED tests/test_table_html.py::test_table_metadata - AssertionError: assert 'This &lt;em&...t; is escaped' == 'simple_primary_key'\r\nFAILED tests/test_table_html.py::test_metadata_sort - AssertionError: assert ['id', 'name\\xa0\u25bc'] == ['id\\xa0\u25bc', 'name']\r\nFAILED tests/test_table_html.py::test_metadata_sort_desc - AssertionError: assert ['pk\\xa0\u25b2', 'name'] == ['pk\\xa0\u25bc', 'name']\r\nFAILED tests/test_table_html.py::test_column_metadata - AttributeError: 'NoneType' object has no attribute 'findAll'\r\n======== 13 failed, 1279 passed, 3 skipped, 57 warnings in 572.40s (0:09:32) ========\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355471341", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355471341, "node_id": "IC_kwDOBm6k_c5Qytnt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T19:23:33Z", "updated_at": "2022-12-16T19:23:33Z", "author_association": "OWNER", "body": "Trying this instead:\r\n```\r\ndocker run -it ubuntu:22.04 /bin/bash\r\n```\r\nThen in that shell:\r\n```\r\napt-get update\r\napt-get install python3.11 python3.11-venv git -y\r\ncd /tmp\r\ngit clone https://github.com/simonw/datasette\r\ncd datasette\r\ngit checkout async-tests\r\npython3.11 -m venv venv\r\npip install -e '.[test]'\r\npytest\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355445710", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355445710, "node_id": "IC_kwDOBm6k_c5QynXO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T19:06:49Z", "updated_at": "2022-12-16T19:09:35Z", "author_association": "OWNER", "body": "This would be much easier to debug if I could use Docker to run the GitHub Actions image directly on my own laptop.\r\n\r\nhttps://github.com/actions/runner-images/blob/releases/ubuntu22/20221212/images/linux/Ubuntu2204-Readme.md is the README for their most recent image. Not sure if there's an easy way to run it in Docker though.\r\n\r\nhttps://github.com/actions/runner-images/blob/main/docs/create-image-and-azure-resources.md is instructions for building them locally - looks fiddly though, involves https://www.packer.io/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355325426", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355325426, "node_id": "IC_kwDOBm6k_c5QyJ_y", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T18:00:40Z", "updated_at": "2022-12-16T18:00:40Z", "author_association": "OWNER", "body": "Many of the failing tests pass on my laptop but fail in CI.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355319541", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355319541, "node_id": "IC_kwDOBm6k_c5QyIj1", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T17:58:24Z", "updated_at": "2022-12-16T17:58:46Z", "author_association": "OWNER", "body": "> I tried adding `invoke_startup()` to the `ds_client()` fixture to see if that would fix this.\r\n\r\nIt did not: I'm still seeing those same failures. Frustrating: https://github.com/simonw/datasette/actions/runs/3715317653/jobs/6300336884\r\n\r\n    ====== 11 failed, 1252 passed, 1 skipped, 1 warning in 185.77s (0:03:05) =======", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355317369", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355317369, "node_id": "IC_kwDOBm6k_c5QyIB5", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T17:57:14Z", "updated_at": "2022-12-16T17:57:14Z", "author_association": "OWNER", "body": "Opened a follow-up issue here:\r\n- #1962", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355313058", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355313058, "node_id": "IC_kwDOBm6k_c5QyG-i", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T17:53:17Z", "updated_at": "2022-12-16T17:53:17Z", "author_association": "OWNER", "body": "Got some surprising test failures here: https://github.com/simonw/datasette/actions/runs/3715317653/jobs/6300336626\r\n```\r\n>       assert response.json() == [{\"id\": 1, \"name\": \"San Francisco\"}]\r\nE       AssertionError: assert {'error': 'Ta...'title': None} == [{'id': 1, 'n...n Francisco'}]\r\nE         Full diff:\r\nE         - [{'id': 1, 'name': 'San Francisco'}]\r\nE         + {'error': 'Table not found: \ud835\udc1c\ud835\udc22\ud835\udc2d\ud835\udc22\ud835\udc1e\ud835\udc2c', 'ok': False, 'status': 404, 'title': None}\r\n```\r\nA hunch: this failure suggests that maybe the fixtures tables were not correctly created when this test run. Maybe that can happen when `python -n auto` runs a bunch of separate processes and hence one of the tests randomly gets run in a fresh process and executes before the in-memory fixtures database has been fully populated.\r\n\r\nI tried adding `invoke_startup()` to the `ds_client()` fixture to see if that would fix this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1355300217", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1355300217, "node_id": "IC_kwDOBm6k_c5QyD15", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T17:44:55Z", "updated_at": "2022-12-16T17:44:55Z", "author_association": "OWNER", "body": "That's enough for this round. I'll get the tests passing and land this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354269873", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354269873, "node_id": "IC_kwDOBm6k_c5QuISx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T06:11:43Z", "updated_at": "2022-12-16T06:11:43Z", "author_association": "OWNER", "body": "This is quite fast:\r\n```\r\n% pytest -m ds_client -n auto\r\n================================================================================== test session starts ==================================================================================\r\nplatform darwin -- Python 3.10.3, pytest-7.1.3, pluggy-1.0.0\r\nSQLite: 3.39.4\r\nrootdir: /Users/simon/Dropbox/Development/datasette, configfile: pytest.ini\r\nplugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, asyncio-0.19.0, timeout-2.1.0, profiling-1.7.0\r\nasyncio: mode=strict\r\ngw0 [291] / gw1 [291] / gw2 [291] / gw3 [291] / gw4 [291] / gw5 [291]\r\n................................................................................................................................................................................. [ 60%]\r\n..................................................................................................................                                                                [100%]\r\n================================================================================== 291 passed in 6.30s ==================================================================================\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354148139", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354148139, "node_id": "IC_kwDOBm6k_c5Qtqkr", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T03:32:52Z", "updated_at": "2022-12-16T03:32:52Z", "author_association": "OWNER", "body": "Got that done to: 68 passed in 14.92s\r\n\r\nBy implementing my own global variable - since `pytest` won't use a global fixture for me, I decided to do it for myself.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354072344", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354072344, "node_id": "IC_kwDOBm6k_c5QtYEY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T02:00:07Z", "updated_at": "2022-12-16T02:00:07Z", "author_association": "OWNER", "body": "It did NOT speed it up:\r\n\r\n68 passed in 26.26s", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354061440", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354061440, "node_id": "IC_kwDOBm6k_c5QtVaA", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T01:45:38Z", "updated_at": "2022-12-16T01:45:38Z", "author_association": "OWNER", "body": "I'm going to do `test_table_html.py` next.\r\n\r\nCurrently: 68 passed in 17.20s\r\n\r\nWill this speed it up?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354053151", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354053151, "node_id": "IC_kwDOBm6k_c5QtTYf", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T01:33:22Z", "updated_at": "2022-12-16T01:33:22Z", "author_association": "OWNER", "body": "The thing with `Datasette(memory=False)` is tripping me up.\r\n\r\nThe problem is that the tests written against `app_client` - which I want to replace - all assume that there is no `_memory` database, because when you start Datasette with at least one database file it doesn't enable `_memory` unless you explicitly tell it to.\r\n\r\nBut the new `ds_client` fixture works by creating a named in-memory database called `fixtures`, which it does with a call to `ds.add_memory_database(\"fixtures\")` after the object has been instantiated.\r\n\r\nThis results in a datasette instance that DOES have a `_memory` database, when we didn't want one.\r\n\r\nMy initial solution attempt was a huge hack - I decided that if you pass `memory=False` to the `Datasette` constructor it should mean \"don't add a `_memory` database even though I didn't pass any files\". I set a the default `memory` argument to `None`.\r\n\r\nThis is weird and surprising (`memory=False` no does something different from `memory=None`?) and I found other tests that it broke, like this one:\r\n\r\n```python\r\ndef test_sql_errors_logged_to_stderr():\r\n    runner = CliRunner(mix_stderr=False)\r\n    result = runner.invoke(cli, [\"--get\", \"/_memory.json?sql=select+blah\"])\r\n    assert result.exit_code == 1\r\n    assert \"sql = 'select blah', params = {}: no such column: blah\\n\" in result.stderr\r\n```\r\nIt ended up with no `_memory` database because it turns out `datasette serve ...` passes `memory=False` without me realizing it.\r\n\r\nSo I'm going to undo that hack and teach the fixture to do this instead:\r\n\r\n```python\r\ndb = ds.add_memory_database(\"fixtures\")\r\nds.remove_database(\"_memory\")\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354046627", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354046627, "node_id": "IC_kwDOBm6k_c5QtRyj", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T01:23:21Z", "updated_at": "2022-12-16T01:23:21Z", "author_association": "OWNER", "body": "This does seem to help:\r\n```diff\r\ndiff --git a/tests/conftest.py b/tests/conftest.py\r\nindex 1306c407..af9c7696 100644\r\n--- a/tests/conftest.py\r\n+++ b/tests/conftest.py\r\n@@ -25,12 +25,7 @@ UNDOCUMENTED_PERMISSIONS = {\r\n }\r\n \r\n \r\n-@pytest.fixture(scope=\"session\")\r\n-def event_loop():\r\n-    return asyncio.get_event_loop()\r\n-\r\n-\r\n-@pytest_asyncio.fixture(scope=\"session\")\r\n+@pytest_asyncio.fixture\r\n async def ds_client():\r\n     from datasette.app import Datasette\r\n     from .fixtures import METADATA, PLUGINS_DIR\r\n@@ -53,10 +48,11 @@ async def ds_client():\r\n     db = ds.add_memory_database(\"fixtures\")\r\n \r\n     def prepare(conn):\r\n-        conn.executescript(TABLES)\r\n-        for sql, params in TABLE_PARAMETERIZED_SQL:\r\n-            with conn:\r\n-                conn.execute(sql, params)\r\n+        if not conn.execute(\"select count(*) from sqlite_master\").fetchone()[0]:\r\n+            conn.executescript(TABLES)\r\n+            for sql, params in TABLE_PARAMETERIZED_SQL:\r\n+                with conn:\r\n+                    conn.execute(sql, params)\r\n \r\n     await db.execute_write_fn(prepare)\r\n     return ds.client\r\ndiff --git a/tests/plugins/my_plugin_2.py b/tests/plugins/my_plugin_2.py\r\nindex 4f7bf08c..d588342c 100644\r\n--- a/tests/plugins/my_plugin_2.py\r\n+++ b/tests/plugins/my_plugin_2.py\r\n@@ -117,7 +117,12 @@ def actor_from_request(datasette, request):\r\n def permission_allowed(datasette, actor, action):\r\n     # Testing asyncio version of permission_allowed\r\n     async def inner():\r\n-        assert 2 == (await datasette.get_database().execute(\"select 1 + 1\")).first()[0]\r\n+        assert (\r\n+            2\r\n+            == (\r\n+                await datasette.get_database(\"_internal\").execute(\"select 1 + 1\")\r\n+            ).first()[0]\r\n+        )\r\n         if action == \"this_is_allowed_async\":\r\n             return True\r\n         elif action == \"this_is_denied_async\":\r\n```\r\n`pytest -m ds_client` now passes 134 tests.\r\n\r\nNeed to get `pytest -n auto` passing too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1960#issuecomment-1354036967", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1960", "id": 1354036967, "node_id": "IC_kwDOBm6k_c5QtPbn", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-16T01:10:12Z", "updated_at": "2022-12-16T01:10:12Z", "author_association": "OWNER", "body": "If it does turn out that I can't use `scope=\"session\"` on this fixture it might not actually be a showstopper: I can take advantage of the fact that `memory_name=\"...\"` databases stay present in memory for the duration of the process, so I could have it such that each test that uses the `ds_client` fixture DOES construct a fresh `Datasette` instance, but doesn't need to populate the database since they can re-use the in-memory database from the previous object.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1499150951, "label": "Port as many tests as possible to async def tests against ds_client"}, "performed_via_github_app": null}