{"html_url": "https://github.com/simonw/datasette/issues/462#issuecomment-491545952", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/462", "id": 491545952, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU0NTk1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T21:41:49Z", "updated_at": "2019-05-11T21:41:49Z", "author_association": "OWNER", "body": "I now need to update `datasette serve ... --inspect-data=X` to understand and correctly handle the new format.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 443023308, "label": "Replace most of `.inspect()` (and `datasette inspect`) with table counting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/462#issuecomment-491543817", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/462", "id": 491543817, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU0MzgxNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T21:06:13Z", "updated_at": "2019-05-11T21:06:13Z", "author_association": "OWNER", "body": "I'm going to change it to output to stdout unless you pass it the `--inspect-file` argument.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 443023308, "label": "Replace most of `.inspect()` (and `datasette inspect`) with table counting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/462#issuecomment-491543785", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/462", "id": 491543785, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU0Mzc4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T21:05:54Z", "updated_at": "2019-05-11T21:05:54Z", "author_association": "OWNER", "body": "So I think `datasette inspect fixtures.db other.db` should output something like this:\r\n\r\n```json\r\n{\r\n  \"fixtures\": {\r\n    \"hash\": \"894870db97229e9e18b40921dc32b581da813465d672445e96e040ab2adbd229\",\r\n    \"file\": \"fixtures.db\",\r\n    \"size\": 225280,\r\n    \"tables\": {\r\n      \"facetable\": {\r\n        \"count\": 34,\r\n      }\r\n   }\r\n}\r\n```\r\n\r\nIt currently writes it out to a file called `inspect-data.json`. Should I keep that as the default behaviour or switch it to outputting to stdout instead?\r\n\r\nHere's the current `datasette inspect --help`:\r\n\r\n```$ datasette inspect --help\r\nUsage: datasette inspect [OPTIONS] [FILES]...\r\n\r\nOptions:\r\n  --inspect-file TEXT\r\n  --load-extension PATH  Path to a SQLite extension to load\r\n  --help                 Show this message and exit.```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 443023308, "label": "Replace most of `.inspect()` (and `datasette inspect`) with table counting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/462#issuecomment-491543635", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/462", "id": 491543635, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU0MzYzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T21:03:10Z", "updated_at": "2019-05-11T21:03:23Z", "author_association": "OWNER", "body": "`test_inspect.py` currently just contains two tests that exercise a small portion of what `.inspect()` does - I'm going to repurpose that module and have it only test the `datasette inspect` CLI command instead.\r\n\r\nHere's the current contents of that file: https://github.com/simonw/datasette/blob/ce09e5d2d392634eced44c3c8d603d7c628e2822/tests/test_inspect.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 443023308, "label": "Replace most of `.inspect()` (and `datasette inspect`) with table counting"}, "performed_via_github_app": null}