{"html_url": "https://github.com/simonw/datasette/issues/1558#issuecomment-996204369", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1558", "id": 996204369, "node_id": "IC_kwDOBm6k_c47YN9R", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-16T21:23:25Z", "updated_at": "2021-12-16T21:23:25Z", "author_association": "OWNER", "body": "Related: Following the fix for #625 I noticed that `facets_timed_out` gives you just the column name, but doesn't let you know which particular type of facet (`date` or `array` for example) suffered the timeout: https://github.com/simonw/datasette/blob/0d4145d0f4d8b2a7edc1ba4aac1be56cd536a10a/datasette/facets.py#L269-L270\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082584499, "label": "Redesign `facet_results` JSON structure prior to Datasette 1.0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1558#issuecomment-996134716", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1558", "id": 996134716, "node_id": "IC_kwDOBm6k_c47X888", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-16T19:46:21Z", "updated_at": "2021-12-16T19:46:21Z", "author_association": "OWNER", "body": "The flaw in the current design is illustrated by this example:\r\n\r\n```\r\n  \"facet_results\": {\r\n    \"tags\": {\r\n      \"name\": \"tags\",\r\n      \"type\": \"array\",\r\n      \"results\": [...],\r\n      \"hideable\": false,\r\n      \"toggle_url\": \"/fixtures/facetable.json?_facet=tags&_trace=1&_nosuggest=1\",\r\n      \"truncated\": false\r\n    },\r\n    \"created\": {\r\n      \"name\": \"created\",\r\n      \"type\": \"date\",\r\n      \"results\": [...]\r\n```\r\nThis was the cause of the bug in #625 - the each of those objects is keyed by the name of the column, which left no room for faceting the same column once by date and once by column value.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082584499, "label": "Redesign `facet_results` JSON structure prior to Datasette 1.0"}, "performed_via_github_app": null}