{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071813296, "node_id": "IC_kwDOBm6k_c4_4pKw", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:26:22Z", "updated_at": "2022-03-17T23:26:22Z", "author_association": "OWNER", "body": "Probably caused by the convoluted code is `get_format()`: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L466-L481", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071809988, "node_id": "IC_kwDOBm6k_c4_4oXE", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:24:57Z", "updated_at": "2022-03-17T23:24:57Z", "author_association": "OWNER", "body": "My hunch is that this is broken because of this:\r\n\r\nhttps://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/app.py#L1098-L1107\r\n\r\nNote how the table uses `table_and_format` but the row uses just `table` - I think there's code that's getting confused by this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071803114, "node_id": "IC_kwDOBm6k_c4_4mrq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:22:00Z", "updated_at": "2022-03-17T23:22:00Z", "author_association": "OWNER", "body": "Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:\r\n\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071797707, "node_id": "IC_kwDOBm6k_c4_4lXL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:19:24Z", "updated_at": "2022-03-17T23:19:24Z", "author_association": "OWNER", "body": "Moving this to PR so I can comment on individual lines:\r\n- #1664", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071793307, "node_id": "IC_kwDOBm6k_c4_4kSb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:17:32Z", "updated_at": "2022-03-17T23:17:32Z", "author_association": "OWNER", "body": "Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:\r\n\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071706993, "node_id": "IC_kwDOBm6k_c4_4PNx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T22:42:21Z", "updated_at": "2022-03-17T22:42:21Z", "author_association": "OWNER", "body": "As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173\r\n\r\nUnwrapping `request.scope[\"url_route\"][\"kwargs\"]` into keyword argument to view functions just made the code harder to follow.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1663#issuecomment-1071519407", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1663", "id": 1071519407, "node_id": "IC_kwDOBm6k_c4_3hav", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T21:32:35Z", "updated_at": "2022-03-17T21:32:35Z", "author_association": "OWNER", "body": "Updated docs:\r\n- https://docs.datasette.io/en/latest/internals.html#datasette-class\r\n- https://docs.datasette.io/en/latest/internals.html#db-hash", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170554975, "label": "Document the internals that were used in datasette-hashed-urls"}, "performed_via_github_app": null}