{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1695754277", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1695754277, "node_id": "IC_kwDOBm6k_c5lEygl", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-08-28T14:00:17Z", "updated_at": "2023-08-29T00:32:52Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch and project coverage have no change.\n> Comparison is base [(`2e28258`)](https://app.codecov.io/gh/simonw/datasette/commit/2e2825869fc2655b5fcadc743f6f9dec7a49bc65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82% compared to head [(`c81b024`)](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82%.\n\n> :exclamation: Current head c81b024 differs from pull request most recent head 3529c9c. Consider uploading reports for the commit 3529c9c to get more accurate results\n\n<details><summary>Additional details and impacted files</summary>\n\n\n```diff\n@@           Coverage Diff           @@\n##             main    #2160   +/-   ##\n=======================================\n  Coverage   92.82%   92.82%           \n=======================================\n  Files          40       40           \n  Lines        5948     5948           \n=======================================\n  Hits         5521     5521           \n  Misses        427      427           \n```\n\n\n\n\n</details>\n\n[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).   \n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2102#issuecomment-1696378239", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2102", "id": 1696378239, "node_id": "IC_kwDOBm6k_c5lHK1_", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-28T20:38:01Z", "updated_at": "2023-08-28T20:38:01Z", "author_association": "OWNER", "body": "I want to test \"for this set of restrictions, does a GET/POST to this path return 200 or 403\"?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1805076818, "label": "API tokens with view-table but not view-database/view-instance cannot access the table"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2102#issuecomment-1696361304", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2102", "id": 1696361304, "node_id": "IC_kwDOBm6k_c5lHGtY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-28T20:23:47Z", "updated_at": "2023-08-28T20:24:35Z", "author_association": "OWNER", "body": "Here's an existing relevant test:\r\n\r\nhttps://github.com/simonw/datasette/blob/2e2825869fc2655b5fcadc743f6f9dec7a49bc65/tests/test_permissions.py#L616-L666\r\n\r\nIt's not quite right for this new set of tests though, since they need to be exercising actual endpoints (`/.json` etc) in order to check that this works correctly.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1805076818, "label": "API tokens with view-table but not view-database/view-instance cannot access the table"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2153#issuecomment-1696355634", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2153", "id": 1696355634, "node_id": "IC_kwDOBm6k_c5lHFUy", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-28T20:19:15Z", "updated_at": "2023-08-28T20:19:15Z", "author_association": "OWNER", "body": "Documentation:\r\n- https://docs.datasette.io/en/latest/cli-reference.html#datasette-get\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1865232341, "label": "Datasette --get --actor option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2161#issuecomment-1696267473", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2161", "id": 1696267473, "node_id": "IC_kwDOBm6k_c5lGvzR", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-08-28T19:38:28Z", "updated_at": "2023-08-28T19:39:33Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch coverage: **`75.00%`** and project coverage change: **`+0.05%`** :tada:\n> Comparison is base [(`527cec6`)](https://app.codecov.io/gh/simonw/datasette/commit/527cec66b0403e689c8fb71fc8b381a1d7a46516?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.76% compared to head [(`a5cbf80`)](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.81%.\n\n<details><summary>Additional details and impacted files</summary>\n\n\n```diff\n@@            Coverage Diff             @@\n##             main    #2161      +/-   ##\n==========================================\n+ Coverage   92.76%   92.81%   +0.05%     \n==========================================\n  Files          40       40              \n  Lines        5943     5944       +1     \n==========================================\n+ Hits         5513     5517       +4     \n+ Misses        430      427       -3     \n```\n\n\n| [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/cli.py](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `82.37% <75.00%> (+1.02%)` | :arrow_up: |\n\n\n</details>\n\n[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).   \n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1870345352, "label": "-s/--setting x y gets merged into datasette.yml, refs #2143, #2156"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2156#issuecomment-1696260446", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2156", "id": 1696260446, "node_id": "IC_kwDOBm6k_c5lGuFe", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-28T19:33:05Z", "updated_at": "2023-08-28T19:33:05Z", "author_association": "OWNER", "body": "Now a PR:\r\n- #2161 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1865649347, "label": "datasette -s/--setting option for setting nested configuration options"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2152#issuecomment-1695736691", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2152", "id": 1695736691, "node_id": "IC_kwDOBm6k_c5lEuNz", "user": {"value": 49699333, "label": "dependabot[bot]"}, "created_at": "2023-08-28T13:49:35Z", "updated_at": "2023-08-28T13:49:35Z", "author_association": "CONTRIBUTOR", "body": "Superseded by #2160.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1865174661, "label": "Bump the python-packages group with 3 updates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/588#issuecomment-1694823972", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/588", "id": 1694823972, "node_id": "IC_kwDOCGYnMM5lBPYk", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-28T00:41:54Z", "updated_at": "2023-08-28T00:41:54Z", "author_association": "OWNER", "body": "Tips on typing `**kwargs`: https://adamj.eu/tech/2021/05/11/python-type-hints-args-and-kwargs/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1868713944, "label": "`table.get(column=value)` option for retrieving things not by their primary key"}, "performed_via_github_app": null}