{"html_url": "https://github.com/simonw/datasette/pull/2162#issuecomment-1696710911", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2162", "id": 1696710911, "node_id": "IC_kwDOBm6k_c5lIcD_", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T03:23:44Z", "updated_at": "2023-08-29T03:23:44Z", "author_association": "OWNER", "body": "I'm going to merge this so we can see how it feels.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1870672704, "label": "Add new `--internal internal.db` option, deprecate legacy `_internal` database"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2162#issuecomment-1696709110", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2162", "id": 1696709110, "node_id": "IC_kwDOBm6k_c5lIbn2", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T03:20:40Z", "updated_at": "2023-08-29T03:22:47Z", "author_association": "OWNER", "body": "> However, one important notes about those new `core_` tables: If a `--internal` DB is passed in, that means those `core_` tables will persist across multiple Datasette instances. This wasn't the case before, since `_internal` was always an in-memory database created from scratch.\r\n\r\nI'm completely happy for the `core_*` tables (or `datasette_*` or some other name) to live in the persisted-to-disk `internal.db` database, even though they're effectively meant to be an in-memory cache.\r\n\r\nI don't think it causes any harm, and it could even be quite useful to have them visible on disk - other applications could read the `internal.db` database while Datasette itself is running, should they have some weird reason to want to do that!\r\n\r\nHaving those tables stick around in `internal.db` after Datasette shuts down could be useful for other debugging activities as well.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1870672704, "label": "Add new `--internal internal.db` option, deprecate legacy `_internal` database"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2162#issuecomment-1696594855", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2162", "id": 1696594855, "node_id": "IC_kwDOBm6k_c5lH_un", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-08-29T00:19:29Z", "updated_at": "2023-08-29T03:22:21Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch coverage: **`100.00%`** and project coverage change: **`-0.03%`** :warning:\n> Comparison is base [(`2e28258`)](https://app.codecov.io/gh/simonw/datasette/commit/2e2825869fc2655b5fcadc743f6f9dec7a49bc65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82% compared to head [(`73489ca`)](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.79%.\n> Report is 1 commits behind head on main.\n\nAdditional details and impacted files
\n\n\n```diff\n@@ Coverage Diff @@\n## main #2162 +/- ##\n==========================================\n- Coverage 92.82% 92.79% -0.03% \n==========================================\n Files 40 40 \n Lines 5948 5953 +5 \n==========================================\n+ Hits 5521 5524 +3 \n- Misses 427 429 +2 \n```\n\n\n| [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/default\\_permissions.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RlZmF1bHRfcGVybWlzc2lvbnMucHk=) | `96.87% <\u00f8> (-0.04%)` | :arrow_down: |\n| [datasette/app.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.32% <100.00%> (+0.03%)` | :arrow_up: |\n| [datasette/cli.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `82.53% <100.00%> (-0.06%)` | :arrow_down: |\n| [datasette/database.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RhdGFiYXNlLnB5) | `94.72% <100.00%> (+0.04%)` | :arrow_up: |\n| [datasette/utils/internal\\_db.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL2ludGVybmFsX2RiLnB5) | `100.00% <100.00%> (\u00f8)` | |\n| [datasette/views/database.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `95.45% <100.00%> (\u00f8)` | |\n| [datasette/views/special.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3NwZWNpYWwucHk=) | `94.06% <100.00%> (-0.85%)` | :arrow_down: |\n\n\n