{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-391505930", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 391505930, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTUwNTkzMA==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-05-23T21:41:37Z", "updated_at": "2018-05-23T21:41:37Z", "author_association": "CONTRIBUTOR", "body": "> I'm not keen on anything that modifies the SQLite file itself on startup\r\n\r\nAh I didn't mean that - I meant altering the SELECT query to fetch the data so that it ran a spatialite function to transform that specific column.\r\n\r\nI think that's less useful as a general-purpose plugin hook though, and it's not that hard to parse the WKB in Python (my default approach would be to use [shapely](https://github.com/Toblerity/Shapely), which is great, but geomet looks like an interesting pure-python alternative).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-391504757", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 391504757, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTUwNDc1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T21:37:07Z", "updated_at": "2018-05-23T21:37:18Z", "author_association": "OWNER", "body": "That said, it looks like we may be able to use a library like https://github.com/geomet/geomet to run the conversion from WKB entirely in Python space.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-391504199", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 391504199, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTUwNDE5OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T21:35:17Z", "updated_at": "2018-05-23T21:35:17Z", "author_association": "OWNER", "body": "I'm not keen on anything that modifies the SQLite file itself on startup - part of the datasette contract is that it should work with any SQLite file you throw at it without having any side-effects.\r\n\r\nA neat thing about SQLite is that because everything happens in the same process there's very little additional overhead involved in executing extra SQL queries - even if we ran a query-per-row to transform data in one specific column it shouldn't add more than a few ms to the total page load time (whereas with MySQL all of the extra query overhead would kill us).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/281#issuecomment-391437462", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/281", "id": 391437462, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTQzNzQ2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T17:45:07Z", "updated_at": "2018-05-23T17:45:07Z", "author_association": "OWNER", "body": "I'm afraid I just merged #280 which means this no longer applies. You're very welcome to see if you can further optimize the new Dockerfile though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325553991, "label": "Reduces image size using Alpine + Multistage (re: #278)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391437199", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391437199, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTQzNzE5OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T17:44:20Z", "updated_at": "2018-05-23T17:44:20Z", "author_association": "OWNER", "body": "Thank you very much! This is most excellent.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391355030", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391355030, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTM1NTAzMA==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-23T13:53:27Z", "updated_at": "2018-05-23T15:22:45Z", "author_association": "CONTRIBUTOR", "body": "No objections;\r\nIt's good to go @simonw\r\n\r\nOn Wed, 23 May 2018, 14:51 Simon Willison, <notifications@github.com> wrote:\r\n\r\n> @r4vi <https://github.com/r4vi> any objections to me merging this?\r\n>\r\n> \u2014\r\n> You are receiving this because you were mentioned.\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/simonw/datasette/pull/280#issuecomment-391354237>, or mute\r\n> the thread\r\n> <https://github.com/notifications/unsubscribe-auth/AAihfM_2DN5WR2mkO-VK6ozDmkUQ4IMjks5t1WlcgaJpZM4UI_2m>\r\n> .\r\n>\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/282#issuecomment-391355099", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/282", "id": 391355099, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTM1NTA5OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T13:53:39Z", "updated_at": "2018-05-23T13:53:39Z", "author_association": "OWNER", "body": "Confirmed fixed: https://fivethirtyeight-datasette-mipwbeadvr.now.sh/fivethirtyeight-5de27e3/nba-elo%2Fnbaallelo?_facet=lg_id&_next=100 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325705981, "label": "Faceting breaks pagination"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391354237", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391354237, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTM1NDIzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T13:51:22Z", "updated_at": "2018-05-23T13:51:22Z", "author_association": "OWNER", "body": "@r4vi any objections to me merging this?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391290271", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391290271, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTI5MDI3MQ==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-23T09:53:38Z", "updated_at": "2018-05-23T09:53:38Z", "author_association": "CONTRIBUTOR", "body": "Running:\r\n```bash\r\ndocker run -p 8001:8001 -v `pwd`:/mnt datasette \\\r\n    datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \\\r\n        --load-extension=/usr/local/lib/mod_spatialite.so\r\n```\r\n\r\nis now returning FTS5 enabled in the versions output:\r\n\r\n```json\r\n{\r\n    \"datasette\": {\r\n        \"version\": \"0.22\"\r\n    },\r\n    \"python\": {\r\n        \"full\": \"3.6.5 (default, May  5 2018, 03:07:21) \\n[GCC 6.3.0 20170516]\",\r\n        \"version\": \"3.6.5\"\r\n    },\r\n    \"sqlite\": {\r\n        \"extensions\": {\r\n            \"json1\": null,\r\n            \"spatialite\": \"4.4.0-RC0\"\r\n        },\r\n        \"fts_versions\": [\r\n            \"FTS5\",\r\n            \"FTS4\",\r\n            \"FTS3\"\r\n        ],\r\n        \"version\": \"3.23.1\"\r\n    }\r\n}\r\n```\r\nThe old query didn't work because specifying `(t TEXT)` caused an error", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391190497", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391190497, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTE5MDQ5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-23T01:22:53Z", "updated_at": "2018-05-23T01:22:53Z", "author_association": "OWNER", "body": "I grabbed just your Dockerfile and built it like this:\r\n\r\n    docker build . -t datasette\r\n\r\nOnce it had built, I ran it like this:\r\n\r\n    docker run -p 8001:8001 -v `pwd`:/mnt datasette \\\r\n        datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \\\r\n            --load-extension=/usr/local/lib/mod_spatialite.so\r\n\r\n(The fixtures.db file is created by running `python tests/fixtures.py fixtures.db`)\r\n\r\nThen I visited http://localhost:8001/-/versions and I got this:\r\n\r\n    {\r\n        \"datasette\": {\r\n            \"version\": \"0+unknown\"\r\n        },\r\n        \"python\": {\r\n            \"full\": \"3.6.3 (default, Dec 12 2017, 06:37:05) \\n[GCC 6.3.0 20170516]\",\r\n            \"version\": \"3.6.3\"\r\n        },\r\n        \"sqlite\": {\r\n            \"extensions\": {\r\n                \"json1\": null,\r\n                \"spatialite\": \"4.4.0-RC0\"\r\n            },\r\n            \"fts_versions\": [\r\n                \"FTS4\",\r\n                \"FTS3\"\r\n            ],\r\n            \"version\": \"3.23.1\"\r\n        }\r\n    }\r\n\r\nFantastic! I'm getting SQLite `3.23.1` and SpatiaLite `4.4.0-RC0`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}