{"html_url": "https://github.com/simonw/datasette/issues/2114#issuecomment-1670454222", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2114", "id": 1670454222, "node_id": "IC_kwDOBm6k_c5jkRvO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T23:44:42Z", "updated_at": "2023-08-08T23:44:42Z", "author_association": "OWNER", "body": "The tests for this are still passing:\r\n\r\n```bash\r\npytest tests/test_canned_queries.py\r\n```\r\nBecause I left in the old code:\r\n\r\nhttps://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L752-L767\r\n\r\nhttps://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L701-L727", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822940263, "label": "Implement canned queries against new query JSON work"}, "performed_via_github_app": null} {"html_url": "https://github.com/dogsheep/dogsheep-photos/pull/31#issuecomment-1669877769", "issue_url": "https://api.github.com/repos/dogsheep/dogsheep-photos/issues/31", "id": 1669877769, "node_id": "IC_kwDOD079W85jiFAJ", "user": {"value": 22996, "label": "chrismytton"}, "created_at": "2023-08-08T15:52:52Z", "updated_at": "2023-08-08T15:52:52Z", "author_association": "NONE", "body": "You can also install this with pip using this oneliner:\r\n\r\n```\r\npip install git+https://github.com/RhetTbull/dogsheep-photos.git@update_for_bigsur\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 771511344, "label": "Update for Big Sur"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2132#issuecomment-1669640626", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2132", "id": 1669640626, "node_id": "IC_kwDOBm6k_c5jhLGy", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T13:39:54Z", "updated_at": "2023-08-08T13:39:54Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/blob/1377a290cd85ba8d3338b1da47c4665ed4c6c625/datasette/views/database.py#L509-L517", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1841343173, "label": "Get form fields on query page working again "}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2113#issuecomment-1668983779", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2113", "id": 1668983779, "node_id": "IC_kwDOBm6k_c5jeqvj", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T06:27:42Z", "updated_at": "2023-08-08T06:27:42Z", "author_association": "OWNER", "body": "I've now shipped the new query JSON without any extras: https://latest.datasette.io/fixtures.json?sql=select+*+from+facetable\r\n\r\nThere aren't actually that many extras that make sense for the query page. These are the most obvious:\r\n\r\n- `query` - adding a `{\"sql\": \"...\", \"params\": \"..\"}` block, as seen on https://latest.datasette.io/fixtures/facetable.json?_extra=query&_size=0\r\n- `duration_ms` to show the duration - which isn't an extra on table right now but should be.\r\n- `metadata` - https://latest.datasette.io/fixtures/facetable.json?_extra=metadata&_size=0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822939274, "label": "Implement and document extras for the new query view page"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2117#issuecomment-1668799233", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2117", "id": 1668799233, "node_id": "IC_kwDOBm6k_c5jd9sB", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T02:02:07Z", "updated_at": "2023-08-08T02:02:07Z", "author_association": "OWNER", "body": "I just need to pass `view_name` to `datasette.render_template()`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822982933, "label": "Figure out what to do about `DatabaseView.name`"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2112#issuecomment-1668798642", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2112", "id": 1668798642, "node_id": "IC_kwDOBm6k_c5jd9iy", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T02:01:01Z", "updated_at": "2023-08-08T02:01:01Z", "author_association": "OWNER", "body": "Shipped: https://latest.datasette.io/fixtures?sql=select+*+from+facetable", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822938661, "label": "Build HTML version of /content?sql=..."}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2111#issuecomment-1668798261", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2111", "id": 1668798261, "node_id": "IC_kwDOBm6k_c5jd9c1", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T02:00:22Z", "updated_at": "2023-08-08T02:00:37Z", "author_association": "OWNER", "body": "Shipped: https://latest.datasette.io/_memory.json?sql=select+sqlite_version()\r\n```json\r\n{\r\n \"rows\": [\r\n {\r\n \"sqlite_version()\": \"3.34.1\"\r\n }\r\n ],\r\n \"columns\": [\r\n \"sqlite_version()\"\r\n ],\r\n \"ok\": true,\r\n \"truncated\": false\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822937426, "label": "Implement new /content.json?sql=..."}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2130#issuecomment-1668793100", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2130", "id": 1668793100, "node_id": "IC_kwDOBm6k_c5jd8MM", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T01:51:54Z", "updated_at": "2023-08-08T01:51:54Z", "author_association": "OWNER", "body": "Updated documentation is here: https://docs.datasette.io/en/latest/plugin_hooks.html#register-output-renderer-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1840329615, "label": "Render plugin mechanism needs `error` and `truncated` fields"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2127#issuecomment-1668792576", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2127", "id": 1668792576, "node_id": "IC_kwDOBm6k_c5jd8EA", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T01:51:14Z", "updated_at": "2023-08-08T01:51:14Z", "author_association": "OWNER", "body": "OK, I've landed the first example of this now. I'm cautiously optimistic about it, but I think I need to use it in a few more places AND add the actual code that uses it for documentation before I'm completely happy and close this issue.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1838469176, "label": "Context base class to support documenting the context"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2118#issuecomment-1668789134", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2118", "id": 1668789134, "node_id": "IC_kwDOBm6k_c5jd7OO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T01:46:12Z", "updated_at": "2023-08-08T01:46:12Z", "author_association": "OWNER", "body": "I'm going to squash merge this even though it's a bit big, because I want a clean passing commit in the `main` branch.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1823352380, "label": "New JSON design for query views"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2118#issuecomment-1668786770", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2118", "id": 1668786770, "node_id": "IC_kwDOBm6k_c5jd6pS", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T01:42:55Z", "updated_at": "2023-08-08T01:42:55Z", "author_association": "OWNER", "body": "> UPDATE: Fixed the `_size=max` bit, but I've not replicated the behaviour where it adds `?_labels=on` if there are expandable columns yet.\r\n\r\nIt looks like that behaviour is only relevant to table views, and it's already implemented - https://latest.datasette.io/fixtures/roadside_attraction_characteristics links to https://latest.datasette.io/fixtures/roadside_attraction_characteristics.csv?_labels=on&_size=max", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1823352380, "label": "New JSON design for query views"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2118#issuecomment-1668715803", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2118", "id": 1668715803, "node_id": "IC_kwDOBm6k_c5jdpUb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-07T23:50:26Z", "updated_at": "2023-08-08T01:41:53Z", "author_association": "OWNER", "body": "This bit needs some more work: https://github.com/simonw/datasette/blob/a791115e31e64e9bbd1d36f4d46887b3e42e752a/datasette/views/database.py#L514-L518\r\n\r\nThe original logic for that is from here, I need to figure out how to replicate it:\r\n\r\nhttps://github.com/simonw/datasette/blob/5139c0886a7f6bb94d317ba0665aa6e728716028/datasette/views/base.py#L368\r\n\r\nhttps://github.com/simonw/datasette/blob/5139c0886a7f6bb94d317ba0665aa6e728716028/datasette/views/base.py#L342-L344\r\n\r\nUPDATE: Fixed the `_size=max` bit, but I've not replicated the behaviour where it adds `?_labels=on` if there are expandable columns yet.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1823352380, "label": "New JSON design for query views"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2118#issuecomment-1668781558", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2118", "id": 1668781558, "node_id": "IC_kwDOBm6k_c5jd5X2", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T01:34:42Z", "updated_at": "2023-08-08T01:34:42Z", "author_association": "OWNER", "body": "3 failures left:\r\n```\r\n=================================================================== short test summary info ====================================================================\r\nFAILED tests/test_html.py::test_query_json_csv_export_links - assert 'CSV' in '\\n\\n\\n fixtures: select 1\\n