{"html_url": "https://github.com/simonw/datasette/issues/969#issuecomment-705874457", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/969", "id": 705874457, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTg3NDQ1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-08T23:27:30Z", "updated_at": "2020-10-08T23:27:30Z", "author_association": "OWNER", "body": "For the moment I'm going to ship this as the `--tar=` option. Can consider detecting `gtar` in the future.", "reactions": "{\"total_count\": 2, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 1, \"eyes\": 0}", "issue": {"value": 705057955, "label": "Add --tar option to \"datasette publish heroku\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/969#issuecomment-705874317", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/969", "id": 705874317, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTg3NDMxNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-08T23:27:00Z", "updated_at": "2020-10-08T23:27:00Z", "author_association": "OWNER", "body": "I'm working on this now. Just ran this test and it worked (no longer showed my the warning message).\r\n\r\n    datasette publish heroku fixtures.db -n datasette-issue-999 --branch=main --tar=/usr/local/bin/gtar\r\n\r\nBut... I wonder if it should automatically do this if it detects that `gtar` is available?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 705057955, "label": "Add --tar option to \"datasette publish heroku\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/969#issuecomment-696788109", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/969", "id": 696788109, "node_id": "MDEyOklzc3VlQ29tbWVudDY5Njc4ODEwOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-09-22T15:15:14Z", "updated_at": "2020-09-22T15:15:14Z", "author_association": "OWNER", "body": "I don't think a standard \"pass these extra arguments to the publish tool\" mechanism will work because there's no guarantee that a publisher uses a CLI tool - or if it does, it might make several calls to different CLI tools. The Cloud Run one runs a couple of commands, as illustrated by this test:\r\n\r\nhttps://github.com/simonw/datasette/blob/a648bb82bac201c7658f6fdb499ff8ac17ebd2e8/tests/test_publish_cloudrun.py#L63-L73\r\n\r\nAdding a `--tar` option for `datasette publish heroku` is a good fix for this though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 705057955, "label": "Add --tar option to \"datasette publish heroku\""}, "performed_via_github_app": null}