{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708520800", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708520800, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODUyMDgwMA==", "user": {"value": 639012, "label": "jsfenfen"}, "created_at": "2020-10-14T16:37:19Z", "updated_at": "2020-10-14T16:37:19Z", "author_association": "CONTRIBUTOR", "body": "\ud83c\udf89   Thanks so much @simonw  ! \ud83c\udf89 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708139822", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708139822, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODEzOTgyMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T03:53:21Z", "updated_at": "2020-10-14T03:53:21Z", "author_association": "OWNER", "body": "Demos:\r\n- https://latest.datasette.io/fixtures/neighborhood_search has the link\r\n- https://latest.datasette.io/fixtures/neighborhood_search?text=ber has the link, and the link passes through the parameter that has already been entered\r\n- https://latest.datasette.io/fixtures/%F0%9D%90%9C%F0%9D%90%A2%F0%9D%90%AD%F0%9D%90%A2%F0%9D%90%9E%F0%9D%90%AC has the link\r\n- https://latest.datasette.io/fixtures/pragma_cache_size does not have the link (`PRAGMA` is not allowed in regular editable queries)\r\n- https://latest.datasette.io/fixtures/magic_parameters does not have the link (magic parameters)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708130290", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708130290, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODEzMDI5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T03:17:57Z", "updated_at": "2020-10-14T03:17:57Z", "author_association": "OWNER", "body": "One last edge-case (I think) - magic parameters aren't supported for non-canned-queries, so if a query includes those it shouldn't show an Edit SQL link: https://latest.datasette.io/fixtures/magic_parameters\r\n\r\nI don't have a clean way of detecting if a query contains defined magic parameters, but I can instead do a dumb substring match for `:_` and skip showing the Edit SQL link if that is present.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708128286", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708128286, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODEyODI4Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T03:11:33Z", "updated_at": "2020-10-14T03:14:07Z", "author_association": "OWNER", "body": "Another edge-case: https://latest.datasette.io/fixtures/pragma_cache_size (`PRAGMA cache_size;`) isn't an allowed query usually, so linking to \"Edit SQL\" for it would link to an error page: https://latest.datasette.io/fixtures?sql=PRAGMA+cache_size%3B\r\n\r\nCan use `datasette.utils.validate_sql_select(sql)` to check for that - it raises `datasette.utils.InvalidSql` if there's a problem.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708127294", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708127294, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODEyNzI5NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T03:08:13Z", "updated_at": "2020-10-14T03:08:13Z", "author_association": "OWNER", "body": "Maybe like this:\r\n\r\n<img width=\"1385\" alt=\"fixtures__select_neighborhood__facet_cities_name__state_from_facetable_join_facet_cities_on_facetable_city_id___facet_cities_id_where_neighborhood_like_________text________order_by_neighborhood_\" src=\"https://user-images.githubusercontent.com/9599/95938930-ce721700-0d8f-11eb-87c8-f67ea4e57d55.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708114636", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708114636, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODExNDYzNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T02:24:56Z", "updated_at": "2020-10-14T02:24:56Z", "author_association": "OWNER", "body": "So it would appear on this page: https://latest.datasette.io/fixtures/neighborhood_search#fragment-goes-here\r\n\r\nProbably as a blue \"Edit SQL\" link next to those buttons.\r\n\r\n![575FB160-4F75-43B2-B2AB-D75E60F10477](https://user-images.githubusercontent.com/9599/95936143-c2835680-0d89-11eb-9cf3-06f86d923103.jpeg)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1019#issuecomment-708113989", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1019", "id": 708113989, "node_id": "MDEyOklzc3VlQ29tbWVudDcwODExMzk4OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-14T02:22:40Z", "updated_at": "2020-10-14T02:22:40Z", "author_association": "OWNER", "body": "I've found myself wanting this too.\r\n\r\nIt should respect the allow-sql permission so it doesn't display if the user isn't able to run custom SQL.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 721050815, "label": "\"Edit SQL\" button on canned queries"}, "performed_via_github_app": null}