{"html_url": "https://github.com/simonw/datasette/pull/1031#issuecomment-744003454", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1031", "id": 744003454, "node_id": "MDEyOklzc3VlQ29tbWVudDc0NDAwMzQ1NA==", "user": {"value": 299380, "label": "frankier"}, "created_at": "2020-12-13T12:52:56Z", "updated_at": "2020-12-13T12:52:56Z", "author_association": "NONE", "body": "Please let me know if there's anything I can do to help get this merged.\r\n\r\nThis is causing problems for me because it means when I build my Docker image my databases aren't considered immutable, which I would like them to be so that a download link is produced.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 724369025, "label": "Fallback to databases in inspect-data.json when no -i options are passed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1031#issuecomment-714289680", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1031", "id": 714289680, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA==", "user": {"value": 299380, "label": "frankier"}, "created_at": "2020-10-22T07:23:52Z", "updated_at": "2020-10-22T07:23:52Z", "author_association": "NONE", "body": "The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation.\r\n\r\nThe reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 724369025, "label": "Fallback to databases in inspect-data.json when no -i options are passed"}, "performed_via_github_app": null}