{"html_url": "https://github.com/simonw/datasette/issues/418#issuecomment-493109347", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/418", "id": 493109347, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MzEwOTM0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-16T15:12:26Z", "updated_at": "2019-05-16T15:12:26Z", "author_association": "OWNER", "body": "I'm ready to close this now thanks to fixing #471 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421548881, "label": "Hashed URLs should be optional"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/418#issuecomment-491551702", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/418", "id": 491551702, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU1MTcwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T23:32:21Z", "updated_at": "2019-05-11T23:32:21Z", "author_association": "OWNER", "body": "I'm going to re-open this, because some of this needs revisiting now that we aren't running `.inspect()` and hence are not calculating hashes for anything other than immutable databases (and databases are treated as mutable by default).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421548881, "label": "Hashed URLs should be optional"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/418#issuecomment-491551647", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/418", "id": 491551647, "node_id": "MDEyOklzc3VlQ29tbWVudDQ5MTU1MTY0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-11T23:31:23Z", "updated_at": "2019-05-11T23:31:23Z", "author_association": "OWNER", "body": "Actually right now https://latest.datasette.io/fixtures/facetable?_hash=1 redirects to https://latest.datasette.io/fixtures-000/facetable - because we are no longer calculating hashes on startup for non-immutable databases. So that's weird.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421548881, "label": "Hashed URLs should be optional"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/418#issuecomment-473724868", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/418", "id": 473724868, "node_id": "MDEyOklzc3VlQ29tbWVudDQ3MzcyNDg2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-03-17T23:07:31Z", "updated_at": "2019-03-17T23:07:31Z", "author_association": "OWNER", "body": "The design of this feature is discussed extensively in the comments on pull request #416 \r\n\r\nSome demos:\r\n\r\n* https://latest.datasette.io/fixtures/facetable now no longer redirects to the hash\r\n* https://latest.datasette.io/fixtures/facetable?_hash=1 redirects to https://latest.datasette.io/fixtures-dd88475/facetable\r\n\r\n```\r\n~ $ curl -i 'https://latest.datasette.io/fixtures-dd88475/facetable' \r\nHTTP/2 200 \r\ndate: Sun, 17 Mar 2019 23:05:21 GMT\r\ncontent-type: text/html; charset=utf-8\r\ncontent-length: 17555\r\ncache-control: max-age=31536000\r\n\r\n</html>~ $ curl -i 'https://latest.datasette.io/fixtures/facetable' \r\nHTTP/2 200 \r\ndate: Sun, 17 Mar 2019 23:05:40 GMT\r\ncontent-type: text/html; charset=utf-8\r\ncontent-length: 17410\r\ncache-control: max-age=5\r\n```\r\n\r\nThere are now three config settings relevant to the above:\r\n\r\n`default_cache_ttl` - defaults to 5s. The default cache TTL for non-hashed resources.\r\n`default_cache_ttl_hashed` - defaults to 31536000s. The default cache TTL for hashed resources.\r\n`hash_urls` - defaults to False. If True, all URLs will attempt to redirect to their hashed version.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421548881, "label": "Hashed URLs should be optional"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/418#issuecomment-473709815", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/418", "id": 473709815, "node_id": "MDEyOklzc3VlQ29tbWVudDQ3MzcwOTgxNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-03-17T20:08:31Z", "updated_at": "2019-03-17T20:08:31Z", "author_association": "OWNER", "body": "In #419 I'm now proposing that Datasette default to opening files in \"mutable\" mode, in which case it would not make sense to support hash URLs for those files at all. So actually this feature will only be available for files that are explicitly opened in immutable mode.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421548881, "label": "Hashed URLs should be optional"}, "performed_via_github_app": null}