{"html_url": "https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1006343303", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/363", "id": 1006343303, "node_id": "IC_kwDOCGYnMM47-5SH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-06T07:30:20Z", "updated_at": "2022-01-06T07:30:20Z", "author_association": "OWNER", "body": "This check should run inside the `.insert_all()` method. It should raise a custom exception which the CLI code can then catch and turn into a click error.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1094981339, "label": "Better error message if `--convert` code fails to return a dict"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1006344080", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/363", "id": 1006344080, "node_id": "IC_kwDOCGYnMM47-5eQ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-06T07:32:05Z", "updated_at": "2022-01-06T07:32:05Z", "author_association": "OWNER", "body": "As part of this work I should add test coverage of this error message too: https://github.com/simonw/sqlite-utils/blob/413f8ed754e38d7b190de888c85fe8438336cb11/sqlite_utils/cli.py#L826", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1094981339, "label": "Better error message if `--convert` code fails to return a dict"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029469630", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/363", "id": 1029469630, "node_id": "IC_kwDOCGYnMM49XHW-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-03T22:42:36Z", "updated_at": "2022-02-03T22:42:36Z", "author_association": "OWNER", "body": "> This check should run inside the `.insert_all()` method. It should raise a custom exception which the CLI code can then catch and turn into a click error.\r\n\r\nActually no that doesn't work, because this line causes an error before we even get to `.insert_all()`:\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/7d928f83085fb285f294dbdaeb93fd94a44d5d44/sqlite_utils/cli.py#L1012-L1013", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1094981339, "label": "Better error message if `--convert` code fails to return a dict"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/363#issuecomment-1029475387", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/363", "id": 1029475387, "node_id": "IC_kwDOCGYnMM49XIw7", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-03T22:52:30Z", "updated_at": "2022-02-03T22:52:30Z", "author_association": "OWNER", "body": "Demos:\r\n```\r\n% sqlite-utils insert /tmp/all.db blah /tmp/log.log --convert '[1]' --text\r\nError: Rows must all be dictionaries, got: 1\r\n% sqlite-utils insert /tmp/all.db blah /tmp/log.log --convert '1' --text             \r\nError: --convert must return dict or iterator\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1094981339, "label": "Better error message if `--convert` code fails to return a dict"}, "performed_via_github_app": null}