{"html_url": "https://github.com/simonw/datasette/issues/2109#issuecomment-1652294920", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2109", "id": 1652294920, "node_id": "IC_kwDOBm6k_c5ifAUI", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-26T18:25:34Z", "updated_at": "2023-07-26T18:25:34Z", "author_association": "OWNER", "body": "OK, these issues will do for the plan.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822934563, "label": "Plan for getting the new JSON format query views working"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2109#issuecomment-1652295866", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2109", "id": 1652295866, "node_id": "IC_kwDOBm6k_c5ifAi6", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-26T18:26:18Z", "updated_at": "2023-07-26T18:26:18Z", "author_association": "OWNER", "body": "I'm going to do this work in a fresh branch, copying bits over from here as needed:\r\n- https://github.com/simonw/datasette/pull/2053", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822934563, "label": "Plan for getting the new JSON format query views working"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2109#issuecomment-1652325193", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2109", "id": 1652325193, "node_id": "IC_kwDOBm6k_c5ifHtJ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-26T18:51:15Z", "updated_at": "2023-07-26T18:51:15Z", "author_association": "OWNER", "body": "Here's the code I'm going to be entirely replacing:\r\n\r\nhttps://github.com/simonw/datasette/blob/18dd88ee4d78fe9d760e9da96028ae06d938a85c/datasette/views/database.py#L213-L530\r\n\r\nPlus this weird class in `views/table.py`:\r\n\r\nhttps://github.com/simonw/datasette/blob/18dd88ee4d78fe9d760e9da96028ae06d938a85c/datasette/views/table.py#L701-L749", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822934563, "label": "Plan for getting the new JSON format query views working"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2109#issuecomment-1652715823", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2109", "id": 1652715823, "node_id": "IC_kwDOBm6k_c5ignEv", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-27T00:17:04Z", "updated_at": "2023-07-27T00:18:07Z", "author_association": "OWNER", "body": "New decision: I had originally decided that the HTML view would just use data that could otherwise be extracted from the JSON view if you fed in enough extras.\r\n\r\nI've changed my mind. I'm OK with the HTML view getting a few bonus things available in its context, provided those are clearly documented for template authors.\r\n\r\nThis should help avoid me having to make many changes to the templates themselves.\r\n\r\nHTML-specific stuff will be things like `csrftoken()` and `edit_sql_url` and `show_hide_link` and `database_color` and suchlike.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822934563, "label": "Plan for getting the new JSON format query views working"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2109#issuecomment-1652721111", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2109", "id": 1652721111, "node_id": "IC_kwDOBm6k_c5igoXX", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-27T00:23:28Z", "updated_at": "2023-07-27T00:23:37Z", "author_association": "OWNER", "body": "Once again I'm tempted to formalize the extra HTML context as a `dataclass` so I can ensure it is documented correctly.\r\n\r\nHere's an example of Hugging Face doing that: https://github.com/huggingface/transformers/blob/1689aea73346816b936b84932e12b774974e61a6/src/transformers/training_args.py#L622C1-L624\r\n\r\n```python\r\nfrom dataclasses import dataclass, field\r\n\r\n@dataclass\r\nclass TrainingArguments:\r\n    output_dir: str = field(\r\n        metadata={\"help\": \"The output directory where the model predictions and checkpoints will be written.\"},\r\n    )\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822934563, "label": "Plan for getting the new JSON format query views working"}, "performed_via_github_app": null}