{"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689127479", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689127479, "node_id": "IC_kwDOBm6k_c5krgo3", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-23T01:26:53Z", "updated_at": "2023-08-23T01:26:53Z", "author_association": "OWNER", "body": "@dependabot recreate", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689133247", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689133247, "node_id": "IC_kwDOBm6k_c5kriC_", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-08-23T01:36:42Z", "updated_at": "2023-08-23T03:09:43Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2148?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch coverage has no change and project coverage change: **`+0.01%`** :tada:\n> Comparison is base [(`17ec309`)](https://app.codecov.io/gh/simonw/datasette/commit/17ec309e14f9c2e90035ba33f2f38ecc5afba2fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.71% compared to head [(`a651d3c`)](https://app.codecov.io/gh/simonw/datasette/pull/2148?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.73%.\n> Report is 2 commits behind head on main.\n\n
Additional details and impacted files\n\n\n```diff\n@@ Coverage Diff @@\n## main #2148 +/- ##\n==========================================\n+ Coverage 92.71% 92.73% +0.01% \n==========================================\n Files 40 40 \n Lines 5919 5919 \n==========================================\n+ Hits 5488 5489 +1 \n+ Misses 431 430 -1 \n```\n\n\n[see 1 file with indirect coverage changes](https://app.codecov.io/gh/simonw/datasette/pull/2148/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n\n
\n\n[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/simonw/datasette/pull/2148?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). \n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689173748", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689173748, "node_id": "IC_kwDOBm6k_c5krr70", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-23T02:38:31Z", "updated_at": "2023-08-23T02:38:31Z", "author_association": "OWNER", "body": "Sphinx dropped support for Python 3.8 in their version 7.2.0:\r\n\r\n- https://www.sphinx-doc.org/en/master/changes.html#release-7-2-0-released-aug-17-2023\r\n- https://www.sphinx-doc.org/en/master/internals/release-process.html#python-version-support-policy\r\n- https://github.com/sphinx-doc/sphinx/pull/11511\r\n- ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689175062", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689175062, "node_id": "IC_kwDOBm6k_c5krsQW", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-23T02:40:46Z", "updated_at": "2023-08-23T02:40:46Z", "author_association": "OWNER", "body": "Here's why the tests are failing:\r\n\r\nhttps://github.com/simonw/datasette/blob/2ce7872e3ba8d07248c194ef554bbdc1df510f32/.github/workflows/test.yml#L30-L46\r\n\r\nIt looks like those tests don't actually need Sphinx installed - they install `pip install -e '.[test,docs]'` to get the other docs dependencies:\r\n\r\nhttps://github.com/simonw/datasette/blob/2ce7872e3ba8d07248c194ef554bbdc1df510f32/setup.py#L70-L80", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689177556", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689177556, "node_id": "IC_kwDOBm6k_c5krs3U", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-23T02:44:29Z", "updated_at": "2023-08-23T02:44:29Z", "author_association": "OWNER", "body": "Simplest possible solution is to only run the `pip install .[docs]` bit under Python 3.9+, ditto for the docs tests. I think I'll try that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689198368", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689198368, "node_id": "IC_kwDOBm6k_c5krx8g", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-23T02:57:53Z", "updated_at": "2023-08-23T02:57:53Z", "author_association": "OWNER", "body": "@dependabot rebase", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1689198413", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1689198413, "node_id": "IC_kwDOBm6k_c5krx9N", "user": {"value": 49699333, "label": "dependabot[bot]"}, "created_at": "2023-08-23T02:57:55Z", "updated_at": "2023-08-23T02:57:55Z", "author_association": "CONTRIBUTOR", "body": "Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!\n\nIf you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`.\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1696591943", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1696591943, "node_id": "IC_kwDOBm6k_c5lH_BH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T00:15:27Z", "updated_at": "2023-08-29T00:15:27Z", "author_association": "OWNER", "body": "Now solving this here:\r\n- #2160 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2148#issuecomment-1696591957", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2148", "id": 1696591957, "node_id": "IC_kwDOBm6k_c5lH_BV", "user": {"value": 49699333, "label": "dependabot[bot]"}, "created_at": "2023-08-29T00:15:29Z", "updated_at": "2023-08-29T00:15:29Z", "author_association": "CONTRIBUTOR", "body": "This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1859415334, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}