{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1695754277", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1695754277, "node_id": "IC_kwDOBm6k_c5lEygl", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2023-08-28T14:00:17Z", "updated_at": "2023-08-29T00:32:52Z", "author_association": "NONE", "body": "## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\nPatch and project coverage have no change.\n> Comparison is base [(`2e28258`)](https://app.codecov.io/gh/simonw/datasette/commit/2e2825869fc2655b5fcadc743f6f9dec7a49bc65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82% compared to head [(`c81b024`)](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82%.\n\n> :exclamation: Current head c81b024 differs from pull request most recent head 3529c9c. Consider uploading reports for the commit 3529c9c to get more accurate results\n\n<details><summary>Additional details and impacted files</summary>\n\n\n```diff\n@@           Coverage Diff           @@\n##             main    #2160   +/-   ##\n=======================================\n  Coverage   92.82%   92.82%           \n=======================================\n  Files          40       40           \n  Lines        5948     5948           \n=======================================\n  Hits         5521     5521           \n  Misses        427      427           \n```\n\n\n\n\n</details>\n\n[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/simonw/datasette/pull/2160?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).   \n:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1696586213", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1696586213, "node_id": "IC_kwDOBm6k_c5lH9nl", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T00:07:46Z", "updated_at": "2023-08-29T00:07:46Z", "author_association": "OWNER", "body": "I figured out why this was failing in:\r\n- https://github.com/simonw/datasette/pull/2148\r\n\r\nIt's because Sphinx dropped support for Python 3.8.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1696586767", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1696586767, "node_id": "IC_kwDOBm6k_c5lH9wP", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T00:08:26Z", "updated_at": "2023-08-29T00:08:35Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/issues/2148#issuecomment-1689177556\r\n\r\n> Simplest possible solution is to only run the `pip install .[docs]` bit under Python 3.9+, ditto for the docs tests. I think I'll try that.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1696592763", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1696592763, "node_id": "IC_kwDOBm6k_c5lH_N7", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T00:16:38Z", "updated_at": "2023-08-29T00:16:38Z", "author_association": "OWNER", "body": "Since this bumps Sphinx I'm manually reviewing the ReadTheDocs preview a bit, looks good to me: https://datasette--2160.org.readthedocs.build/en/2160/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2160#issuecomment-1696595326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2160", "id": 1696595326, "node_id": "IC_kwDOBm6k_c5lH_1-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-29T00:20:08Z", "updated_at": "2023-08-29T00:20:08Z", "author_association": "OWNER", "body": "Cog failed!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1869807874, "label": "Bump sphinx, furo, blacken-docs dependencies"}, "performed_via_github_app": null}