{"html_url": "https://github.com/simonw/datasette/pull/432#issuecomment-482876432", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/432", "id": 482876432, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4Mjg3NjQzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-13T20:06:32Z", "updated_at": "2019-04-13T20:06:32Z", "author_association": "OWNER", "body": "This has a bug which isn't being caught by the unit tests (yet) - facet suggestion suggests facets that have already been enabled:\r\n\r\n<img width=\"845\" alt=\"fixtures__facetable__15_rows\" src=\"https://user-images.githubusercontent.com/9599/56084775-eceb0100-5dec-11e9-8d98-24f1ea1862eb.png\">\r\n\r\nThere is also a test failure due to missing plugin hook documentation.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432893491, "label": "Refactor facets to a class and new plugin, refs #427"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/432#issuecomment-484584234", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/432", "id": 484584234, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4NDU4NDIzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-18T16:33:52Z", "updated_at": "2019-04-18T16:33:52Z", "author_association": "OWNER", "body": "It would be nice to decouple the `request` object from the `Facet` class. The request is needed for two things at the moment:\r\n\r\n* To decide if a specific facet bucket has been selected or not\r\n* To construct the `toggle_url` for turning the selection on or off\r\n\r\nCan I pull those needs out of the Facet class somehow?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432893491, "label": "Refactor facets to a class and new plugin, refs #427"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/432#issuecomment-488595724", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/432", "id": 488595724, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU5NTcyNA==", "user": {"value": 45057, "label": "russss"}, "created_at": "2019-05-02T08:50:53Z", "updated_at": "2019-05-02T08:50:53Z", "author_association": "CONTRIBUTOR", "body": "> Can I pull those needs out of the Facet class somehow?\r\n\r\nI was thinking that it might be handy for datasette to have a request object which wraps the Sanic Request. This could include the datasette-specific querystring decoding and the `special_args` parsing from TableView.data.\r\n\r\nThis would mean that we could expose the request object to plugin hooks without coupling them to Sanic.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432893491, "label": "Refactor facets to a class and new plugin, refs #427"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/432#issuecomment-488874364", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/432", "id": 488874364, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODg3NDM2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-03T00:04:23Z", "updated_at": "2019-05-03T00:04:23Z", "author_association": "OWNER", "body": "Abandoning this in favour of #445 - which contains the code from this branch but updated to incorporate recent changes in master.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432893491, "label": "Refactor facets to a class and new plugin, refs #427"}, "performed_via_github_app": null}