{"html_url": "https://github.com/simonw/datasette/pull/590#issuecomment-541495034", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/590", "id": 541495034, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NTAzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:51:32Z", "updated_at": "2019-10-14T03:51:32Z", "author_association": "OWNER", "body": "We need some unit tests for this.\r\n\r\nI'd be fine with us renaming `extra_database.db` to `extra database.py` in these existing fixtures:\r\n\r\nhttps://github.com/simonw/datasette/blob/af2e6a5cf186a7200d76cb67ac30fa59cc24d84e/tests/fixtures.py#L174-L185\r\n\r\nThen we could add an extra `test_database_name_with_spaces(...)` test in `test_api.py` which uses parametrize to exercise a bunch of URLs and check they all return a 200 - something a bit like this but covering a range of URL paths (one for database, table, row and table with filters):\r\n\r\nhttps://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/tests/test_api.py#L746-L765", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505818256, "label": "Handle spaces in DB names"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/590#issuecomment-541562581", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/590", "id": 541562581, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTU2MjU4MQ==", "user": {"value": 2657547, "label": "rixx"}, "created_at": "2019-10-14T08:57:46Z", "updated_at": "2019-10-14T08:57:46Z", "author_association": "CONTRIBUTOR", "body": "Ah, thank you \u2013 I saw the need for unit tests but wasn't sure what the best way to add one would be.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505818256, "label": "Handle spaces in DB names"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/590#issuecomment-541587823", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/590", "id": 541587823, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTU4NzgyMw==", "user": {"value": 2657547, "label": "rixx"}, "created_at": "2019-10-14T09:58:23Z", "updated_at": "2019-10-14T09:58:23Z", "author_association": "CONTRIBUTOR", "body": "Added tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505818256, "label": "Handle spaces in DB names"}, "performed_via_github_app": null}