{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541494080", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541494080, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NDA4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:43:11Z", "updated_at": "2019-10-14T03:43:11Z", "author_association": "OWNER", "body": "Ooh this is tricky... https://travis-ci.org/simonw/datasette/jobs/597216285 failed because it looks like `websockets-8.0.2` isn't compatible with Python 3.5\r\n\r\nThis is a problem. I need to keep Datasette working with 3.5 for compatibility with Glitch. But obviously I also want it to work with 3.8. \r\n\r\nI wonder if there's a smart solution here. @tomchristie any thoughts?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541499978", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541499978, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5OTk3OA==", "user": {"value": 4312421, "label": "stonebig"}, "created_at": "2019-10-14T04:32:33Z", "updated_at": "2019-10-14T04:33:26Z", "author_association": "NONE", "body": "Maybe make the setup rule conditional, so that below python-3.6, it looks for unicorn-0.8 ?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541664602", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541664602, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTY2NDYwMg==", "user": {"value": 647359, "label": "tomchristie"}, "created_at": "2019-10-14T13:03:10Z", "updated_at": "2019-10-14T13:03:10Z", "author_association": "NONE", "body": "\ud83e\udd37\u200d\u2642\ufe0f @stonebig's suggestion would be the best I got too, *if* you want to support 3.5->3.8.\r\n\r\nIt's either that, or hold off on 3.8 support until you're ready to go to 3.6->3.8.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541922637", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541922637, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTkyMjYzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T21:08:19Z", "updated_at": "2019-10-14T21:08:19Z", "author_association": "OWNER", "body": "There more discussion around this on the Glitch forums here: https://support.glitch.com/t/can-you-upgrade-python-to-latest-version/7980", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541931047", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541931047, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTkzMTA0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T21:25:38Z", "updated_at": "2019-10-14T21:25:38Z", "author_association": "OWNER", "body": "I like the conditional dependency for the moment - maybe until 3.5 becomes officially unsupported.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-552275668", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 552275668, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjI3NTY2OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-11T03:09:43Z", "updated_at": "2019-11-11T03:09:43Z", "author_association": "OWNER", "body": "Glitch has been upgraded to Python 3.7. I think I'm happy to drop 3.5 support now - users who want Python 3.5 can get it by installing `datasette==0.30.2`", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-552276237", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 552276237, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjI3NjIzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-11T03:12:56Z", "updated_at": "2019-11-11T03:12:56Z", "author_association": "OWNER", "body": "#622", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-552327079", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 552327079, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjMyNzA3OQ==", "user": {"value": 647359, "label": "tomchristie"}, "created_at": "2019-11-11T07:34:27Z", "updated_at": "2019-11-11T07:34:27Z", "author_association": "NONE", "body": "> Glitch has been upgraded to Python 3.7.\r\n\r\nWhoop! \ud83e\udd73 \u2728 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-552732445", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 552732445, "node_id": "MDEyOklzc3VlQ29tbWVudDU1MjczMjQ0NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-12T04:46:48Z", "updated_at": "2019-11-12T04:46:48Z", "author_association": "OWNER", "body": "Closing this in favour of #627 which upgrades to uvicorn 0.10.4", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}