{"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-997082676", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 997082676, "node_id": "IC_kwDOBm6k_c47bkY0", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:09:41Z", "updated_at": "2021-12-17T23:09:41Z", "author_association": "OWNER", "body": "This is now available to try out in Datasette 0.60a0: https://github.com/simonw/datasette/releases/tag/0.60a0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996961196", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996961196, "node_id": "IC_kwDOBm6k_c47bGus", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T19:00:53Z", "updated_at": "2021-12-17T19:00:53Z", "author_association": "OWNER", "body": "I'm going to merge this to `main` now. I can continue the refactoring there, but having it in `main` means I can put out an alpha release with the new hook which will unblock me from running tests against it in this repo: https://github.com/simonw/datasette-leaflet-freedraw/pull/8", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996959325", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996959325, "node_id": "IC_kwDOBm6k_c47bGRd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T18:59:54Z", "updated_at": "2021-12-17T18:59:54Z", "author_association": "OWNER", "body": "I've convinced myself that this plugin hook design is good through this `datasette-leaflet-freedraw` prototype: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996895423", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996895423, "node_id": "IC_kwDOBm6k_c47a2q_", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T17:28:44Z", "updated_at": "2021-12-17T17:28:44Z", "author_association": "OWNER", "body": "Before I land this I'm going to build one prototype plugin against it to confirm that the new hook is useful in its current shape.\r\n\r\nI'll add support for filtering a table by drawing on a map to https://datasette.io/plugins/datasette-leaflet-freedraw", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996286808", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996286808, "node_id": "IC_kwDOBm6k_c47YiFY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T00:01:43Z", "updated_at": "2021-12-17T00:01:43Z", "author_association": "OWNER", "body": "This already has tests and documentation, and I've used it to refactor out the logic for `?_where=` and `?_search=` and `?_through=`.\r\n\r\nDo I like this enough to land it on `main`?\r\n\r\nAlso, I think I can still use it to refactor out the `Filters` code that implements `?col=x` and `?col__lt=5` and suchlike.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null}