{"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997082189", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997082189, "node_id": "IC_kwDOBm6k_c47bkRN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:08:14Z", "updated_at": "2021-12-17T23:08:14Z", "author_association": "OWNER", "body": "Oh that makes sense: In Python 3.6 this happens:\r\n```\r\nCollecting janus<1.1,>=0.6.2\r\n  Using cached janus-0.7.0-py3-none-any.whl (6.9 kB)\r\n```\r\nWhile in Python 3.7 or higher this happens:\r\n```\r\nCollecting janus<1.1,>=0.6.2\r\n  Downloading janus-1.0.0-py3-none-any.whl (6.9 kB)\r\n```\r\nSo this is safe to apply because `pip` is smart enough to pick the version of Janus that works for that Python version.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997081673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997081673, "node_id": "IC_kwDOBm6k_c47bkJJ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:06:38Z", "updated_at": "2021-12-17T23:06:38Z", "author_association": "OWNER", "body": "From this diff between `0.7.0` and `1.0`: https://github.com/aio-libs/janus/compare/v0.7.0...v1.0.0\r\n\r\nIt looks like the only change relevant to compatibility is `loop = asyncio.get_running_loop()` directly instead of falling back to `asyncio.get_event_loop()` if `get_running_loop` isn't available.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997080352", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997080352, "node_id": "IC_kwDOBm6k_c47bj0g", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:03:08Z", "updated_at": "2021-12-17T23:03:08Z", "author_association": "OWNER", "body": "They say they've dropped 3.6 support, but Datasette's tests against 3.6 are still passing.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null}