{"html_url": "https://github.com/simonw/datasette/pull/2052#issuecomment-1760552652", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2052", "id": 1760552652, "node_id": "IC_kwDOBm6k_c5o7-bM", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T23:59:21Z", "updated_at": "2023-10-12T23:59:21Z", "author_association": "OWNER", "body": "I'm landing this despite the cog failures. I'll fix them on main if I have to.", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 1, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1651082214, "label": "feat: Javascript Plugin API (Custom panels, column menu items with JS actions)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2052#issuecomment-1760545012", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2052", "id": 1760545012, "node_id": "IC_kwDOBm6k_c5o78j0", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T23:48:16Z", "updated_at": "2023-10-12T23:48:16Z", "author_association": "OWNER", "body": "Oh! I think I broke Cog on `main` and these tests are running against this branch rebased against main.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1651082214, "label": "feat: Javascript Plugin API (Custom panels, column menu items with JS actions)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2052#issuecomment-1760542865", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2052", "id": 1760542865, "node_id": "IC_kwDOBm6k_c5o78CR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T23:44:53Z", "updated_at": "2023-10-12T23:45:15Z", "author_association": "OWNER", "body": "Weird, the `cog` check is failing in CI.\r\n\r\n```\r\nRun cog --check docs/*.rst\r\n  cog --check docs/*.rst\r\n  shell: /usr/bin/bash -e {0}\r\n  env:\r\n    pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64\r\n    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig\r\n    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\r\n    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\r\n    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\r\n    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib\r\nCheck failed\r\nChecking docs/authentication.rst\r\nChecking docs/binary_data.rst\r\nChecking docs/changelog.rst\r\nChecking docs/cli-reference.rst\r\nChecking docs/configuration.rst  (changed)\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1651082214, "label": "feat: Javascript Plugin API (Custom panels, column menu items with JS actions)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2052#issuecomment-1629337927", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2052", "id": 1629337927, "node_id": "IC_kwDOBm6k_c5hHblH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-10T16:43:38Z", "updated_at": "2023-07-10T16:44:23Z", "author_association": "OWNER", "body": "I tried running this locally just now. I made one edit:\r\n```diff\r\ndiff --git a/demos/plugins/example_js_manager_plugins.py b/demos/plugins/example_js_manager_plugins.py\r\nindex 7bdb9f3f..f9dfa8e6 100644\r\n--- a/demos/plugins/example_js_manager_plugins.py\r\n+++ b/demos/plugins/example_js_manager_plugins.py\r\n@@ -15,6 +15,6 @@ def extra_js_urls(view_name):\r\n     if view_name in PERMITTED_VIEWS:\r\n         return [\r\n             {\r\n-                \"url\": f\"/-/demos/plugins/static/table-example-plugins.js\",\r\n+                \"url\": f\"/static/table-example-plugins.js\",\r\n             }\r\n         ]\r\n```\r\nAnd then started it running like this:\r\n```bash\r\nwget https://datasette.io/content.db\r\n```\r\n```bash\r\ndatasette content.db \\\r\n  --plugins-dir demos/plugins \\\r\n  --static static:datasette/demos/plugins/static\r\n```\r\n\r\nIt didn't quite work for me - I got this error on a table page:\r\n\r\n<img width=\"681\" alt=\"image\" src=\"https://github.com/simonw/datasette/assets/9599/02f5c16d-ea43-4c36-920d-4b14406645b5\">\r\n\r\nAnd this error on a query page:\r\n\r\n<img width=\"689\" alt=\"image\" src=\"https://github.com/simonw/datasette/assets/9599/994db3a0-502a-4f36-8581-c47556600d63\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1651082214, "label": "feat: Javascript Plugin API (Custom panels, column menu items with JS actions)"}, "performed_via_github_app": null}