{"html_url": "https://github.com/simonw/datasette/issues/2114#issuecomment-1670470516", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2114", "id": 1670470516, "node_id": "IC_kwDOBm6k_c5jkVt0", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-09T00:09:55Z", "updated_at": "2023-08-09T00:10:32Z", "author_association": "OWNER", "body": "I decided to figure out where the `_size=` parameter here comes from: https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/database.py#L576-L588\r\n\r\nIt took some spelunking, but it looks like I added that five years ago as part of CSV streaming in https://github.com/simonw/datasette/commit/fc3660cfad7668dbce6ead12766e048fc1f78b11\r\n\r\nIt's there purely to allow CSV streaming to set `_size=\"max\"`.\r\n\r\nAnd since CSV streaming is still just a table thing, not a query thing, I can drop it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822940263, "label": "Implement canned queries against new query JSON work"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2114#issuecomment-1670454222", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2114", "id": 1670454222, "node_id": "IC_kwDOBm6k_c5jkRvO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-08-08T23:44:42Z", "updated_at": "2023-08-08T23:44:42Z", "author_association": "OWNER", "body": "The tests for this are still passing:\r\n\r\n```bash\r\npytest tests/test_canned_queries.py\r\n```\r\nBecause I left in the old code:\r\n\r\nhttps://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L752-L767\r\n\r\nhttps://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L701-L727", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822940263, "label": "Implement canned queries against new query JSON work"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2114#issuecomment-1652321419", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2114", "id": 1652321419, "node_id": "IC_kwDOBm6k_c5ifGyL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-07-26T18:48:03Z", "updated_at": "2023-07-26T18:48:03Z", "author_association": "OWNER", "body": "This is also where I'll bring back writable canned queries:\r\n\r\nhttps://github.com/simonw/datasette/blob/18dd88ee4d78fe9d760e9da96028ae06d938a85c/datasette/views/database.py#L281-L334", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1822940263, "label": "Implement canned queries against new query JSON work"}, "performed_via_github_app": null}