{"html_url": "https://github.com/simonw/datasette/pull/2190#issuecomment-1759948683", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2190", "id": 1759948683, "node_id": "IC_kwDOBm6k_c5o5q-L", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T16:20:41Z", "updated_at": "2023-10-12T16:20:41Z", "author_association": "OWNER", "body": "I'm going to land this and open a new issue for the upgrade instructions.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901483874, "label": "Raise an exception if a \"plugins\" block exists in metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2190#issuecomment-1759947534", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2190", "id": 1759947534, "node_id": "IC_kwDOBm6k_c5o5qsO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T16:19:59Z", "updated_at": "2023-10-12T16:19:59Z", "author_association": "OWNER", "body": "It would be nice if we could catch that and turn that into a less intimidating Click exception too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901483874, "label": "Raise an exception if a \"plugins\" block exists in metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2190#issuecomment-1759947021", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2190", "id": 1759947021, "node_id": "IC_kwDOBm6k_c5o5qkN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-10-12T16:19:38Z", "updated_at": "2023-10-12T16:19:38Z", "author_association": "OWNER", "body": "\r\n\r\nThis looks good and works well. The error from this currently looks like:\r\n\r\n```\r\ndatasette -m metadata.json -p 8844\r\nTraceback (most recent call last):\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/bin/datasette\", line 33, in <module>\r\n    sys.exit(load_entry_point('datasette', 'console_scripts', 'datasette')())\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages/click/core.py\", line 1130, in __call__\r\n    return self.main(*args, **kwargs)\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages/click/core.py\", line 1055, in main\r\n    rv = self.invoke(ctx)\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages/click/core.py\", line 1657, in invoke\r\n    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages/click/core.py\", line 1404, in invoke\r\n    return ctx.invoke(self.callback, **ctx.params)\r\n  File \"/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages/click/core.py\", line 760, in invoke\r\n    return __callback(*args, **kwargs)\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/cli.py\", line 98, in wrapped\r\n    return fn(*args, **kwargs)\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/cli.py\", line 546, in serve\r\n    metadata_data = fail_if_plugins_in_metadata(parse_metadata(metadata.read()))\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/utils/__init__.py\", line 1282, in fail_if_plugins_in_metadata\r\n    raise Exception(\r\nException: Datasette no longer accepts plugin configuration in --metadata. Move your \"plugins\" configuration blocks to a separate file - we suggest calling that datasette..json - and start Datasette with datasette -c datasette..json. See https://docs.datasette.io/en/latest/configuration.html for more details.\r\n```\r\nWith wrapping:\r\n\r\n`Exception: Datasette no longer accepts plugin configuration in --metadata. Move your \"plugins\" configuration blocks to a separate file - we suggest calling that datasette..json - and start Datasette with datasette -c datasette..json. See https://docs.datasette.io/en/latest/configuration.html for more details.`\r\n\r\nI think we should link directly to documentation that tells people how to perform this upgrade.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901483874, "label": "Raise an exception if a \"plugins\" block exists in metadata.json"}, "performed_via_github_app": null}