{"html_url": "https://github.com/simonw/datasette/pull/2191#issuecomment-1728504633", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2191", "id": 1728504633, "node_id": "IC_kwDOBm6k_c5nBuM5", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-09-20T22:24:51Z", "updated_at": "2023-09-20T22:25:16Z", "author_association": "OWNER", "body": "The `{\"units\": {\"distance\": \"m\", \"frequency\": \"Hz\"}}` bit is for the [units feature](https://docs.datasette.io/en/1.0a6/metadata.html#specifying-units-for-a-column) which I've half-disabled already and would like to remove before 1.0, though ideally turning that functionality into a plugin instead (if I can figure out how to do that).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901768721, "label": "Move `permissions`,  `allow` blocks, canned queries and more out of `metadata.yaml` and into `datasette.yaml`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2191#issuecomment-1728503623", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2191", "id": 1728503623, "node_id": "IC_kwDOBm6k_c5nBt9H", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-09-20T22:23:33Z", "updated_at": "2023-09-20T22:24:10Z", "author_association": "OWNER", "body": "This is one of the most interesting illustrative examples in the new code:\r\n\r\nhttps://github.com/simonw/datasette/blob/f7bdedff779606466b580d8528e5a44509291002/tests/fixtures.py#L301-L349\r\n\r\nInteresting to note that it now has canned queries in it, which include this bit:\r\n\r\nhttps://github.com/simonw/datasette/blob/f7bdedff779606466b580d8528e5a44509291002/tests/fixtures.py#L341-L342\r\n\r\nIt looks like metadata, but in this case it's configuration. That blur between metadata and configuration at the canned query level still feels a little bit odd to me, but I still think we're going in the right direction with it.\r\n\r\nAlso interesting, from that same file:\r\n\r\nhttps://github.com/simonw/datasette/blob/f7bdedff779606466b580d8528e5a44509291002/tests/fixtures.py#L351-L399\r\n\r\nThere are a few things in that metadata block that are arguably configuration, not metadata - for example:\r\n\r\nhttps://github.com/simonw/datasette/blob/f7bdedff779606466b580d8528e5a44509291002/tests/fixtures.py#L360\r\n\r\nI think `extra_css_urls` is definitely configuration, not metadata.\r\n\r\nhttps://github.com/simonw/datasette/blob/f7bdedff779606466b580d8528e5a44509291002/tests/fixtures.py#L369-L395\r\n\r\nMost of that stuff is arguably configuration too, with the exception of the `roadside_attractions.columns` bit which is metadata about those columns.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901768721, "label": "Move `permissions`,  `allow` blocks, canned queries and more out of `metadata.yaml` and into `datasette.yaml`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2191#issuecomment-1728498221", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2191", "id": 1728498221, "node_id": "IC_kwDOBm6k_c5nBsot", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-09-20T22:17:26Z", "updated_at": "2023-09-20T22:17:26Z", "author_association": "OWNER", "body": "I tested this locally for permissions like this. `datasette.yml`:\r\n\r\n```yaml\r\ndatabases:\r\n  content:\r\n    allow:\r\n      id: root\r\n```\r\nStarted Datasette like this:\r\n```bash\r\ndatasette --root content.db pottery2.db -c datasette.yml\r\n```\r\nAs root I could see this (note the padlock):\r\n\r\n<img width=\"630\" alt=\"CleanShot 2023-09-20 at 15 17 02@2x\" src=\"https://github.com/simonw/datasette/assets/9599/3e0c3abd-9a90-43f4-ad68-bb490d19eef8\">\r\n\r\nhttp://127.0.0.1:8001/-/metadata returned `{}` showing that the permissions must have come from the config file instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1901768721, "label": "Move `permissions`,  `allow` blocks, canned queries and more out of `metadata.yaml` and into `datasette.yaml`"}, "performed_via_github_app": null}