{"html_url": "https://github.com/simonw/datasette/pull/107#issuecomment-345108644", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/107", "id": 345108644, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NTEwODY0NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-17T00:34:46Z", "updated_at": "2017-11-17T00:34:46Z", "author_association": "OWNER", "body": "Looks like your tests are failing because of a bug which I fixed in https://github.com/simonw/datasette/commit/9199945a1bcec4852e1cb866eb3642614dd32a48 - if you rebase to master the tests should pass.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274343647, "label": "add support for ?field__isnull=1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/107#issuecomment-344770170", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/107", "id": 344770170, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NDc3MDE3MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-16T00:01:00Z", "updated_at": "2017-11-16T00:01:22Z", "author_association": "OWNER", "body": "It is - but I think this will break on this line since it expects two format string parameters:\r\n\r\nhttps://github.com/simonw/datasette/blob/f45ca30f91b92ac68adaba893bf034f13ec61ced/datasette/utils.py#L61\r\n\r\nNeeds unit tests too, which live here: https://github.com/simonw/datasette/blob/f45ca30f91b92ac68adaba893bf034f13ec61ced/tests/test_utils.py#L49", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274343647, "label": "add support for ?field__isnull=1"}, "performed_via_github_app": null}