{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-513317952", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 513317952, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMzMxNzk1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-19T17:49:06Z", "updated_at": "2019-07-19T17:49:06Z", "author_association": "OWNER", "body": "It strikes me that if scope is indeed meant to stay immutable the alternative way of solving this would be to add an outbound custom request header with the endpoint - `X-Endpoint: datasette.views.table.TableView` for example - and teach the Sentry plugin to optionally read that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-513307487", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 513307487, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMzMwNzQ4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-19T17:17:43Z", "updated_at": "2019-07-19T17:17:43Z", "author_association": "OWNER", "body": "Huh, interesting. I'd got it into my head that scope should not be mutated under any circumstances - if that's not true and it's mutable there's all kinds of useful things we could do with it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-513273003", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 513273003, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMzI3MzAwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-19T15:28:42Z", "updated_at": "2019-07-19T15:28:42Z", "author_association": "OWNER", "body": "Asked about this on Twitter: https://twitter.com/simonw/status/1152238730259791877", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 1, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-513272392", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 513272392, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMzI3MjM5Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-19T15:27:03Z", "updated_at": "2019-07-19T15:27:03Z", "author_association": "OWNER", "body": "Yeah that's a good call: the Datasette plugin mechanism where middleware is wrapped around the outside doesn't appear to be compatible with the Sentry mechanism of expecting that `scope` has been populated before it gets to their error handler.\r\n\r\n@tomchristie is this something you've thought about?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-512664216", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 512664216, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMjY2NDIxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-18T04:53:18Z", "updated_at": "2019-07-18T04:53:18Z", "author_association": "OWNER", "body": "Yes, `TableView` is desirable here I think. Maybe `datasette.views.table.TableView` if we can get that somehow. Thanks for taking a look!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}