{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-795918377", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 795918377, "node_id": "MDEyOklzc3VlQ29tbWVudDc5NTkxODM3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-03-10T19:01:48Z", "updated_at": "2021-03-10T19:01:48Z", "author_association": "OWNER", "body": "The biggest challenge here I think is to replicate the exact situation here this happens in a Python unit test. The fix should be easy once we have a test in place.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-795895436", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 795895436, "node_id": "MDEyOklzc3VlQ29tbWVudDc5NTg5NTQzNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-03-10T18:44:46Z", "updated_at": "2021-03-10T18:44:57Z", "author_association": "OWNER", "body": "Let's reopen this.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-719986904", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 719986904, "node_id": "MDEyOklzc3VlQ29tbWVudDcxOTk4NjkwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-31T20:50:41Z", "updated_at": "2020-10-31T20:50:41Z", "author_association": "OWNER", "body": "OK, this should be working now. You can use the `datasette.urls.static_plugins()` method to generate the correct URLs in the `extra_css_urls` plugin hook: https://docs.datasette.io/en/latest/internals.html#datasette-urls", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-712604364", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 712604364, "node_id": "MDEyOklzc3VlQ29tbWVudDcxMjYwNDM2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-20T05:39:15Z", "updated_at": "2020-10-20T05:39:15Z", "author_association": "OWNER", "body": "OK, I've made a ton of improvements to how the `base_url` setting works - see tickets linked from #1023. I've just pushed out an alpha release with those changes in it: https://github.com/simonw/datasette/releases/tag/0.51a0\r\n\r\n@tsibley @tballison @ChristopherWilks I'd really appreciate your help testing this alpha! \r\n\r\nYou can install it with:\r\n\r\n    pip install datasette==0.51a0\r\n\r\nIt should work with just `ProxyPass`, without needing the `ProxyPassReverse` setting.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-709588425", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 709588425, "node_id": "MDEyOklzc3VlQ29tbWVudDcwOTU4ODQyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-15T21:02:37Z", "updated_at": "2020-10-15T21:02:37Z", "author_association": "OWNER", "body": "Tracking ticket: #1023", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/838#issuecomment-642993277", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/838", "id": 642993277, "node_id": "MDEyOklzc3VlQ29tbWVudDY0Mjk5MzI3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-06-12T00:18:26Z", "updated_at": "2020-06-12T00:18:50Z", "author_association": "OWNER", "body": "Have you tried this without the `ProxyPassReverse` directive? I'm worried that might be confusing Datasette.\r\n\r\nThis is the test I used to ensure this feature works - it scrapes all of the links on a bunch of different pages. Could it be missing something here?\r\n\r\nhttps://github.com/simonw/datasette/blob/647c5ff0f3e8140f40d7f41f0874ce4e1f4df65c/tests/test_html.py#L1233-L1274\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 637395097, "label": "Incorrect URLs when served behind a proxy with base_url set"}, "performed_via_github_app": null}