{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942782673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942782673, "node_id": "IC_kwDOBm6k_c44MbjR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T23:04:54Z", "updated_at": "2021-10-13T23:04:54Z", "author_association": "OWNER", "body": "I think this is the change in `httpx` which is causing the bug for me: https://github.com/encode/httpx/commit/ff9813e84dab56f0f3c4ef3a159a4cce8c644a91#diff-0d0cbe9ebcd03cc8c780b0407762540a082f70cc64257f2fcd588cc30f43c15cR96\r\n\r\n<img width=\"706\" alt=\"Transport_API_as_plain_`request_-__response`_method____1840__\u00b7_encode_httpx_ff9813e\" src=\"https://user-images.githubusercontent.com/9599/137224339-0aed171f-b351-4d67-8d6c-ad22f2301f18.png\">\r\n\r\nPreviously it was using `path` from `path, _, query = full_path.partition(b\"?\")` to populate the `raw_path` key - but it changed to instead using `request.url.raw_path` which presumably implements the logic that includes the query string.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942779926", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942779926, "node_id": "IC_kwDOBm6k_c44Ma4W", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:59:05Z", "updated_at": "2021-10-13T22:59:05Z", "author_association": "OWNER", "body": "This is weird - as far as I can tell `httpx` has included the query string in `raw_path` for well over a year: https://github.com/encode/httpx/commit/8e4a8a1c73f60fe5754f95b308beaa725cb8791d#diff-c9a78eb3b5f5c4fac4e5552165fbdd5320c7e3fadf9eedabcb5461393466c090R235", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942778673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942778673, "node_id": "IC_kwDOBm6k_c44Makx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:55:44Z", "updated_at": "2021-10-13T22:55:44Z", "author_association": "OWNER", "body": "```\r\n(Pdb) request.scope['path']\r\n'/_memory.json'\r\n(Pdb) request.scope['raw_path']\r\nb'/_memory.json?sql=select+sqlite_version()'\r\n```\r\nSo `raw_path` now includes the query string.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942778382", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942778382, "node_id": "IC_kwDOBm6k_c44MagO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:55:01Z", "updated_at": "2021-10-13T22:55:01Z", "author_association": "OWNER", "body": "I think the issue is in `route_path()`:\r\n```\r\n> /Users/simon/Dropbox/Development/datasette/datasette/app.py(1182)route_path()\r\n-> response = await view(request, send)\r\n(Pdb) path\r\n'/_memory.json?sql=select+sqlite_version()'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942777414", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942777414, "node_id": "IC_kwDOBm6k_c44MaRG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:52:40Z", "updated_at": "2021-10-13T22:52:40Z", "author_association": "OWNER", "body": "Upgrading to 0.20.0 gives me lots of the following errors:\r\n\r\n    '{\"ok\": false, \"error\": \"Database not found: .json?_sort=relationships\", \"status\": 404, \"title\": null}'\r\n\r\nIt looks like the full query string is now being treated as the name of the database.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}