{"html_url": "https://github.com/simonw/datasette/issues/1545#issuecomment-1028535868", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1545", "id": 1028535868, "node_id": "IC_kwDOBm6k_c49TjY8", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-03T02:08:30Z", "updated_at": "2022-02-03T02:08:30Z", "author_association": "OWNER", "body": "Filed an issue with Jinja suggesting a documentation update:\r\n- https://github.com/pallets/jinja/issues/1578", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1075893249, "label": "Custom pages don't work on windows"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1545#issuecomment-1028517268", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1545", "id": 1028517268, "node_id": "IC_kwDOBm6k_c49Te2U", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-03T01:26:53Z", "updated_at": "2022-02-03T01:26:53Z", "author_association": "OWNER", "body": "I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922\r\n\r\n> Jinja template names/paths are not always filesystem paths. So regardless of the OS Jinja always uses forward slashes.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1075893249, "label": "Custom pages don't work on windows"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1545#issuecomment-997462604", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1545", "id": 997462604, "node_id": "IC_kwDOBm6k_c47dBJM", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-19T21:17:08Z", "updated_at": "2021-12-19T21:17:08Z", "author_association": "OWNER", "body": "Here's the relevant code: https://github.com/simonw/datasette/blob/4094741c2881c2ada3f3f878b532fdaec7914953/datasette/app.py#L1204-L1219\r\n\r\nIt's using `route_path.split(\"/\")` which should be OK because that's the incoming `request.path` path - which I would expect to use `/` even on Windows. Then it uses `os.path.join` which should do the right thing.\r\n\r\nI need to get myself a proper Windows development environment setup to investigate this one.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1075893249, "label": "Custom pages don't work on windows"}, "performed_via_github_app": null}