{"html_url": "https://github.com/simonw/datasette/pull/1626#issuecomment-1028515161", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1626", "id": 1028515161, "node_id": "IC_kwDOBm6k_c49TeVZ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-03T01:22:43Z", "updated_at": "2022-02-03T01:22:43Z", "author_association": "OWNER", "body": "OK, the tests do NOT pass against Windows! https://github.com/simonw/datasette/runs/5044105941\r\n\r\n<img width=\"767\" alt=\"image\" src=\"https://user-images.githubusercontent.com/9599/152265501-5b5af51b-0fae-4aa7-b86d-7b61aba24b3c.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1122451096, "label": "Try test suite against macOS and Windows"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1626#issuecomment-1028423514", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1626", "id": 1028423514, "node_id": "IC_kwDOBm6k_c49TH9a", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2022-02-02T22:36:37Z", "updated_at": "2022-02-02T22:39:52Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1626](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (4b4d0e1) into [main](https://codecov.io/gh/simonw/datasette/commit/b5e6b1a9e1332fca3effe45d55dd06ee4249f163?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (b5e6b1a) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1626/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@           Coverage Diff           @@\n##             main    #1626   +/-   ##\n=======================================\n  Coverage   92.16%   92.16%           \n=======================================\n  Files          34       34           \n  Lines        4531     4531           \n=======================================\n  Hits         4176     4176           \n  Misses        355      355           \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [b5e6b1a...4b4d0e1](https://codecov.io/gh/simonw/datasette/pull/1626?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1122451096, "label": "Try test suite against macOS and Windows"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1626#issuecomment-1028420821", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1626", "id": 1028420821, "node_id": "IC_kwDOBm6k_c49THTV", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-02T22:32:26Z", "updated_at": "2022-02-02T22:33:31Z", "author_association": "OWNER", "body": "That broke on a macOS test: https://github.com/simonw/datasette/runs/5044036993?check_suite_focus=true\r\n\r\nI'm going to remove macOS and Ubuntu and just try Windows purely to see what happens there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1122451096, "label": "Try test suite against macOS and Windows"}, "performed_via_github_app": null}