{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1072898923", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1072898923, "node_id": "IC_kwDOBm6k_c4_8yNr", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T00:11:33Z", "updated_at": "2022-03-19T00:11:33Z", "author_association": "OWNER", "body": "I'm going to land this and handle those in separate commits.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1072898797", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1072898797, "node_id": "IC_kwDOBm6k_c4_8yLt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T00:11:09Z", "updated_at": "2022-03-19T00:11:09Z", "author_association": "OWNER", "body": "Still need to remove it from the documentation and do something about that `hash_urls` setting.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1072890524", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1072890524, "node_id": "IC_kwDOBm6k_c4_8wKc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-18T23:44:33Z", "updated_at": "2022-03-19T00:06:51Z", "author_association": "OWNER", "body": "Looks like that was set here: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L490-L492", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1072890205", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1072890205, "node_id": "IC_kwDOBm6k_c4_8wFd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-18T23:43:15Z", "updated_at": "2022-03-18T23:43:15Z", "author_association": "OWNER", "body": "Now almost everything is working except for foreign key expansion:\r\n\r\n\r\n\r\nUsing the debugger I tracked it down to this code:\r\n\r\nhttps://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L708-L715\r\n\r\nTurns out `default_labels` there is `None` - and it's a parameter to that `data()` method: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L325-L334\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071813296, "node_id": "IC_kwDOBm6k_c4_4pKw", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:26:22Z", "updated_at": "2022-03-17T23:26:22Z", "author_association": "OWNER", "body": "Probably caused by the convoluted code is `get_format()`: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L466-L481", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071809988, "node_id": "IC_kwDOBm6k_c4_4oXE", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:24:57Z", "updated_at": "2022-03-17T23:24:57Z", "author_association": "OWNER", "body": "My hunch is that this is broken because of this:\r\n\r\nhttps://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/app.py#L1098-L1107\r\n\r\nNote how the table uses `table_and_format` but the row uses just `table` - I think there's code that's getting confused by this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1664", "id": 1071803114, "node_id": "IC_kwDOBm6k_c4_4mrq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:22:00Z", "updated_at": "2022-03-17T23:22:00Z", "author_association": "OWNER", "body": "Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:\r\n\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173017980, "label": "Remove hashed URL mode"}, "performed_via_github_app": null}