{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130422", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229130422, "node_id": "IC_kwDOCGYnMM5JQwq2", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T05:55:01Z", "updated_at": "2022-08-27T05:55:01Z", "author_association": "OWNER", "body": "cc @asg017 since this feature was inspired by his work on Datasette.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130242", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229130242, "node_id": "IC_kwDOCGYnMM5JQwoC", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T05:53:31Z", "updated_at": "2022-08-27T05:53:31Z", "author_association": "OWNER", "body": "Tests passed in CI against Ubuntu:\r\n```\r\ntests/test_cli.py::test_load_extension[None-should_pass0-should_fail0] PASSED [ 19%]\r\ntests/test_cli.py::test_load_extension[sqlite3_ext_b_init-b-should_fail1] PASSED [ 19%]\r\ntests/test_cli.py::test_load_extension[sqlite3_ext_c_init-c-should_fail2] PASSED [ 19%]\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229130158", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229130158, "node_id": "IC_kwDOCGYnMM5JQwmu", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T05:52:46Z", "updated_at": "2022-08-27T05:52:46Z", "author_association": "OWNER", "body": "To run the tests locally on my Mac I needed to run Ubuntu in Docker (for the compilation step).\r\n\r\nThis worked:\r\n\r\n    docker run -it -v \"$(pwd):/app\" ubuntu:latest /bin/bash\r\n\r\nThen:\r\n\r\n```\r\napt-get update && apt-get install python3-pip gcc libsqlite3-dev -y\r\ncd /app/tests\r\ngcc ext.c -fPIC -shared -o ext.so\r\ncd /app\r\npip3 install -e '.[test]'\r\npytest -k test_load_extension\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229128950", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229128950, "node_id": "IC_kwDOCGYnMM5JQwT2", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T05:42:04Z", "updated_at": "2022-08-27T05:42:04Z", "author_association": "OWNER", "body": "Extension looks to be correctly compiled:\r\n\r\n```\r\nRun (cd tests && gcc ext.c -fPIC -shared -o ext.so && ls -lah)\r\ntotal 412K\r\ndrwxr-xr-x 3 runner docker 4.0K Aug 27 05:40 .\r\ndrwxr-xr-x 8 runner docker 4.0K Aug 27 05:40 ..\r\n-rw-r--r-- 1 runner docker    0 Aug 27 05:40 __init__.py\r\n-rw-r--r-- 1 runner docker  760 Aug 27 05:40 conftest.py\r\n-rw-r--r-- 1 runner docker 1.6K Aug 27 05:40 ext.c\r\n-rwxr-xr-x 1 runner docker  16K Aug 27 05:40 ext.so\r\ndrwxr-xr-x 2 runner docker 4.0K Aug 27 05:40 sniff\r\n```\r\nSo why doesn't this check pass?\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/3f694e51a0212a297f663e2fc7f9cdad8775a550/tests/test_cli.py#L25-L30", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229128617", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229128617, "node_id": "IC_kwDOCGYnMM5JQwOp", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T05:39:06Z", "updated_at": "2022-08-27T05:39:06Z", "author_association": "OWNER", "body": "That didn't run the tests as expected on Ubuntu: https://github.com/simonw/sqlite-utils/runs/8048229213?check_suite_focus=true\r\n\r\n```\r\ntests/test_cli.py::test_load_extension[None-should_pass0-should_fail0] SKIPPED [ 19%]\r\ntests/test_cli.py::test_load_extension[sqlite3_ext_b_init-b-should_fail1] SKIPPED [ 19%]\r\ntests/test_cli.py::test_load_extension[sqlite3_ext_c_init-c-should_fail2] SKIPPED [ 19%]\r\n```\r\n\r\nThat should have worked because of this: https://github.com/simonw/sqlite-utils/blob/3f694e51a0212a297f663e2fc7f9cdad8775a550/.github/workflows/test.yml#L38-L41\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/470#issuecomment-1229115501", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/470", "id": 1229115501, "node_id": "IC_kwDOCGYnMM5JQtBt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-27T03:54:26Z", "updated_at": "2022-08-27T03:54:26Z", "author_association": "OWNER", "body": "I can borrow Alex's example extension for the tests too: https://github.com/simonw/datasette/blob/ba35105eee2d3ba620e4f230028a02b2e2571df2/tests/ext.c", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1352932038, "label": "Upgrade `--load-extension` to accept entrypoints like Datasette"}, "performed_via_github_app": null}