{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319525520", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319525520, "node_id": "IC_kwDOBm6k_c5OplyQ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T04:21:14Z", "updated_at": "2022-11-18T07:22:37Z", "author_association": "OWNER", "body": "This search helps too: [https://ripgrep.datasette.io/-/ripgrep?pattern=%7B%25+block+nav&literal=on&ignore=on&glob=%21datasette%2F**](https://ripgrep.datasette.io/-/ripgrep?pattern=%7B%25+block+nav&literal=on&ignore=on&glob=%21datasette%2F**)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319627012", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319627012, "node_id": "IC_kwDOBm6k_c5Op-kE", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T07:07:03Z", "updated_at": "2022-11-18T07:07:03Z", "author_association": "OWNER", "body": "Here's the full list of 10 plugin releases for this issue:\r\n\r\n* [datasette-search-all 1.1.1](https://github.com/simonw/datasette-search-all/releases/tag/1.1.1)\r\n* [datasette-ripgrep 0.7.1](https://github.com/simonw/datasette-ripgrep/releases/tag/0.7.1)\r\n* [datasette-socrata 0.3.1](https://github.com/simonw/datasette-socrata/releases/tag/0.3.1)\r\n* [datasette-configure-fts 1.1.1](https://github.com/simonw/datasette-configure-fts/releases/tag/1.1.1)\r\n* [datasette-edit-templates 0.2](https://github.com/simonw/datasette-edit-templates/releases/tag/0.2)\r\n* [datasette-copyable 0.3.2](https://github.com/simonw/datasette-copyable/releases/tag/0.3.2)\r\n* [datasette-public 0.2.1](https://github.com/simonw/datasette-public/releases/tag/0.2.1)\r\n* [datasette-import-table 0.3.1](https://github.com/simonw/datasette-import-table/releases/tag/0.3.1)\r\n* [datasette-indieauth 1.2.2](https://github.com/simonw/datasette-indieauth/releases/tag/1.2.2)\r\n* [datasette-edit-schema 0.5.2](https://github.com/simonw/datasette-edit-schema/releases/tag/0.5.2)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319493475", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319493475, "node_id": "IC_kwDOBm6k_c5Opd9j", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T03:19:25Z", "updated_at": "2022-11-18T07:03:03Z", "author_association": "OWNER", "body": "Other plugins this looks like it will affect:\r\n\r\n- [x] `datasette-ripgrep` https://github.com/simonw/datasette-ripgrep/blob/03446464420130368582022eeb5944993f64ec8f/datasette_ripgrep/templates/ripgrep.html#L37-L42\r\n- [x] `datasette-socrata` https://github.com/simonw/datasette-socrata/blob/32fb256a461bf0e790eca10bdc7dd9d96c20f7c4/datasette_socrata/templates/datasette_socrata_error.html#L5-L10\r\n- [x] `datasette-configure-fts` https://github.com/simonw/datasette-configure-fts/blob/eca742e5d4b9190fc22d68bc0a406c575e6d09a0/datasette_configure_fts/templates/configure_fts_database.html#L9-L14\r\n- [x] `datasette-edit-templates` https://github.com/simonw/datasette-edit-templates/blob/f772aff4a2a4080c949746668a8ec6302dbeb0d9/datasette_edit_templates/templates/edit_template.html#L17-L23\r\n- [x] `datasette-copyable` https://github.com/simonw/datasette-copyable/blob/204d5c912a8d48c49155c67fba7339d4bb26ab9a/datasette_copyable/templates/copyable.html#L36-L43\r\n- [x] `datasette-public` https://github.com/simonw/datasette-public/blob/32b6a0ba53bd5714b6b41eddd8705b213c105efc/datasette_public/templates/public_table_change_privacy.html#L5-L11\r\n- [x] `datasette-import-table` https://github.com/simonw/datasettecloud-datasette/blob/37d0fe525c6649c1aec3d1ee8bc35a684570e87f/templates/import_data.html#L5-L10\r\n- [x] `datasette-edit-schema` (three places)\r\n- [x] `datasette-indieauth` https://github.com/simonw/datasette-indieauth/blob/a08ce67ddad6098b1240adbeff37d040e4df53b1/datasette_indieauth/templates/indieauth.html#L5-L10", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319623911", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319623911, "node_id": "IC_kwDOBm6k_c5Op9zn", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T07:02:56Z", "updated_at": "2022-11-18T07:02:56Z", "author_association": "OWNER", "body": "That's all of them!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319588163", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319588163, "node_id": "IC_kwDOBm6k_c5Op1FD", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T06:05:11Z", "updated_at": "2022-11-18T06:05:11Z", "author_association": "OWNER", "body": "For `datasette-copyable` I want to show breadcrumbs that take database/instance permissions into account, so I'm removing `{% block nav %}` entirely and replacing it with this:\r\n\r\n```html+jinja\r\n{% block crumbs %}\r\n{{ crumbs.nav(request=request, database=database, table=table) }}\r\n{% endblock %}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319528359", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319528359, "node_id": "IC_kwDOBm6k_c5Opmen", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T04:27:00Z", "updated_at": "2022-11-18T04:27:00Z", "author_association": "OWNER", "body": "Also `datasette-indieauth` https://github.com/simonw/datasette-indieauth/blob/a08ce67ddad6098b1240adbeff37d040e4df53b1/datasette_indieauth/templates/indieauth.html#L5-L10", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319483555", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319483555, "node_id": "IC_kwDOBm6k_c5Opbij", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T03:02:35Z", "updated_at": "2022-11-18T03:02:35Z", "author_association": "OWNER", "body": "Looks like this issue could affect a bunch of other plugins too: https://cs.github.com/?scopeName=All+repos&scope=&q=%3Cp+class%3D%22crumbs%22%3E+user%3Asimonw", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1901#issuecomment-1319482791", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1901", "id": 1319482791, "node_id": "IC_kwDOBm6k_c5OpbWn", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-11-18T03:01:36Z", "updated_at": "2022-11-18T03:01:36Z", "author_association": "OWNER", "body": "Good catch. Looks like that bug was introduced by this change: https://github.com/simonw/datasette/commit/1a5e5f2aa951e5bd731067a49819efba68fbe8ef\r\n\r\nFrom:\r\n\r\n- https://github.com/simonw/datasette/issues/1831\r\n\r\nThe search all plugin includes this code which interacts poorly with that refactor:\r\n\r\nhttps://github.com/simonw/datasette-search-all/blob/847b55c368a285e4567627029624d7872ee75cac/datasette_search_all/templates/search_all.html#L31-L36\r\n\r\n```html+jinja\r\n{% block nav %}\r\n    <p class=\"crumbs\">\r\n        <a href=\"{{ urls.instance() }}\">home</a>\r\n    </p>\r\n    {{ super() }}\r\n{% endblock %}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1453813400, "label": "Some plugins show \"home\" breadcrumbs twice in the top left"}, "performed_via_github_app": null}