{"html_url": "https://github.com/simonw/datasette/issues/1973#issuecomment-1368936146", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1973", "id": 1368936146, "node_id": "IC_kwDOBm6k_c5RmE7S", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-02T13:13:03Z", "updated_at": "2023-01-02T13:13:03Z", "author_association": "OWNER", "body": "It's quite handy that the label for foreign keys is made available to the custom render function here - if that was properly documented (and maybe had a slightly more intuitive API) I think it might be a good solution here.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515815014, "label": "render_cell plugin hook's row object is not a sqlite.Row"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1973#issuecomment-1368935320", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1973", "id": 1368935320, "node_id": "IC_kwDOBm6k_c5RmEuY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-02T13:12:00Z", "updated_at": "2023-01-02T13:12:00Z", "author_association": "OWNER", "body": "Thanks for catching this!\r\n\r\nDefinitely a bug. This might be a good opportunity to reconsider how his should work though.\r\n\r\nIt's possible that Datasette will eventually support alternative database backends - PostgreSQL, DuckDB and ClickHouse are all on my radar here.\r\n\r\nIf that happens, this plugin hook returning a SQLite Row wouldn't make sense.\r\n\r\nSome kind of thing abstraction layer - maybe CustomRow, maybe something a little bit better - might be a good idea.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515815014, "label": "render_cell plugin hook's row object is not a sqlite.Row"}, "performed_via_github_app": null}