{"html_url": "https://github.com/simonw/datasette/issues/150#issuecomment-392568047", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/150", "id": 392568047, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MjU2ODA0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-28T16:41:28Z", "updated_at": "2018-05-28T16:41:28Z", "author_association": "OWNER", "body": "Closing this as obsolete since we have facets now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 276704327, "label": "_group_count= feature improvements"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/150#issuecomment-379559319", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/150", "id": 379559319, "node_id": "MDEyOklzc3VlQ29tbWVudDM3OTU1OTMxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-08T15:35:43Z", "updated_at": "2018-04-08T15:35:43Z", "author_association": "OWNER", "body": "From a code point of view, the current mechanism for `_group_count` makes the `TableView` even **more** complicated:\r\n\r\nhttps://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L644-L653\r\n\r\nInstead, I think if `_group_count` is detected we should generate the SQL and then defer to `self.custom_sql`, like we do for canned queries:\r\n\r\nhttps://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L539-L541", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 276704327, "label": "_group_count= feature improvements"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/150#issuecomment-379559214", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/150", "id": 379559214, "node_id": "MDEyOklzc3VlQ29tbWVudDM3OTU1OTIxNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-08T15:33:58Z", "updated_at": "2018-04-08T15:33:58Z", "author_association": "OWNER", "body": "The single biggest challenge here is expanding foreign key references. This is the blocker that prevents `_group_count` from being useful at the moment.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 276704327, "label": "_group_count= feature improvements"}, "performed_via_github_app": null}